diff mbox series

[v2,01/25] linux: mips: Split libpthread.abilist in n32 and n64

Message ID 20210518205613.1487824-2-adhemerval.zanella@linaro.org
State Superseded
Headers
Series Add 64 bit time support on legacy ABIs |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Adhemerval Zanella May 18, 2021, 8:55 p.m. UTC 
  The n32 will require the 64 bit time symbols for y2038 support.
---
 .../mips/mips64/{ => n32}/libpthread.abilist      |  0
 .../sysv/linux/mips/mips64/n64/libpthread.abilist | 15 +++++++++++++++
 2 files changed, 15 insertions(+)
 rename sysdeps/unix/sysv/linux/mips/mips64/{ => n32}/libpthread.abilist (100%)
 create mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist

Comments

Lukasz Majewski May 19, 2021, 8:24 a.m. UTC | #1 
On Tue, 18 May 2021 17:55:49 -0300
Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:

> The n32 will require the 64 bit time symbols for y2038 support.
> ---
>  .../mips/mips64/{ => n32}/libpthread.abilist      |  0
>  .../sysv/linux/mips/mips64/n64/libpthread.abilist | 15
> +++++++++++++++ 2 files changed, 15 insertions(+)
>  rename sysdeps/unix/sysv/linux/mips/mips64/{ =>
> n32}/libpthread.abilist (100%) create mode 100644
> sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
> 
> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist
> b/sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
> similarity index 100% rename from
> sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist rename to
> sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist diff --git
> a/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
> b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist new file
> mode 100644 index 0000000000..a5f3d5ce2a

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Florian Weimer May 20, 2021, 6:38 a.m. UTC | #2 
* Adhemerval Zanella via Libc-alpha:

> The n32 will require the 64 bit time symbols for y2038 support.
> ---
>  .../mips/mips64/{ => n32}/libpthread.abilist      |  0
>  .../sysv/linux/mips/mips64/n64/libpthread.abilist | 15 +++++++++++++++
>  2 files changed, 15 insertions(+)
>  rename sysdeps/unix/sysv/linux/mips/mips64/{ => n32}/libpthread.abilist (100%)
>  create mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
>
> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
> similarity index 100%
> rename from sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist
> rename to sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
> new file mode 100644
> index 0000000000..a5f3d5ce2a
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
> @@ -0,0 +1,15 @@
> +GLIBC_2.0 __errno_location F
> +GLIBC_2.0 pthread_create F
> +GLIBC_2.11 __libpthread_version_placeholder F
> +GLIBC_2.12 __libpthread_version_placeholder F
> +GLIBC_2.18 __libpthread_version_placeholder F
> +GLIBC_2.2 pthread_create F
> +GLIBC_2.2.3 __libpthread_version_placeholder F
> +GLIBC_2.2.6 __libpthread_version_placeholder F
> +GLIBC_2.28 thrd_create F
> +GLIBC_2.3.2 __libpthread_version_placeholder F
> +GLIBC_2.3.3 __libpthread_version_placeholder F
> +GLIBC_2.3.4 __libpthread_version_placeholder F
> +GLIBC_2.30 __libpthread_version_placeholder F
> +GLIBC_2.31 __libpthread_version_placeholder F
> +GLIBC_2.4 __libpthread_version_placeholder F

That looks wrong, there are no time-dependent symbols left in
libpthread, so the split isn't needed.

Thanks,
Florian
Adhemerval Zanella May 20, 2021, 10:43 a.m. UTC | #3 
On 20/05/2021 03:38, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
> 
>> The n32 will require the 64 bit time symbols for y2038 support.
>> ---
>>  .../mips/mips64/{ => n32}/libpthread.abilist      |  0
>>  .../sysv/linux/mips/mips64/n64/libpthread.abilist | 15 +++++++++++++++
>>  2 files changed, 15 insertions(+)
>>  rename sysdeps/unix/sysv/linux/mips/mips64/{ => n32}/libpthread.abilist (100%)
>>  create mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
>>
>> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
>> similarity index 100%
>> rename from sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist
>> rename to sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
>> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
>> new file mode 100644
>> index 0000000000..a5f3d5ce2a
>> --- /dev/null
>> +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
>> @@ -0,0 +1,15 @@
>> +GLIBC_2.0 __errno_location F
>> +GLIBC_2.0 pthread_create F
>> +GLIBC_2.11 __libpthread_version_placeholder F
>> +GLIBC_2.12 __libpthread_version_placeholder F
>> +GLIBC_2.18 __libpthread_version_placeholder F
>> +GLIBC_2.2 pthread_create F
>> +GLIBC_2.2.3 __libpthread_version_placeholder F
>> +GLIBC_2.2.6 __libpthread_version_placeholder F
>> +GLIBC_2.28 thrd_create F
>> +GLIBC_2.3.2 __libpthread_version_placeholder F
>> +GLIBC_2.3.3 __libpthread_version_placeholder F
>> +GLIBC_2.3.4 __libpthread_version_placeholder F
>> +GLIBC_2.30 __libpthread_version_placeholder F
>> +GLIBC_2.31 __libpthread_version_placeholder F
>> +GLIBC_2.4 __libpthread_version_placeholder F
> 
> That looks wrong, there are no time-dependent symbols left in
> libpthread, so the split isn't needed.
> 
> Thanks,
> Florian
> 

Indeed this patch is not required anymore (the libpthread files are not updated
for n32 when the 64-bit time symbols).

I will remove it.
Carlos O'Donell June 4, 2021, 7:29 p.m. UTC | #4 
On 5/18/21 4:55 PM, Adhemerval Zanella wrote:
> The n32 will require the 64 bit time symbols for y2038 support.
> ---
>  .../mips/mips64/{ => n32}/libpthread.abilist      |  0
>  .../sysv/linux/mips/mips64/n64/libpthread.abilist | 15 +++++++++++++++
>  2 files changed, 15 insertions(+)
>  rename sysdeps/unix/sysv/linux/mips/mips64/{ => n32}/libpthread.abilist (100%)
>  create mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
> 
> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
> similarity index 100%
> rename from sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist
> rename to sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
> new file mode 100644
> index 0000000000..a5f3d5ce2a
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
> @@ -0,0 +1,15 @@
> +GLIBC_2.0 __errno_location F
> +GLIBC_2.0 pthread_create F
> +GLIBC_2.11 __libpthread_version_placeholder F
> +GLIBC_2.12 __libpthread_version_placeholder F
> +GLIBC_2.18 __libpthread_version_placeholder F
> +GLIBC_2.2 pthread_create F
> +GLIBC_2.2.3 __libpthread_version_placeholder F
> +GLIBC_2.2.6 __libpthread_version_placeholder F
> +GLIBC_2.28 thrd_create F
> +GLIBC_2.3.2 __libpthread_version_placeholder F
> +GLIBC_2.3.3 __libpthread_version_placeholder F
> +GLIBC_2.3.4 __libpthread_version_placeholder F
> +GLIBC_2.30 __libpthread_version_placeholder F
> +GLIBC_2.31 __libpthread_version_placeholder F
> +GLIBC_2.4 __libpthread_version_placeholder F
 
This file is dropped per Florian's review.
diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
similarity index 100%
rename from sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist
rename to sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist
diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
new file mode 100644
index 0000000000..a5f3d5ce2a
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist
@@ -0,0 +1,15 @@ 
+GLIBC_2.0 __errno_location F
+GLIBC_2.0 pthread_create F
+GLIBC_2.11 __libpthread_version_placeholder F
+GLIBC_2.12 __libpthread_version_placeholder F
+GLIBC_2.18 __libpthread_version_placeholder F
+GLIBC_2.2 pthread_create F
+GLIBC_2.2.3 __libpthread_version_placeholder F
+GLIBC_2.2.6 __libpthread_version_placeholder F
+GLIBC_2.28 thrd_create F
+GLIBC_2.3.2 __libpthread_version_placeholder F
+GLIBC_2.3.3 __libpthread_version_placeholder F
+GLIBC_2.3.4 __libpthread_version_placeholder F
+GLIBC_2.30 __libpthread_version_placeholder F
+GLIBC_2.31 __libpthread_version_placeholder F
+GLIBC_2.4 __libpthread_version_placeholder F