From patchwork Tue May 18 04:40:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 43442 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E23F389683F; Tue, 18 May 2021 04:40:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E23F389683F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621312841; bh=LXCWfXQPw4cP08L1uYBJxEM9U5Q9c+YFqizWhgFhsjs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=E16Hfk+jr8GS4TUj/iCYkAl3OGpOO7Von8i6JlxqpRguL+3nxnJRWibez3ZuSqVup Z6y0l4KyWz33RIbTZ87gSwLUcDDmMauZGWDiXRMMXQzXTLEjWpxpLpOCScIKd7zE/X I+KcgqoBZATWtTgU6Q1+rjED8TztBjSXHP5IOqCY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from insect.birch.relay.mailchannels.net (insect.birch.relay.mailchannels.net [23.83.209.93]) by sourceware.org (Postfix) with ESMTPS id 2B098383D005 for ; Tue, 18 May 2021 04:40:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B098383D005 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5ACDA321BC5; Tue, 18 May 2021 04:40:37 +0000 (UTC) Received: from pdx1-sub0-mail-a84.g.dreamhost.com (100-101-162-48.trex.outbound.svc.cluster.local [100.101.162.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id AB1133214D3; Tue, 18 May 2021 04:40:36 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a84.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.101.162.48 (trex/6.2.1); Tue, 18 May 2021 04:40:37 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Irritate-Stop: 2a1c1fe86ead3f23_1621312836933_2827867093 X-MC-Loop-Signature: 1621312836932:201082241 X-MC-Ingress-Time: 1621312836932 Received: from pdx1-sub0-mail-a84.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a84.g.dreamhost.com (Postfix) with ESMTP id 4E3EF8844E; Mon, 17 May 2021 21:40:36 -0700 (PDT) Received: from rhbox.intra.reserved-bit.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a84.g.dreamhost.com (Postfix) with ESMTPSA id D53C789A8B; Mon, 17 May 2021 21:40:34 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a84 To: libc-alpha@sourceware.org Subject: [COMMITTED 1/3] charmap_conversion: Free conversion table on exit Date: Tue, 18 May 2021 10:10:10 +0530 Message-Id: <20210518044012.910681-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3494.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Siddhesh Poyarekar via Libc-alpha From: Siddhesh Poyarekar Reply-To: Siddhesh Poyarekar Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" The conversion table is allocated using xcalloc but never freed. Reviewed-by: Adhemerval Zanella --- iconv/iconv_charmap.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/iconv/iconv_charmap.c b/iconv/iconv_charmap.c index f76b3ce2b1..e2d53fee3c 100644 --- a/iconv/iconv_charmap.c +++ b/iconv/iconv_charmap.c @@ -53,6 +53,12 @@ allocate_table (void) return (struct convtable *) xcalloc (1, sizeof (struct convtable)); } +static inline void +free_table (struct convtable *tbl) +{ + free (tbl); +} + static inline int is_term (struct convtable *tbl, unsigned int idx) @@ -228,6 +234,7 @@ charmap_conversion (const char *from_code, struct charmap_t *from_charmap, while (++remaining < argc); /* All done. */ + free_table (cvtbl); return status; }