From patchwork Tue May 11 17:17:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 43377 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 09801398B42A; Tue, 11 May 2021 17:17:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 09801398B42A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620753475; bh=bifak1hDPfjDNF1hsQY/b+6TwvjL7WuhmAmzEvi9Peg=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=rkeo/v74/VM6AxsaYbYBvqGSSXGNAyDJe4DGLAYTZEggdz+sbUeMyYLnponDiMWOt kr/KLrxkbXR7VGwGRKygwSva3zSzByvF7G49RGXjy8i14U6bKOyG51GbKRLOHxi3lx ph0b4NCDcFc2ZMOq29Oba6r4qBmkWMtMyKSPuM1k= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from black.elm.relay.mailchannels.net (black.elm.relay.mailchannels.net [23.83.212.19]) by sourceware.org (Postfix) with ESMTPS id 13B9A3865474 for ; Tue, 11 May 2021 17:17:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 13B9A3865474 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0C501361E5D for ; Tue, 11 May 2021 17:17:48 +0000 (UTC) Received: from pdx1-sub0-mail-a29.g.dreamhost.com (100-96-11-138.trex.outbound.svc.cluster.local [100.96.11.138]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 826A7361DED for ; Tue, 11 May 2021 17:17:47 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a29.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.11.138 (trex/6.2.1); Tue, 11 May 2021 17:17:47 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Skirt-Reaction: 267242256bd506ad_1620753467762_1883009773 X-MC-Loop-Signature: 1620753467762:3379014021 X-MC-Ingress-Time: 1620753467762 Received: from pdx1-sub0-mail-a29.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a29.g.dreamhost.com (Postfix) with ESMTP id 434ED7E3CB for ; Tue, 11 May 2021 10:17:47 -0700 (PDT) Received: from rhbox.redhat.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a29.g.dreamhost.com (Postfix) with ESMTPSA id 2C1857E4A9 for ; Tue, 11 May 2021 10:17:45 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a29 To: libc-alpha@sourceware.org Subject: [PATCH] show_archive_content: Fix trivial memory leak Date: Tue, 11 May 2021 22:47:38 +0530 Message-Id: <20210511171738.360327-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3494.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Siddhesh Poyarekar via Libc-alpha From: Siddhesh Poyarekar Reply-To: Siddhesh Poyarekar Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Fix trivial leak identified by coverity. The program runs to exit and the leak doesn't grow, but it's just cleaner to free the allocated memory. Reviewed-by: Adhemerval Zanella --- locale/programs/locarchive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/locale/programs/locarchive.c b/locale/programs/locarchive.c index 6bb189ae37..f38e835c52 100644 --- a/locale/programs/locarchive.c +++ b/locale/programs/locarchive.c @@ -1742,6 +1742,7 @@ show_archive_content (const char *fname, int verbose) : locnames[idx]); } } + free (files); } else for (cnt = 0; cnt < used; ++cnt)