diff mbox series

[26/39] open.2: Remove unused <sys/stat.h>

Message ID	20210510175546.28445-27-alx.manpages@gmail.com
State	Not applicable
Headers	DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B0203987C35 To: mtk.manpages@gmail.com Subject: [PATCH 26/39] open.2: Remove unused <sys/stat.h> Date: Mon, 10 May 2021 19:55:35 +0200 Message-Id: <20210510175546.28445-27-alx.manpages@gmail.com> In-Reply-To: <20210510175546.28445-1-alx.manpages@gmail.com> References: <20210510175546.28445-1-alx.manpages@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Alejandro Colomar via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alejandro Colomar <alx.manpages@gmail.com> Cc: Florian Weimer <fweimer@redhat.com>, Jakub Wilk <jwilk@jwilk.net>, Alejandro Colomar <alx.manpages@gmail.com>, libc-alpha@sourceware.org, linux-man@vger.kernel.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org>
Series	man2: SYNOPSIS: Fix headers, use syscall(), and other fixes \| [00/39] man2: SYNOPSIS: Fix headers, use syscall(), and other fixes [01/39] futex.2: Use syscall(SYS_...); for system calls without a wrapper [02/39] getdents.2: Use syscall(SYS_...); for system calls without a wrapper [03/39] ioctl_tty.2: Fix includes [04/39] ioctl_userfaultfd.2: SYNOPSIS: Add <linux/userfaultfd.h> [05/39] io_destroy.2: Use syscall(SYS_...); for system calls without a wrapper [06/39] io_getevents.2: Use syscall(SYS_...); for system calls without a wrapper [07/39] ioperm.2: Remove obvious comment [08/39] ioprio_set.2: Use syscall(SYS_...); for system calls without a wrapper [09/39] ipc.2: Use syscall(SYS_...); for system calls without a wrapper [10/39] ipc.2: Add needed include [11/39] kcmp.2: Use syscall(SYS_...); for system calls without a wrapper [12/39] kcmp.2: tfix [13/39] kexec_load.2: Use syscall(SYS_...); for system calls without a wrapper [14/39] scripts/bash_aliases: man_lsfunc(): Extract syscall name from syscall(SYS_...) [15/39] keyctl.2: Use syscall(SYS_...); for system calls without a glibc wrapper [16/39] link.2: ffix [17/39] llseek.2: Use syscall(SYS_...); for system calls without a wrapper [18/39] lookup_dcookie.2: Use syscall(SYS_...); for system calls without a wrapper [19/39] membarrier.2: Use syscall(SYS_...); for system calls without a wrapper [20/39] mincore.2: Remove unused include [21/39] mknod.2: Remove unused includes [22/39] mmap2.2: Use syscall(SYS_...); for system calls without a wrapper [23/39] modify_ldt.2: Use syscall(SYS_...); for system calls without a wrapper [24/39] mq_getsetattr.2: Use syscall(SYS_...); for system calls without a wrapper [25/39] alloc_hugepages.2, arch_prctl.2, capget.2, clone.2, delete_module.2, exit_group.2, get_robu… [26/39] open.2: Remove unused <sys/stat.h> [27/39] openat2.2: Use syscall(SYS_...); for system calls without a wrapper; fix includes too [28/39] perf_event_open.2: Use syscall(SYS_...); for system calls without a wrapper [29/39] pidfd_getfd.2: Use syscall(SYS_...); for system calls without a wrapper [30/39] pidfd_open.2: Use syscall(SYS_...); for system calls without a wrapper [31/39] pidfd_send_signal.2: Use syscall(SYS_...); for system calls without a wrapper. Fix includes… [32/39] pipe.2: wfix [33/39] pivot_root.2: Use syscall(SYS_...); for system calls without a wrapper [34/39] poll.2: Remove <signal.h> [35/39] process_madvise.2: Use syscall(SYS_...); for system calls without a wrapper. Fix includes t… [36/39] quotactl.2: Better detail why <xfs/xqm.h> is included [37/39] readdir.2: Use syscall(SYS_...); for system calls without a wrapper [38/39] readlink.2: ffix [39/39] reboot.2: Use syscall(SYS_...); for system calls without a wrapper

Checks

Context	Check	Description
dj/TryBot-apply_patch	fail	Patch failed to apply to master at the time it was sent

Commit Message

Alejandro Colomar May 10, 2021, 5:55 p.m. UTC

  I can't see a reason to include it.  <fcntl.h> provides O_*
constants for 'flags', S_* constants for 'mode', and mode_t.

Probably a long time ago, some of those weren't defined in
<fcntl.h>, and both headers needed to be included, or maybe it's
a historical error.

Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
 man2/open.2 | 1 -
 1 file changed, 1 deletion(-)

Comments

Alejandro Colomar May 10, 2021, 6:02 p.m. UTC | #1

On 5/10/21 7:55 PM, Alejandro Colomar wrote:
> I can't see a reason to include it.  <fcntl.h> provides O_*
> constants for 'flags', S_* constants for 'mode', and mode_t.
> 
> Probably a long time ago, some of those weren't defined in
> <fcntl.h>, and both headers needed to be included, or maybe it's
> a historical error.
> 
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

Drop this one, please.  (We discussed it yesterday.)

> ---
>   man2/open.2 | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/man2/open.2 b/man2/open.2
> index bac1ee806..1bcd995f4 100644
> --- a/man2/open.2
> +++ b/man2/open.2
> @@ -53,7 +53,6 @@
>   open, openat, creat \- open and possibly create a file
>   .SH SYNOPSIS
>   .nf
> -.B #include <sys/stat.h>
>   .B #include <fcntl.h>
>   .PP
>   .BI "int open(const char *" pathname ", int " flags );
>

Michael Kerrisk \(man-pages\) May 11, 2021, 5:15 a.m. UTC | #2

On 5/11/21 6:02 AM, Alejandro Colomar (man-pages) wrote:
> On 5/10/21 7:55 PM, Alejandro Colomar wrote:
>> I can't see a reason to include it.  <fcntl.h> provides O_*
>> constants for 'flags', S_* constants for 'mode', and mode_t.
>>
>> Probably a long time ago, some of those weren't defined in
>> <fcntl.h>, and both headers needed to be included, or maybe it's
>> a historical error.
>>
>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> 
> Drop this one, please.  (We discussed it yesterday.)

Okay.

diff mbox series

Patch

diff --git a/man2/open.2 b/man2/open.2
index bac1ee806..1bcd995f4 100644
--- a/man2/open.2
+++ b/man2/open.2
@@ -53,7 +53,6 @@ 
 open, openat, creat \- open and possibly create a file
 .SH SYNOPSIS
 .nf
-.B #include <sys/stat.h>
 .B #include <fcntl.h>
 .PP
 .BI "int open(const char *" pathname ", int " flags );