From patchwork Mon May 3 20:54:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 43233 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 404EC3943541; Mon, 3 May 2021 20:54:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 404EC3943541 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620075269; bh=LAoJ9nIVM7UgaAl8z4q5YajobLFMW5bpjJR1Cedwgn8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=q6wZ3/opraZlHntLiqKM3cF+om+3tS2AWplmHuI8tOkxHS5OUi1oAU/TDfQsZd9ni JqaiXGpALWPRvkyCNWxe9IOwU/GgqljttPbyVea3zT5/IwTtEAoEurO9H1JJ6M0iPu cITW80rJX5Bh1RfBmIsiKVtFYRduvw4lqZnXxCtI= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by sourceware.org (Postfix) with ESMTPS id 6FCD7394482E for ; Mon, 3 May 2021 20:54:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6FCD7394482E Received: by mail-qk1-x729.google.com with SMTP id 197so6248023qkl.12 for ; Mon, 03 May 2021 13:54:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LAoJ9nIVM7UgaAl8z4q5YajobLFMW5bpjJR1Cedwgn8=; b=Gd3NRl8g6b/WQep/EZcQZZtuwWlH1crJqUn4NxHOOWUCKSJ+r9N0mxFlQYLRjZqo/X QnCcvgqdvDa4ZMpMr2HW19o6QRbhG09hYf4jXkTEkJW2NnytlaEO6JwgAttJWeiaDsoh HOHu2y3RDN9F0fyfXteTg/dMjihFiLWFThh/9zNmz7YT2w/OhjMNVvuNMKjSP37QPa9F jyMipzr5dBRTiWeAiEifcr3hOmmcw+4Un9BB7iXjCgIE+gQXOe7v+d5f7dTC4F97+BSc rKdP9jwImK2yEMUpRnI3EoFJPYwmnTxx83I8STqzk1K9mn7y4F7XbzG0q6g4smjtgxBL dSHg== X-Gm-Message-State: AOAM533XbhGchvaCsJotFB2vgInTmYbjJEQZGfQ0XRQZpIFDhaYxpKi9 99EYwqu152DZbmmzmcx4kqpjrMrurtpI9w== X-Google-Smtp-Source: ABdhPJyzD7RjlnPDj5FgDPEjKq5F5W/j2NUltaGt/WPPXCHvvsl409rwCarpBQs13NeChFdObNK5LA== X-Received: by 2002:a37:2714:: with SMTP id n20mr8599201qkn.434.1620075265915; Mon, 03 May 2021 13:54:25 -0700 (PDT) Received: from birita.. ([177.194.41.149]) by smtp.googlemail.com with ESMTPSA id f125sm9471130qkj.38.2021.05.03.13.54.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 13:54:25 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v3 2/4] posix: Do not clobber errno by atfork handlers Date: Mon, 3 May 2021 17:54:17 -0300 Message-Id: <20210503205419.2890929-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210503205419.2890929-1-adhemerval.zanella@linaro.org> References: <20210503205419.2890929-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Changes from v2: * Set/restore errno unconditionally. Changes from v1: * Move the errno set/restore to parent branch. --- Checked on x86_64-linux-gnu. --- posix/fork.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/posix/fork.c b/posix/fork.c index cc1bdc1232..ff527a74f2 100644 --- a/posix/fork.c +++ b/posix/fork.c @@ -99,6 +99,9 @@ __libc_fork (void) } else { + /* If _Fork failed, preserve its errno value. */ + int save_errno = errno; + /* Release acquired locks in the multi-threaded case. */ if (multiple_threads) { @@ -111,6 +114,8 @@ __libc_fork (void) /* Run the handlers registered for the parent. */ __run_fork_handlers (atfork_run_parent, multiple_threads); + + __set_errno (save_errno); } return pid;