From patchwork Mon Apr 19 14:18:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 43041 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F4C53947C38; Mon, 19 Apr 2021 14:18:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F4C53947C38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618841921; bh=Qqk6HGRQoih5R/wy0rYnSLnSlPnvvSaRc72HxoJB/HM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mEEmTIWUnGUy4kYGnWVnyaTQ0/3KdZh6RxM5XPfoAEGqjVtvMP2XoyEihir6cT/vR U883SY57aAxoaR5IRKImCws1RQ1Pvm7C5zJd0Cx76Bu09sQqJGvRlu3J92BczTqL4R 3aYAd7oSGHNUYngFbpakmV5Nebh9luziHgZi27kU= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 6A949385E013 for ; Mon, 19 Apr 2021 14:18:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6A949385E013 Received: by mail-pg1-x52e.google.com with SMTP id d10so24346014pgf.12 for ; Mon, 19 Apr 2021 07:18:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qqk6HGRQoih5R/wy0rYnSLnSlPnvvSaRc72HxoJB/HM=; b=sCNV0L3fFDfUT5K8JeaR8NcBTt4yk486DCBH/MAQcivWenDEfNCfejmvnb79z2/fY3 REI6jfmfuD/UUxuFj1kjtzRCJ3U6x1FJVe17mO3J5XoxoR5UPS/mWMTmrM7WblS9v6Vi 4sk7Y/V1Slv+AXsSh+kiRpJDZsN3BHlPa/FHQAV1lWMReG8rybuPPtWxVXT8CGuwJbj5 LzOj2FkXcTTjtW6cLZElPgjpcJvtyTtBngsYQJTWbD9BgZ1FAdY45zVAZIbE5JyU9b+8 urF4NeodJdEjszdtcrcqYyKnPAWkwxIzAOFShwONneqfFY747L1RE8oCUQGDbn9saUnv 4HQw== X-Gm-Message-State: AOAM533NVyexdyW8FMv7yCWZ+MYSX4EUGBh4IzkLP2q0pd98gOOw/sCj Jh/vUTNLPpcrw3q5hEqRcp7t6c4C7DGL5Q== X-Google-Smtp-Source: ABdhPJyQpdpkr7i9OA3Av0oIZi3zImE1h1fCTiN87W32LEpX4YcvE4zHbeEJCGEXBwsQKjgpQPW6OA== X-Received: by 2002:a62:5a83:0:b029:222:c9de:5c65 with SMTP id o125-20020a625a830000b0290222c9de5c65mr20197211pfb.23.1618841913158; Mon, 19 Apr 2021 07:18:33 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([2607:fb90:a62d:2d5e:38da:e56e:0:c66]) by smtp.gmail.com with ESMTPSA id s21sm14890960pjr.52.2021.04.19.07.18.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 07:18:32 -0700 (PDT) Received: from gnu-cfl-2.lan (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id 626191A00D8 for ; Mon, 19 Apr 2021 07:18:31 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] x86-64: Require BMI2 for __strlen_evex and __strnlen_evex Date: Mon, 19 Apr 2021 07:18:31 -0700 Message-Id: <20210419141831.546059-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-3035.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" I am committing this patch as an obvious fix. H.J. --- Since __strlen_evex and __strnlen_evex use sarx c4 e2 6a f7 c0 sarx %edx,%eax,%eax require BMI2 for __strlen_evex and __strnlen_evex in ifunc-impl-list.c. ifunc-avx2.h already requires BMI2 for EVEX implementation. --- sysdeps/x86_64/multiarch/ifunc-impl-list.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c index 770986e41a..f1a755b1d6 100644 --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c @@ -293,7 +293,8 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, __strlen_avx2_rtm) IFUNC_IMPL_ADD (array, i, strlen, (CPU_FEATURE_USABLE (AVX512VL) - && CPU_FEATURE_USABLE (AVX512BW)), + && CPU_FEATURE_USABLE (AVX512BW) + && CPU_FEATURE_USABLE (BMI2)), __strlen_evex) IFUNC_IMPL_ADD (array, i, strlen, 1, __strlen_sse2)) @@ -308,7 +309,8 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, __strnlen_avx2_rtm) IFUNC_IMPL_ADD (array, i, strnlen, (CPU_FEATURE_USABLE (AVX512VL) - && CPU_FEATURE_USABLE (AVX512BW)), + && CPU_FEATURE_USABLE (AVX512BW) + && CPU_FEATURE_USABLE (BMI2)), __strnlen_evex) IFUNC_IMPL_ADD (array, i, strnlen, 1, __strnlen_sse2))