Message ID | 20210324182915.29042-1-alx.manpages@gmail.com |
---|---|
State | Committed |
Commit | 8786bf6eb60cd5e2c80bace42714b4de3bda8c4e |
Delegated to: | Adhemerval Zanella Netto |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6DE883851C39; Wed, 24 Mar 2021 18:30:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DE883851C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616610605; bh=PX892sSTMWtCI2r56pwRCWu7hcz/RWSP0zfxXGJsO8w=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OYJBsYA1mDNs7nCVBW4hrc2Ta/cGXMb127sUyJ3gFjJodiMhJW/AvPnGFcIo3W+Vw TswS57DOviSQMMmWyJIsFnurV/GMupE/XEHjFVLgCm0banketpxjncc64UQaYxs7zS ckbn9hV5DTSeF1trPqjz5NuJv+2YbDKB6B+lAqZY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id CD9283857C50 for <libc-alpha@sourceware.org>; Wed, 24 Mar 2021 18:30:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CD9283857C50 Received: by mail-wr1-x435.google.com with SMTP id v11so25432003wro.7 for <libc-alpha@sourceware.org>; Wed, 24 Mar 2021 11:30:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PX892sSTMWtCI2r56pwRCWu7hcz/RWSP0zfxXGJsO8w=; b=jFLEYeL4vLzYUqm37EA6+IW9uPQ0bczjswPvF4f/fGY7FEXaFoUiyoW5sUZXHK5ouF AwORG2Pg2mmv66mlkFWlO0JjIT68w4/W7ZKVz2PgXnCykztj603N3ymNlsutjotWmib6 2bQLutEmfNlYmZKczFUfJ6aPbRCdJPX7n5TDWBoaeVzzI+KkwNog/mhSIUA9SRAsyOgN OqPBIPfUNkhxV53BCm1nT1dFLvrRGNDoNWvha5aJWhnTybFVJx7bRH/XkCyHK1xR9h2F xQuiqSolyRBiVRdpvyTuwNcLshEr7Jn/mnGRs5o1rV+twN3RJ73w3wYImKl2L1xLU8q1 Eiaw== X-Gm-Message-State: AOAM533nMOrnVQmNSDlNqNqMzA51HIgyUdGgxRtf76c4pIbtErikqZKE gHPNp9HlhMISZfgzIIeVFCadqMUeFik= X-Google-Smtp-Source: ABdhPJwy6oODLeQsP6dkZPI/e2q0Vf7NiZEToknb/+ndMidtp5DKYAry9sjsZ1mMus6g/W+erzWzXg== X-Received: by 2002:a05:6000:18d2:: with SMTP id w18mr4937263wrq.88.1616610601979; Wed, 24 Mar 2021 11:30:01 -0700 (PDT) Received: from localhost.localdomain ([170.253.36.171]) by smtp.googlemail.com with ESMTPSA id r1sm4444422wrj.63.2021.03.24.11.30.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 11:30:01 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v2] stdio-common/printf-prs.c: Reword comment Date: Wed, 24 Mar 2021 19:29:16 +0100 Message-Id: <20210324182915.29042-1-alx.manpages@gmail.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <830f204e-b1bd-424a-73b8-275b18582c7e@gmail.com> References: <830f204e-b1bd-424a-73b8-275b18582c7e@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Alejandro Colomar via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alejandro Colomar <alx.manpages@gmail.com> Cc: Alejandro Colomar <alx.manpages@gmail.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
[v2] stdio-common/printf-prs.c: Reword comment
|
|
Commit Message
Alejandro Colomar
March 24, 2021, 6:29 p.m. UTC
'this' can be understood as the current parameter, but in this case it
is meaning the other one, the one holding the width/precission.
'it' better describes that parameter, differentiating it from the
one corresponding to the current specifier.
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
stdio-common/printf-prs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: > 'this' can be understood as the current parameter, but in this case it > is meaning the other one, the one holding the width/precission. > > 'it' better describes that parameter, differentiating it from the > one corresponding to the current specifier. > > Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> We don't use SCO, but rather Copyright assignment. The rest looks good to me (although I am not a native speaker). Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > stdio-common/printf-prs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c > index 1d4e00553d..8ebf09a0a9 100644 > --- a/stdio-common/printf-prs.c > +++ b/stdio-common/printf-prs.c > @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) > /* Parse this spec. */ > nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); > > - /* If the width is determined by an argument this is an int. */ > + /* If the width is determined by an argument, it is an int. */ > if (spec.width_arg != -1 && (size_t) spec.width_arg < n) > argtypes[spec.width_arg] = PA_INT; > > - /* If the precision is determined by an argument this is an int. */ > + /* If the precision is determined by an argument, it is an int. */ > if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) > argtypes[spec.prec_arg] = PA_INT; > >
On 3/29/21 11:04 PM, Adhemerval Zanella wrote: > > > On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: >> 'this' can be understood as the current parameter, but in this case it >> is meaning the other one, the one holding the width/precission. >> >> 'it' better describes that parameter, differentiating it from the >> one corresponding to the current specifier. >> >> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> > > We don't use SCO, but rather Copyright assignment. The rest looks good > to me (although I am not a native speaker). I hope you don't need a copyright assignment for such a small change :). I guess a simple statement in this email that you can do as you wish with this patch should be enough. Anyway, I hereby assign copyright of this patch to the glibc copyright holder(s). Cheers, Alex > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > >> --- >> stdio-common/printf-prs.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c >> index 1d4e00553d..8ebf09a0a9 100644 >> --- a/stdio-common/printf-prs.c >> +++ b/stdio-common/printf-prs.c >> @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) >> /* Parse this spec. */ >> nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); >> >> - /* If the width is determined by an argument this is an int. */ >> + /* If the width is determined by an argument, it is an int. */ >> if (spec.width_arg != -1 && (size_t) spec.width_arg < n) >> argtypes[spec.width_arg] = PA_INT; >> >> - /* If the precision is determined by an argument this is an int. */ >> + /* If the precision is determined by an argument, it is an int. */ >> if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) >> argtypes[spec.prec_arg] = PA_INT; >> >>
On 29/03/2021 18:53, Alejandro Colomar (man-pages) wrote: > > > On 3/29/21 11:04 PM, Adhemerval Zanella wrote: >> >> >> On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: >>> 'this' can be understood as the current parameter, but in this case it >>> is meaning the other one, the one holding the width/precission. >>> >>> 'it' better describes that parameter, differentiating it from the >>> one corresponding to the current specifier. >>> >>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> >> >> We don't use SCO, but rather Copyright assignment. The rest looks good >> to me (although I am not a native speaker). > > I hope you don't need a copyright assignment for such a small change :). > I guess a simple statement in this email that you can do as you wish > with this patch should be enough. I don't think it would require for such changes, it is more a warning that we do use 'Signed-off-by:' in the patch submission. > > Anyway, I hereby assign copyright of this patch to the glibc copyright > holder(s). This change is simple and fits in the trivial one, I will push it for you. > > Cheers, > > Alex > > > >> >> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> >> >>> --- >>> stdio-common/printf-prs.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c >>> index 1d4e00553d..8ebf09a0a9 100644 >>> --- a/stdio-common/printf-prs.c >>> +++ b/stdio-common/printf-prs.c >>> @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) >>> /* Parse this spec. */ >>> nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); >>> >>> - /* If the width is determined by an argument this is an int. */ >>> + /* If the width is determined by an argument, it is an int. */ >>> if (spec.width_arg != -1 && (size_t) spec.width_arg < n) >>> argtypes[spec.width_arg] = PA_INT; >>> >>> - /* If the precision is determined by an argument this is an int. */ >>> + /* If the precision is determined by an argument, it is an int. */ >>> if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) >>> argtypes[spec.prec_arg] = PA_INT; >>> >>> >
diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c index 1d4e00553d..8ebf09a0a9 100644 --- a/stdio-common/printf-prs.c +++ b/stdio-common/printf-prs.c @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) /* Parse this spec. */ nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); - /* If the width is determined by an argument this is an int. */ + /* If the width is determined by an argument, it is an int. */ if (spec.width_arg != -1 && (size_t) spec.width_arg < n) argtypes[spec.width_arg] = PA_INT; - /* If the precision is determined by an argument this is an int. */ + /* If the precision is determined by an argument, it is an int. */ if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) argtypes[spec.prec_arg] = PA_INT;