From patchwork Thu Mar 11 19:52:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 42463 X-Patchwork-Delegate: fweimer@redhat.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E851D3894C2E; Thu, 11 Mar 2021 19:52:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E851D3894C2E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1615492344; bh=x0FndJxEf2eWxxyEy3sLE4qCjSX7tTDC+DIULZqui4A=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Aqu/Vibn3Ajp/5bR08h5HRkGO/H219cgh0NQStRZVkxWzqT8lRrBkkOw4EnYdEPHr f0DDLffqS/PjYEb7v0ED5+CZecBEQqI4gwLhPXROl/23LkbNZ4dlFh899NOG+JXXoE yTVc2mcSaEDMlsKI+x4vfsMpE+4+NhfcIDBIDztw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id 3F6573893646 for ; Thu, 11 Mar 2021 19:52:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3F6573893646 Received: by mail-qk1-x72d.google.com with SMTP id a9so21909813qkn.13 for ; Thu, 11 Mar 2021 11:52:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x0FndJxEf2eWxxyEy3sLE4qCjSX7tTDC+DIULZqui4A=; b=AUdWD7d7rMA8+YwAy4j76bVLvn54PlyO2gxq1H5R57Oxt5uv+LyyZ9gKXqY6V60kic 58CQgHIKskNw9YqSDRkNCKzOYA+UY2aUrikgiEV7Jo5X2hWc5GmCH7YMnpXpQFEQUEjE m0Y+44t5YnRbyLJ6STrRRKEx7PZnZ561ALQQzj4+CZ33mGmhxb6VH7JZuyvjSavT+Gus L4xbqE1w8Zksj+OQBU3O+pxYsLB8GHpWqr5ErfZ4vL0E5wG+UHE518ZmdeSbh31ad+Hu WLNnq9f7c7LY1aBYtjcYkkGZHHveQusIYDHYOjaj1gDfsm1pRbmJ+zJuIagW1smkuTcL dqhQ== X-Gm-Message-State: AOAM531xhatyUo99nHUwIiKwkBJUlOB6blTSZTUAi1lT9cagHwW8TV7U qYb4pRsnfKE2QxLm7794lEr7lksJgUvvb1cC X-Google-Smtp-Source: ABdhPJxbg1CbjYVeCNuUk7OYSAhtBC3WwYVgOiOsUlX77UfX24kTAy4ERBK4t4Iqswm7I07EhRB7/g== X-Received: by 2002:a37:9f4e:: with SMTP id i75mr9397501qke.283.1615492339730; Thu, 11 Mar 2021 11:52:19 -0800 (PST) Received: from localhost.localdomain ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id b16sm2266976qtx.85.2021.03.11.11.52.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 11:52:19 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH v2 5/8] posix: Do not clobber errno by atfork handlers Date: Thu, 11 Mar 2021 16:52:07 -0300 Message-Id: <20210311195210.3153729-5-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210311195210.3153729-1-adhemerval.zanella@linaro.org> References: <20210311195210.3153729-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Changes from v1: * Move the errno set/restore to parent branch. --- Checked on x86_64-linux-gnu. --- posix/fork.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/posix/fork.c b/posix/fork.c index cc1bdc1232..a4fdd44e1e 100644 --- a/posix/fork.c +++ b/posix/fork.c @@ -68,7 +68,6 @@ __libc_fork (void) } pid_t pid = _Fork (); - if (pid == 0) { fork_system_setup (); @@ -99,6 +98,11 @@ __libc_fork (void) } else { + /* If _Fork failed, preserve its errno value. */ + int save_errno; + if (pid < 0) + save_errno = errno; + /* Release acquired locks in the multi-threaded case. */ if (multiple_threads) { @@ -111,6 +115,9 @@ __libc_fork (void) /* Run the handlers registered for the parent. */ __run_fork_handlers (atfork_run_parent, multiple_threads); + + if (pid < 0) + __set_errno (save_errno); } return pid;