tst: Add test for settimeofday
Commit Message
This code brings test to check if time on target machine is properly set.
To avoid any issues with altering the time:
- The time, which was set before the test was executed is restored.
- The time is altered only when cross-test-ssh.sh is executed with
--allow-time-setting flag
---
time/Makefile | 2 +-
time/tst-settimeofday.c | 52 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 53 insertions(+), 1 deletion(-)
create mode 100644 time/tst-settimeofday.c
Comments
On 07/03/2021 09:59, Lukasz Majewski wrote:
> This code brings test to check if time on target machine is properly set.
> To avoid any issues with altering the time:
>
> - The time, which was set before the test was executed is restored.
>
> - The time is altered only when cross-test-ssh.sh is executed with
> --allow-time-setting flag
Ok with the changes below.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> time/Makefile | 2 +-
> time/tst-settimeofday.c | 52 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 53 insertions(+), 1 deletion(-)
> create mode 100644 time/tst-settimeofday.c
>
> diff --git a/time/Makefile b/time/Makefile
> index 414721ecc5..acfd08ef36 100644
> --- a/time/Makefile
> +++ b/time/Makefile
> @@ -49,7 +49,7 @@ tests := test_time clocktest tst-posixtz tst-strptime tst_wcsftime \
> tst-tzname tst-y2039 bug-mktime4 tst-strftime2 tst-strftime3 \
> tst-clock tst-clock2 tst-clock_nanosleep tst-cpuclock1 \
> tst-adjtime tst-ctime tst-difftime tst-mktime4 tst-clock_settime \
> - tst-itimer tst-gmtime tst-timegm tst-timespec_get
> + tst-itimer tst-gmtime tst-timegm tst-timespec_get tst-settimeofday
>
> tests-time64 := \
> tst-adjtime-time64 \
Ok.
> diff --git a/time/tst-settimeofday.c b/time/tst-settimeofday.c
> new file mode 100644
> index 0000000000..6d0f936a15
> --- /dev/null
> +++ b/time/tst-settimeofday.c
> @@ -0,0 +1,52 @@
> +/* Test for settimeofday
> + Copyright (C) 2021 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#include <time.h>
> +#include <stdlib.h>
> +#include <sys/time.h>
> +#include <support/check.h>
> +#include <support/xtime.h>
> +
> +#define TIMESPEC_SEC_Y2038_OV 0x7FFFFFFF
> +#define FUTURE_TIME (TIMESPEC_SEC_Y2038_OV - 10)
> +
> +static int
> +do_test (void)
> +{
> + const struct timeval tv = { FUTURE_TIME, 0};
> + struct timespec tv_future, tv_now;
> +
> + /* Check if altering target time is allowed. */
> + if (getenv (SETTIME_ENV_NAME) == NULL)
> + FAIL_UNSUPPORTED ("settimeofday is executed only when "\
> + SETTIME_ENV_NAME" is set\n");
> +
> + tv_now = xclock_now(CLOCK_REALTIME);
> + settimeofday(&tv, NULL);
> + tv_future = xclock_now(CLOCK_REALTIME);
Missing space after '(' and check settimeofday return value.
> +
> + /* Restore old time value on target machine. */
> + xclock_settime(CLOCK_REALTIME, (const struct timespec*) &tv_now);
Missing space after '('.
> +
> + if (tv_future.tv_sec < tv.tv_sec)
> + FAIL_EXIT1 ("settimeofday set wrong time!\n");
> +
> + return 0;
> +}
> +
> +#include <support/test-driver.c>
>
@@ -49,7 +49,7 @@ tests := test_time clocktest tst-posixtz tst-strptime tst_wcsftime \
tst-tzname tst-y2039 bug-mktime4 tst-strftime2 tst-strftime3 \
tst-clock tst-clock2 tst-clock_nanosleep tst-cpuclock1 \
tst-adjtime tst-ctime tst-difftime tst-mktime4 tst-clock_settime \
- tst-itimer tst-gmtime tst-timegm tst-timespec_get
+ tst-itimer tst-gmtime tst-timegm tst-timespec_get tst-settimeofday
tests-time64 := \
tst-adjtime-time64 \
new file mode 100644
@@ -0,0 +1,52 @@
+/* Test for settimeofday
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <time.h>
+#include <stdlib.h>
+#include <sys/time.h>
+#include <support/check.h>
+#include <support/xtime.h>
+
+#define TIMESPEC_SEC_Y2038_OV 0x7FFFFFFF
+#define FUTURE_TIME (TIMESPEC_SEC_Y2038_OV - 10)
+
+static int
+do_test (void)
+{
+ const struct timeval tv = { FUTURE_TIME, 0};
+ struct timespec tv_future, tv_now;
+
+ /* Check if altering target time is allowed. */
+ if (getenv (SETTIME_ENV_NAME) == NULL)
+ FAIL_UNSUPPORTED ("settimeofday is executed only when "\
+ SETTIME_ENV_NAME" is set\n");
+
+ tv_now = xclock_now(CLOCK_REALTIME);
+ settimeofday(&tv, NULL);
+ tv_future = xclock_now(CLOCK_REALTIME);
+
+ /* Restore old time value on target machine. */
+ xclock_settime(CLOCK_REALTIME, (const struct timespec*) &tv_now);
+
+ if (tv_future.tv_sec < tv.tv_sec)
+ FAIL_EXIT1 ("settimeofday set wrong time!\n");
+
+ return 0;
+}
+
+#include <support/test-driver.c>