From patchwork Mon Jan 25 13:03:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Majewski X-Patchwork-Id: 41813 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C082D39C0757; Mon, 25 Jan 2021 13:03:28 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 6B4303951CBD for ; Mon, 25 Jan 2021 13:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6B4303951CBD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DPVRJ3FNNz1qw9L; Mon, 25 Jan 2021 14:03:24 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DPVRJ28VDz1s8Tc; Mon, 25 Jan 2021 14:03:24 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id va5PlCfDAwie; Mon, 25 Jan 2021 14:03:22 +0100 (CET) X-Auth-Info: pSSxLR84EedN7L3JTnx1QVmHhJfBTB1O0JxoqbR4jH0= Received: from localhost.localdomain (89-64-25-12.dynamic.chello.pl [89.64.25.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 25 Jan 2021 14:03:21 +0100 (CET) From: Lukasz Majewski To: Joseph Myers , Adhemerval Zanella , Florian Weimer Subject: [PATCH] tst: Provide Y2038 tests for mktime (tst-mktime4.c) Date: Mon, 25 Jan 2021 14:03:08 +0100 Message-Id: <20210125130308.32242-1-lukma@denx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: GNU C Library , Florian Weimer , Alistair Francis Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" This change adds new test to assess mktime's functionality. To be more specific - following use cases are checked: - Pass struct tm as epoch time - Pass struct tm as value just before Y2038 threshold (returned value shall be 0x7FFFFFFF) - Pass struct tm as the first value after Y2038 threshold (expected value - 0x80000000) --- time/Makefile | 2 +- time/tst-mktime4.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 83 insertions(+), 1 deletion(-) create mode 100644 time/tst-mktime4.c diff --git a/time/Makefile b/time/Makefile index 7de2ce0196..f214d001f5 100644 --- a/time/Makefile +++ b/time/Makefile @@ -51,7 +51,7 @@ tests := test_time clocktest tst-posixtz tst-strptime tst_wcsftime \ tst-clock tst-clock2 tst-clock_nanosleep tst-cpuclock1 \ tst-adjtime tst-clock-y2038 tst-clock2-y2038 \ tst-cpuclock1-y2038 tst-clock_nanosleep-y2038 tst-clock_settime \ - tst-clock_adjtime tst-ctime tst-difftime + tst-clock_adjtime tst-ctime tst-difftime tst-mktime4 include ../Rules diff --git a/time/tst-mktime4.c b/time/tst-mktime4.c new file mode 100644 index 0000000000..468ca24174 --- /dev/null +++ b/time/tst-mktime4.c @@ -0,0 +1,82 @@ +/* Test for mktime + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include + +struct tm tm0 = { + .tm_year = 70, + .tm_mon = 0, + .tm_mday = 1, + .tm_hour = 0, + .tm_min = 0, + .tm_sec = 0, + .tm_wday = 4, + .tm_yday = 0 +}; + +struct tm tmY2038 = { + .tm_year = 138, + .tm_mon = 0, + .tm_mday = 19, + .tm_hour = 3, + .tm_min = 14, + .tm_sec = 7, + .tm_wday = 2, + .tm_yday = 18 +}; + +static +void test_mktime_helper (struct tm *tm, time_t exp_val) +{ + time_t result = mktime (tm); + if (result == -1) + FAIL_EXIT1 ("*** mktime failed: %m"); + + if (result != exp_val) + FAIL_EXIT1 ("*** mktime returned %ld (expected %ld)\n", result, exp_val); +} + +static int +do_test (void) +{ + /* Set time zone for the test. */ + TEST_VERIFY_EXIT (setenv ("TZ", "Europe/Warsaw", 1) == 0); + tzset (); + + /* Check that mktime(1970-01-01 00:00:00) returns 0. */ + test_mktime_helper (&tm0, 0); + + /* Check that mktime(2038-01-19 03:14:07) returns 0x7FFFFFFF. */ + test_mktime_helper (&tmY2038, 0x7fffffff); + + /* Check that mktime(2038-01-19 03:14:08) returns 0x80000000 + (time_t overflow). */ + if (sizeof (time_t) > 4) + { + tmY2038.tm_sec++; + test_mktime_helper (&tmY2038, 0x80000000); + } + else + FAIL_UNSUPPORTED ("32-bit time_t"); + + return 0; +} + +#include