Add xfchmod to libsupport

Message ID 20210109193125.361115-1-ahajkova@redhat.com
State Committed
Headers
Series Add xfchmod to libsupport |

Commit Message

Alexandra Hájková Jan. 9, 2021, 7:31 p.m. UTC
  From: Alexandra Hájková <ahajkova@redhat.com>

---
 support/Makefile  |  1 +
 support/xfchmod.c | 28 ++++++++++++++++++++++++++++
 support/xunistd.h |  1 +
 3 files changed, 30 insertions(+)
 create mode 100644 support/xfchmod.c
  

Comments

Florian Weimer Jan. 9, 2021, 9:25 p.m. UTC | #1
* Alexandra Hájková via Libc-alpha:

> diff --git a/support/Makefile b/support/Makefile
> index f4d157dded..fce5c9cd4a 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -97,6 +97,7 @@ libsupport-routines = \
>    xdlmopen \
>    xdup2 \
>    xfclose \
> +  xfchmod \
>    xfopen \
>    xfork \
>    xftruncate \

Please keep the list in ASCII order.  Otherwise, this version looks
fine to me, you should push it after sapping xfchmod and xfclose.
  

Patch

diff --git a/support/Makefile b/support/Makefile
index f4d157dded..fce5c9cd4a 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -97,6 +97,7 @@  libsupport-routines = \
   xdlmopen \
   xdup2 \
   xfclose \
+  xfchmod \
   xfopen \
   xfork \
   xftruncate \
diff --git a/support/xfchmod.c b/support/xfchmod.c
new file mode 100644
index 0000000000..4323b9ca8e
--- /dev/null
+++ b/support/xfchmod.c
@@ -0,0 +1,28 @@ 
+/* fchmod with error checking.
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <sys/stat.h>
+
+void
+xfchmod (int fd, mode_t mode)
+{
+  if (fchmod (fd, mode) != 0)
+    FAIL_EXIT1 ("fchmod (%d, 0%o): %m", fd, mode);
+}
diff --git a/support/xunistd.h b/support/xunistd.h
index 12a5ab677c..eb1b5519ff 100644
--- a/support/xunistd.h
+++ b/support/xunistd.h
@@ -46,6 +46,7 @@  long long xlseek (int fd, long long offset, int whence);
 void xftruncate (int fd, long long length);
 void xsymlink (const char *target, const char *linkpath);
 void xchdir (const char *path);
+void xfchmod (int fd, mode_t mode);
 
 /* Equivalent of "mkdir -p".  */
 void xmkdirp (const char *, mode_t);