From patchwork Mon Nov 9 20:18:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 40991 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FA9C397306E; Mon, 9 Nov 2020 20:18:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FA9C397306E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1604953134; bh=2yrHsqcnbEmYuRbPAqq3fhCvCQJziXzUsqZQzZWq6wQ=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Vc6lNwHxCpV1pqCh+TYrtoawNNLe9cYN7epqyZHhiZIeqwlyhxHAuLkDgLTd+AUmT WX0f1LzGwVtjMkuYtQLFnnvq0rL4KV4fGMOO5EsiQ1mKdU/2I9oRyKxIN1kM1gVSbL ItxO9KF1xBS6bmeXRlnirjYyMTBjklHDvVIC75LY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id E64E33896C3F for ; Mon, 9 Nov 2020 20:18:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E64E33896C3F Received: by mail-qk1-x742.google.com with SMTP id d9so2167631qke.8 for ; Mon, 09 Nov 2020 12:18:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2yrHsqcnbEmYuRbPAqq3fhCvCQJziXzUsqZQzZWq6wQ=; b=cPndVuLgxJDZs5DJw5izp4wDkU3mAsxeABvDmJ7nZTGHuWPkqPhcSMvfYVZNbrrakw uf6HvXDyq3pkImNsKmlxcIZ9prCCNh8oE7NC6MNFa6Wef+5sZFWjClUzBINvlVjY06Wz FmT6afKSGTAt19M0UDvpFDrBzdwopknAuhL7rWX5v25x20DTHUDEFM6URC0MYS3JJh0E pnMWezoT4yGR6Xz+fvp00I0K2r+Q85Sdu9VgiHGkh3XpoMtfR8vlJTexWPnQBS6dNONE 6fP6CGHv/BR4IOo8f/+cPTCsQf0VkwCW9lHMrw1rvEbbYnObiGd6sJA5synX3r5X93cM LI8A== X-Gm-Message-State: AOAM532J4j4VRdvTnBxyJNe/Y09NCw3lzp1zDJxmf8HXPsaY3fechdXn V5WWuHI2YVqULY4B8x7IuGB0Nsx/S+M6Jg== X-Google-Smtp-Source: ABdhPJxSjCg6n4Dm0mWsiqSWMbC2dTelXJo6BocgH7FuPTxM3u7apUz/FlVmCDUFynhd0cqjG3qRXA== X-Received: by 2002:a37:68d5:: with SMTP id d204mr8923266qkc.198.1604953131306; Mon, 09 Nov 2020 12:18:51 -0800 (PST) Received: from localhost.localdomain ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id z2sm6843407qkl.22.2020.11.09.12.18.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 12:18:50 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH 11/23] linux: Use generic __syscall_error for hppa Date: Mon, 9 Nov 2020 17:18:14 -0300 Message-Id: <20201109201826.120534-12-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109201826.120534-1-adhemerval.zanella@linaro.org> References: <20201109201826.120534-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" HPPA issues inline error handling for auto-generated syscall, the __syscall_error is used solely on clone implementation and it differs from generic implementation by passing positive errno numbers. Also, inline error handling does not really produce the most compat code. --- sizes-hppa-linux-gnu.outline +++ sizes-hppa-linux-gnu.inline text data bss dec hex filename -1576515 22028 9424 1607967 18891f libc.so - 174755 15524 448 190727 2e907 elf/ld.so - 132799 1296 8364 142459 22c7b nptl/libpthread.so - 30993 788 236 32017 7d11 rt/librt.so +1579367 22028 9424 1610819 189443 libc.so + 174835 15524 448 190807 2e957 elf/ld.so + 133055 1296 8364 142715 22d7b nptl/libpthread.so + 31297 788 236 32321 7e41 rt/librt.so Checked on hppa-linux-gnu. --- sysdeps/unix/sysv/linux/hppa/clone.S | 6 ++++-- sysdeps/unix/sysv/linux/hppa/sysdep.c | 27 --------------------------- sysdeps/unix/sysv/linux/hppa/sysdep.h | 2 ++ 3 files changed, 6 insertions(+), 29 deletions(-) delete mode 100644 sysdeps/unix/sysv/linux/hppa/sysdep.c diff --git a/sysdeps/unix/sysv/linux/hppa/clone.S b/sysdeps/unix/sysv/linux/hppa/clone.S index 4eda812dd0..fcfafe1d2b 100644 --- a/sysdeps/unix/sysv/linux/hppa/clone.S +++ b/sysdeps/unix/sysv/linux/hppa/clone.S @@ -124,7 +124,8 @@ ENTRY(__clone) .LerrorRest: /* Something bad happened -- no child created */ bl __syscall_error, %rp - sub %r0, %ret0, %arg0 + copy %ret0, %arg0 + ldw -84(%sp), %rp /* Return after setting errno, ret0 is set to -1 by __syscall_error. */ bv %r0(%rp) @@ -133,7 +134,8 @@ ENTRY(__clone) .LerrorSanity: /* Sanity checks failed, return -1, and set errno to EINVAL. */ bl __syscall_error, %rp - ldi EINVAL, %arg0 + ldi -EINVAL, %arg0 + ldw -84(%sp), %rp bv %r0(%rp) ldwm -64(%sp), %r4 diff --git a/sysdeps/unix/sysv/linux/hppa/sysdep.c b/sysdeps/unix/sysv/linux/hppa/sysdep.c deleted file mode 100644 index 8c06b6fc80..0000000000 --- a/sysdeps/unix/sysv/linux/hppa/sysdep.c +++ /dev/null @@ -1,27 +0,0 @@ -/* Copyright (C) 1997-2020 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - . */ - -#include - -/* This routine is jumped to by all the syscall handlers, to stash - an error number into errno. */ -int -__syscall_error (int err_no) -{ - __set_errno (err_no); - return -1; -} diff --git a/sysdeps/unix/sysv/linux/hppa/sysdep.h b/sysdeps/unix/sysv/linux/hppa/sysdep.h index 531fe2beed..a1165da81e 100644 --- a/sysdeps/unix/sysv/linux/hppa/sysdep.h +++ b/sysdeps/unix/sysv/linux/hppa/sysdep.h @@ -21,6 +21,8 @@ #ifndef _LINUX_HPPA_SYSDEP_H #define _LINUX_HPPA_SYSDEP_H 1 +#define SYSCALL_ERROR_FUNC + #include #include #include