Message ID | 20201014122414.66000-1-colomar.6.4.3@gmail.com |
---|---|
State | Not applicable |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3FC903857C77; Wed, 14 Oct 2020 12:26:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FC903857C77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602678379; bh=sdfyI6skpsXnAp8d8fK5YPA9CAd16521QYARHh/QfLc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=pDbQvrpIr5XV5luxq7F6lU3zrFFTl/uAJO9/UXDoiN3THPHEXX7gu/8dKxnFuYKEP 8pgtE9+qqTWMjIzfBgUlGP98FRTeUeGskizaKSRbvRI5zTPswKrcPzek0ECfvN4XLP oBfFr9i2tLtDTZkaPh2b+82QnLWK3vR9y0kn6Cgk= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by sourceware.org (Postfix) with ESMTPS id BF5793857C4F for <libc-alpha@sourceware.org>; Wed, 14 Oct 2020 12:26:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF5793857C4F Received: by mail-wr1-x443.google.com with SMTP id g12so3589022wrp.10 for <libc-alpha@sourceware.org>; Wed, 14 Oct 2020 05:26:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sdfyI6skpsXnAp8d8fK5YPA9CAd16521QYARHh/QfLc=; b=gIUlLmNsMPCriCXgF7QrTCktygnS2Ca0Zh+k7goBEZD7vwt8Dkf1oJ2eJ8tVk0R99Q rmnEJvNnHV29pt9ZMPKjfxD5g+6Eu1WcJguLeBD3ID60/wRsYIPIUiIuM0YwI/JnaqXU 7brz6ndy4kOjxdXmHm1zYsBfDPhGiwPucxn4LS1PdTarmAsWbJufGPQamvkx27sgWw2R uQu2kTbivAHwcytCroHIc/YXurKqsILU6IaKw3YMa9sEb6i99TRr82ijOns0RFwUlhn0 wO4rTFXjNKLCKtfBu56wDCSllbENmCKMsRdfFx3lLoG9lBf9nJ7RF94iKiWGqMUq0XwX TZ5Q== X-Gm-Message-State: AOAM533iDrUL7MhJdz7zU2ggLGSNstZAwSC+ycQodAAHnXAMWG/e15ib O14TnhK1U8wmGOwa3SIhcW4= X-Google-Smtp-Source: ABdhPJzP28+lYa/36dymUYy2deCahshIx0EYfh25TdDzpem/45UMPrvxpo49GSmFJb2SH93edKmAVA== X-Received: by 2002:adf:f305:: with SMTP id i5mr5294582wro.346.1602678375866; Wed, 14 Oct 2020 05:26:15 -0700 (PDT) Received: from localhost.localdomain ([170.253.49.0]) by smtp.googlemail.com with ESMTPSA id 10sm3625151wmn.9.2020.10.14.05.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 05:26:14 -0700 (PDT) To: mtk.manpages@gmail.com Subject: [PATCH] regex.3: wfix Date: Wed, 14 Oct 2020 14:24:15 +0200 Message-Id: <20201014122414.66000-1-colomar.6.4.3@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Alejandro Colomar via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alejandro Colomar <colomar.6.4.3@gmail.com> Cc: Alejandro Colomar <colomar.6.4.3@gmail.com>, linux-man@vger.kernel.org, libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
regex.3: wfix
|
|
Commit Message
Alejandro Colomar
Oct. 14, 2020, 12:24 p.m. UTC
The wording was incorrect:
It stated that 'eflags' may be the OR of one or two of those two flags,
but then a third flag was documented
(which according to the previous wording could not be used?!).
Moreover, the wording also disallowed using 0 (i.e., no flags at all),
which POSIX specifically allows;
I tested the function with no flags and it worked fine for me,
so I guess it was a problem with the documentation,
and not with the implementation itself.
POSIX ref: https://pubs.opengroup.org/onlinepubs/9699919799/
Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
---
Hi Michael,
I was working with the example, and the documentation was a bit weird,
so I want to be sure I'm doing it right before sending you the example.
Please review that this patch is correct, which I guess it is.
Cheers,
Alex
man3/regex.3 | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
Comments
On 10/14/20 2:24 PM, Alejandro Colomar wrote: > The wording was incorrect: > > It stated that 'eflags' may be the OR of one or two of those two flags, > but then a third flag was documented > (which according to the previous wording could not be used?!). > Moreover, the wording also disallowed using 0 (i.e., no flags at all), > which POSIX specifically allows; > I tested the function with no flags and it worked fine for me, > so I guess it was a problem with the documentation, > and not with the implementation itself. > > POSIX ref: https://pubs.opengroup.org/onlinepubs/9699919799/ > > Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com> > --- > > Hi Michael, > > I was working with the example, and the documentation was a bit weird, > so I want to be sure I'm doing it right before sending you the example. > Please review that this patch is correct, which I guess it is. Hi Alex, I'm sure your fix is correct. The wording "It *may* be..." was I think intended to imply that instead of a mask of one or more of those bits, it could be zero. But that's an imprecise way of saying what is better said by your patch. I've applied the patch. Thanks, Michael > man3/regex.3 | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/man3/regex.3 b/man3/regex.3 > index d4f7a09e7..a7e04f7b5 100644 > --- a/man3/regex.3 > +++ b/man3/regex.3 > @@ -136,11 +136,7 @@ are used to provide information regarding the location of any matches. > .I eflags > may be the > .RB bitwise- or > -of one or both of > -.B REG_NOTBOL > -and > -.B REG_NOTEOL > -which cause changes in matching behavior described below. > +of zero or more of the following flags: > .TP > .B REG_NOTBOL > The match-beginning-of-line operator always fails to match (but see the >
diff --git a/man3/regex.3 b/man3/regex.3 index d4f7a09e7..a7e04f7b5 100644 --- a/man3/regex.3 +++ b/man3/regex.3 @@ -136,11 +136,7 @@ are used to provide information regarding the location of any matches. .I eflags may be the .RB bitwise- or -of one or both of -.B REG_NOTBOL -and -.B REG_NOTEOL -which cause changes in matching behavior described below. +of zero or more of the following flags: .TP .B REG_NOTBOL The match-beginning-of-line operator always fails to match (but see the