diff mbox series

[hurd,commited] hurd: Implement basic sched_get/setscheduler

Message ID 20200805214736.386404-1-samuel.thibault@ens-lyon.org
State Committed, archived
Headers
Series [hurd,commited] hurd: Implement basic sched_get/setscheduler |

Commit Message

Samuel Thibault Aug. 5, 2020, 9:47 p.m. UTC 
  * sysdeps/mach/hurd/sched_gets.c: New file.
* sysdeps/mach/hurd/sched_sets.c: New file.
---
 sysdeps/mach/hurd/sched_gets.c | 30 +++++++++++++++++++++++
 sysdeps/mach/hurd/sched_sets.c | 45 ++++++++++++++++++++++++++++++++++
 2 files changed, 75 insertions(+)
 create mode 100644 sysdeps/mach/hurd/sched_gets.c
 create mode 100644 sysdeps/mach/hurd/sched_sets.c

Comments

Joseph Myers Aug. 6, 2020, 6:01 p.m. UTC | #1 
On Wed, 5 Aug 2020, Samuel Thibault wrote:

> +/* Retrieve scheduling algorithm for a particular purpose.  */
> +int
> +__sched_getscheduler (pid_t pid)
> +{
> +  return SCHED_OTHER;
> +}
> +weak_alias (__sched_getscheduler, sched_getscheduler)

I'm seeing build failures:

../sysdeps/mach/hurd/sched_gets.c:30:35: error: 'sched_getscheduler' aliased to undefined symbol '__sched_getscheduler'

Missing libc_hidden_def, since there is libc_hidden_proto 
(__sched_getscheduler) in include/sched.h?
Samuel Thibault Aug. 6, 2020, 6:16 p.m. UTC | #2 
Joseph Myers, le jeu. 06 août 2020 18:01:44 +0000, a ecrit:
> On Wed, 5 Aug 2020, Samuel Thibault wrote:
> 
> > +/* Retrieve scheduling algorithm for a particular purpose.  */
> > +int
> > +__sched_getscheduler (pid_t pid)
> > +{
> > +  return SCHED_OTHER;
> > +}
> > +weak_alias (__sched_getscheduler, sched_getscheduler)
> 
> I'm seeing build failures:
> 
> ../sysdeps/mach/hurd/sched_gets.c:30:35: error: 'sched_getscheduler' aliased to undefined symbol '__sched_getscheduler'
> 
> Missing libc_hidden_def, since there is libc_hidden_proto 
> (__sched_getscheduler) in include/sched.h?

Oh, sorry, there was indeed a difference there between my previous test
build tree and the current master. Pushed the fix.

Thanks,
Samuel
diff mbox series

Patch

diff --git a/sysdeps/mach/hurd/sched_gets.c b/sysdeps/mach/hurd/sched_gets.c
new file mode 100644
index 0000000000..9fe31ce79e
--- /dev/null
+++ b/sysdeps/mach/hurd/sched_gets.c
@@ -0,0 +1,30 @@ 
+/* Copyright (C) 2020 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <errno.h>
+#include <sched.h>
+#include <sys/types.h>
+#include <hurd.h>
+
+
+/* Retrieve scheduling algorithm for a particular purpose.  */
+int
+__sched_getscheduler (pid_t pid)
+{
+  return SCHED_OTHER;
+}
+weak_alias (__sched_getscheduler, sched_getscheduler)
diff --git a/sysdeps/mach/hurd/sched_sets.c b/sysdeps/mach/hurd/sched_sets.c
new file mode 100644
index 0000000000..54d368abf5
--- /dev/null
+++ b/sysdeps/mach/hurd/sched_sets.c
@@ -0,0 +1,45 @@ 
+/* Copyright (C) 1996-2020 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <errno.h>
+#include <sched.h>
+#include <sys/types.h>
+#include <hurd.h>
+
+
+/* Set scheduling algorithm and/or parameters for a process.  */
+int
+__sched_setscheduler (pid_t pid, int policy, const struct sched_param *param)
+{
+  switch (policy)
+    {
+    case SCHED_OTHER:
+      if (param->sched_priority != 0)
+	return __hurd_fail (EINVAL);
+      break;
+
+    case SCHED_FIFO:
+    case SCHED_RR:
+      return __hurd_fail (ENOTSUP);
+
+    default:
+      return EINVAL;
+    }
+  return 0;
+}
+libc_hidden_def (__sched_setscheduler)
+weak_alias (__sched_setscheduler, sched_setscheduler)