diff mbox series

[04/12] aarch64: Rename place holder .S files to .c

Message ID 20200430174032.GZ29015@arm.com
State Superseded
Headers show
Series aarch64: branch protection support | expand

Commit Message

Szabolcs Nagy April 30, 2020, 5:40 p.m. UTC

Comments

Adhemerval Zanella May 7, 2020, 6:29 p.m. UTC | #1
On 30/04/2020 14:40, Szabolcs Nagy wrote:
> From 2084e33755ee4d00b3ecf956b1705d8eea46ebc7 Mon Sep 17 00:00:00 2001
> From: Szabolcs Nagy <szabolcs.nagy@arm.com>
> Date: Wed, 1 Apr 2020 09:52:37 +0100
> Subject: [PATCH 04/12] aarch64: Rename place holder .S files to .c
> 
> The compiler can add required elf markings based on CFLAGS
> but the assembler cannot, so using C code for empty files
> creates less of a maintenance problem.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  sysdeps/aarch64/{bsd-_setjmp.S => bsd-_setjmp.c} | 0
>  sysdeps/aarch64/{bsd-setjmp.S => bsd-setjmp.c}   | 0
>  sysdeps/aarch64/{memmove.S => memmove.c}         | 0
>  3 files changed, 0 insertions(+), 0 deletions(-)
>  rename sysdeps/aarch64/{bsd-_setjmp.S => bsd-_setjmp.c} (100%)
>  rename sysdeps/aarch64/{bsd-setjmp.S => bsd-setjmp.c} (100%)
>  rename sysdeps/aarch64/{memmove.S => memmove.c} (100%)
> 
> diff --git a/sysdeps/aarch64/bsd-_setjmp.S b/sysdeps/aarch64/bsd-_setjmp.c
> similarity index 100%
> rename from sysdeps/aarch64/bsd-_setjmp.S
> rename to sysdeps/aarch64/bsd-_setjmp.c
> diff --git a/sysdeps/aarch64/bsd-setjmp.S b/sysdeps/aarch64/bsd-setjmp.c
> similarity index 100%
> rename from sysdeps/aarch64/bsd-setjmp.S
> rename to sysdeps/aarch64/bsd-setjmp.c
> diff --git a/sysdeps/aarch64/memmove.S b/sysdeps/aarch64/memmove.c
> similarity index 100%
> rename from sysdeps/aarch64/memmove.S
> rename to sysdeps/aarch64/memmove.c
> -- 
> 2.17.1
diff mbox series

Patch

From 2084e33755ee4d00b3ecf956b1705d8eea46ebc7 Mon Sep 17 00:00:00 2001
From: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date: Wed, 1 Apr 2020 09:52:37 +0100
Subject: [PATCH 04/12] aarch64: Rename place holder .S files to .c

The compiler can add required elf markings based on CFLAGS
but the assembler cannot, so using C code for empty files
creates less of a maintenance problem.
---
 sysdeps/aarch64/{bsd-_setjmp.S => bsd-_setjmp.c} | 0
 sysdeps/aarch64/{bsd-setjmp.S => bsd-setjmp.c}   | 0
 sysdeps/aarch64/{memmove.S => memmove.c}         | 0
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename sysdeps/aarch64/{bsd-_setjmp.S => bsd-_setjmp.c} (100%)
 rename sysdeps/aarch64/{bsd-setjmp.S => bsd-setjmp.c} (100%)
 rename sysdeps/aarch64/{memmove.S => memmove.c} (100%)

diff --git a/sysdeps/aarch64/bsd-_setjmp.S b/sysdeps/aarch64/bsd-_setjmp.c
similarity index 100%
rename from sysdeps/aarch64/bsd-_setjmp.S
rename to sysdeps/aarch64/bsd-_setjmp.c
diff --git a/sysdeps/aarch64/bsd-setjmp.S b/sysdeps/aarch64/bsd-setjmp.c
similarity index 100%
rename from sysdeps/aarch64/bsd-setjmp.S
rename to sysdeps/aarch64/bsd-setjmp.c
diff --git a/sysdeps/aarch64/memmove.S b/sysdeps/aarch64/memmove.c
similarity index 100%
rename from sysdeps/aarch64/memmove.S
rename to sysdeps/aarch64/memmove.c
-- 
2.17.1