Message ID | 20200421114800.26450-1-chenzefeng2@huawei.com |
---|---|
State | Superseded |
Headers |
Return-Path: <chenzefeng2@huawei.com> X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by sourceware.org (Postfix) with ESMTPS id 2CA80384B0C1 for <libc-alpha@sourceware.org>; Tue, 21 Apr 2020 11:48:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2CA80384B0C1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=chenzefeng2@huawei.com Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id CC9161C6E0F8D79B58A1; Tue, 21 Apr 2020 19:48:08 +0800 (CST) Received: from linux_supse12sp4_workstation.huawei.com (10.67.189.177) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Tue, 21 Apr 2020 19:48:00 +0800 From: chenzefeng <chenzefeng2@huawei.com> To: <libc-alpha@sourceware.org>, <fw@deneb.enyo.de>, <dj@redhat.com>, <zackw@panix.com> CC: <liucheng32@huawei.com>, <chenzefeng2@huawei.com>, <zengweilin@huawei.com> Subject: [PATCH v3] malloc: fix memleak in function muntrace Date: Tue, 21 Apr 2020 19:48:00 +0800 Message-ID: <20200421114800.26450-1-chenzefeng2@huawei.com> X-Mailer: git-send-email 2.12.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.189.177] X-CFilter-Loop: Reflected X-Spam-Status: No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> X-List-Received-Date: Tue, 21 Apr 2020 11:48:13 -0000 |
Series |
[v3] malloc: fix memleak in function muntrace
|
|
Commit Message
chenzefeng
April 21, 2020, 11:48 a.m. UTC
when we call functons as follow:
mtrace();
...
muntrace();
It would cause memleak, for the mtrace malloc some memory:
mtd = malloc(TRACE_BUFFER_SIZE);
and it would not be free. Therefor it should be freed in muntrace.
Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
---
malloc/mtrace.c | 2 ++
1 file changed, 2 insertions(+)
Comments
* chenzefeng: > when we call functons as follow: > mtrace(); > ... > muntrace(); > It would cause memleak, for the mtrace malloc some memory: > mtd = malloc(TRACE_BUFFER_SIZE); > and it would not be free. Therefor it should be freed in muntrace. > > Signed-off-by: chenzefeng <chenzefeng2@huawei.com> Same question as before: glibc uses copyright assignment to the FSF for contributions, and not the DCO. I trust this contribution is covered by Huawei's copyright assignment? > --- > malloc/mtrace.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/malloc/mtrace.c b/malloc/mtrace.c > index 7e7719df97..5d7bc62857 100644 > --- a/malloc/mtrace.c > +++ b/malloc/mtrace.c > @@ -365,4 +365,6 @@ muntrace (void) > > fprintf (f, "= End\n"); > fclose (f); > + free (malloc_trace_buffer); > + malloc_trace_buffer == NULL; > } Please test your patches before you post them: mtrace.c: In function ‘muntrace’: mtrace.c:369:23: error: statement with no effect [-Werror=unused-value] malloc_trace_buffer == NULL; ^
* Florian Weimer: >* chenzefeng: >> when we call functons as follow: >> mtrace(); >> ... >> muntrace(); > >It would cause memleak, for the mtrace malloc some memory: >> mtd = malloc(TRACE_BUFFER_SIZE); > >and it would not be free. Therefor it should be freed in muntrace. >> > >Signed-off-by: chenzefeng <chenzefeng2@huawei.com> >Same question as before: >glibc uses copyright assignment to the FSF for contributions, and not the DCO. >I trust this contribution is covered by Huawei's copyright assignment? Yet, this patch uses copyright assignment to the FSF for contributions. >> --- >> malloc/mtrace.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/malloc/mtrace.c b/malloc/mtrace.c index >> 7e7719df97..5d7bc62857 100644 >> --- a/malloc/mtrace.c >> +++ b/malloc/mtrace.c >> @@ -365,4 +365,6 @@ muntrace (void) >> >> fprintf (f, "= End\n"); >> fclose (f); >>+ free (malloc_trace_buffer); >> + malloc_trace_buffer == NULL; >> } >Please test your patches before you post them: >mtrace.c: In function ‘muntrace’: >mtrace.c:369:23: error: statement with no effect [-Werror=unused-value] > malloc_trace_buffer == NULL; Fix it in patch v4 ^
diff --git a/malloc/mtrace.c b/malloc/mtrace.c index 7e7719df97..5d7bc62857 100644 --- a/malloc/mtrace.c +++ b/malloc/mtrace.c @@ -365,4 +365,6 @@ muntrace (void) fprintf (f, "= End\n"); fclose (f); + free (malloc_trace_buffer); + malloc_trace_buffer == NULL; }