From patchwork Tue Oct 8 20:43:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gabriel F. T. Gomes" X-Patchwork-Id: 34884 Received: (qmail 58691 invoked by alias); 8 Oct 2019 20:43:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 58666 invoked by uid 89); 8 Oct 2019 20:43:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*F:D*br X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Tue, 8 Oct 2019 17:43:05 -0300 From: "Gabriel F. T. Gomes" To: Florian Weimer CC: , , "Tulio Magno Quites Machado Filho" Subject: [PATCH v2] Make tst-strftime2 depend on locale generation Message-ID: <20191008174305.7763748d@tereshkova> In-Reply-To: <87lftvw12z.fsf@mid.deneb.enyo.de> References: <20191008174509.22788-1-gabriel@inconstante.net.br> <87lftvw12z.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 X-Ovh-Tracer-Id: 17647073665999490651 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrheelgdduheehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm On Tue, 08 Oct 2019, Florian Weimer wrote: > >Doesn't tst-strftime3 have the same problem? Looks good otherwise. On Tue, 08 Oct 2019, Tulio Magno Quites Machado Filho wrote: > >Likewise for tst-strftime3.out ? >I've never seen an error there, but the test does depend on locales too. Yes, you are right. I haven't noticed a problem because these test may get the locale from the system and the locale from the system I'm testing on was good/new enough for tst-strftime3 (but not for tst-strftime2). With the system locales deleted/inaccessible, both tests may fail before v1 of this patch. The following version solves the problem for both tst-strftime2 and tst-strftime3, as well as it adds a ChangeLog entry. Is the following patch OK for master? From 083391d58262b045f39c59253dfb3f60e80a4531 Mon Sep 17 00:00:00 2001 From: "Gabriel F. T. Gomes" Date: Tue, 8 Oct 2019 14:32:17 -0300 Subject: [PATCH v2] Make tst-strftime2 and tst-strftime3 depend on locale generation Building the test cases in parallel might make tst-strftime2 and tst-strftime3 fail. Simply re-running the test case (or building serially) makes the problem go away. This patch adds the necessary dependency to allow parallel builds in the time subdirectory. Tested for powerpc64le. * Makefile: Fix locale dependency for a couple of tests. ($(objpfx)tst-strftime2.out): New rule. ($(objpfx)tst-strftime3.out): Likewise. Reviewed-by: Florian Weimer Reviewed-by: Tulio Magno Quites Machado Filho --- time/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/time/Makefile b/time/Makefile index b9217992a6..ad8844ea34 100644 --- a/time/Makefile +++ b/time/Makefile @@ -61,6 +61,8 @@ include ../gen-locales.mk $(objpfx)tst-ftime_l.out: $(gen-locales) $(objpfx)tst-strptime.out: $(gen-locales) +$(objpfx)tst-strftime2.out: $(gen-locales) +$(objpfx)tst-strftime3.out: $(gen-locales) endif tz-cflags = -DTZDIR='"$(zonedir)"' \