From patchwork Fri Mar 8 20:44:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 31787 Received: (qmail 16590 invoked by alias); 8 Mar 2019 20:44:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 16580 invoked by uid 89); 8 Mar 2019 20:44:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Date: Fri, 08 Mar 2019 21:44:23 +0100 To: libc-alpha@sourceware.org Subject: [PATCH] nss_dns: Do not call res_dnok in getnetby* implementation User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Message-Id: <20190308204424.0744F80DD6B5@oldenburg2.str.redhat.com> From: Florian Weimer The argument to res_dnok was produced by ns_name_ntop, so it is a syntactically valid domain name which, in textual format, only consists of printable characters. Therefore, the res_dnok check always passes. 2019-03-08 Florian Weimer * resolv/nss_dns/dns-network.c (getanswer_r): Do not call res_dnok. Reviewed-by: Carlos O'Donell diff --git a/resolv/nss_dns/dns-network.c b/resolv/nss_dns/dns-network.c index 4b81b1bfdc..4617b165db 100644 --- a/resolv/nss_dns/dns-network.c +++ b/resolv/nss_dns/dns-network.c @@ -348,7 +348,7 @@ getanswer_r (const querybuf *answer, int anslen, struct netent *result, if (n > 0 && bp[0] == '.') bp[0] = '\0'; - if (n < 0 || res_dnok (bp) == 0) + if (n < 0) break; cp += n; @@ -382,7 +382,7 @@ getanswer_r (const querybuf *answer, int anslen, struct netent *result, n = -1; } - if (n < 0 || !res_hnok (bp)) + if (n < 0) { /* XXX What does this mean? The original form from bind returns NULL. Incrementing cp has no effect in any case.