[v2,1/3] benchtests: keep comparing even if function timings do not match
Commit Message
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Allows other functions to be processed, making the script a bit more fault
tolerant thus useful.
* benchtests/scripts/compare_bench.py (compare_runs): Continue instead of return.
---
benchtests/scripts/compare_bench.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 12/12/18 4:16 AM, leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> Allows other functions to be processed, making the script a bit more fault
> tolerant thus useful.
>
> * benchtests/scripts/compare_bench.py (compare_runs): Continue instead of return.
Looks OK.
Thanks,
Siddhesh
> ---
> benchtests/scripts/compare_bench.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py
> index f4b7742f90..9cbbda6be6 100755
> --- a/benchtests/scripts/compare_bench.py
> +++ b/benchtests/scripts/compare_bench.py
> @@ -77,7 +77,7 @@ def compare_runs(pts1, pts2, threshold):
> # timing info for the function variant.
> if 'timings' not in pts1['functions'][func][var].keys() or \
> 'timings' not in pts2['functions'][func][var].keys():
> - return
> + continue
>
> # If two lists do not have the same length then it is likely that
> # the performance characteristics of the function have changed.
>
@@ -77,7 +77,7 @@ def compare_runs(pts1, pts2, threshold):
# timing info for the function variant.
if 'timings' not in pts1['functions'][func][var].keys() or \
'timings' not in pts2['functions'][func][var].keys():
- return
+ continue
# If two lists do not have the same length then it is likely that
# the performance characteristics of the function have changed.