From patchwork Fri Aug 17 13:24:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 28949 Received: (qmail 10590 invoked by alias); 17 Aug 2018 13:24:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 10315 invoked by uid 89); 17 Aug 2018 13:24:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ordered X-HELO: mx1.redhat.com Date: Fri, 17 Aug 2018 15:24:01 +0200 To: libc-alpha@sourceware.org Subject: [PATCH] Makeconfig: Do not sort and deduplicate +cflags [BZ # 17248] User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Message-Id: <20180817132401.5523B404122B7@oldenburg.str.redhat.com> From: fweimer@redhat.com (Florian Weimer) The original intent behind this is unclear. It interferes with flags that has to be ordered in a particular way. This change does not introduce any changes in the built binaries on x86-64, and build-many-glibcs.py shows no regressions, either. (I did not compare all object files, though.) 2018-08-17 Florian Weimer [BZ #17248] * Makeconfig (+cflags): Do not sort (and deduplicate). Reviewed-by: Carlos O'Donell diff --git a/Makeconfig b/Makeconfig index 92e76d6200..a9e50e5b60 100644 --- a/Makeconfig +++ b/Makeconfig @@ -902,9 +902,6 @@ endif # $(+cflags) == "" $(+stack-protector) +gcc-nowarn := -w -# Don't duplicate options if we inherited variables from the parent. -+cflags := $(sort $(+cflags)) - # Each sysdeps directory can contain header files that both will be # used to compile and will be installed. Each can also contain an # include/ subdirectory, whose header files will be used to compile