| Message ID | 20171123000721.32623-1-victor.rodriguez.bahena@intel.com |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 23 November 2017 05:37 AM, Victor Rodriguez wrote: > Benchmark workload-spec2006.wrf does not produce max, min or mean > results but instead produce throughput. This is represented in > benchtests/bench-skeleton.c. This patch adjust benchout.schema.json to consider > bench.out from bench-math benchmarks as valid > > ChangeLog: > > * benchtests/scripts/benchout.schema.json: Add throughput as accepted > result from property and remove "max", min" and "mean" from required > properties based on benchtests/bench-skeleton.c. > > Signed-off-by: Victor Rodriguez <victor.rodriguez.bahena@intel.com> OK. Reviewed-By: Siddhesh Poyarekar <siddhesh@sourceware.org> > --- > ChangeLog | 6 ++++++ > benchtests/scripts/benchout.schema.json | 3 ++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/ChangeLog b/ChangeLog > index 73df200dbb..284bc87963 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,9 @@ > +2017-11-15 Victor Rodriguez <victor.rodriguez.bahena@intel.com> > + > + * benchtests/scripts/benchout.schema.json: Add throughput as accepted > + result from property and remove "max", min" and "mean" from required > + properties based on benchtests/bench-skeleton.c. > + > 2017-11-22 Victor Rodriguez <victor.rodriguez.bahena@intel.com> > > * benchtests/scripts/benchout.schema.json: Fix regex to accept a wider > diff --git a/benchtests/scripts/benchout.schema.json b/benchtests/scripts/benchout.schema.json > index 815ad9735a..0eca21b6bd 100644 > --- a/benchtests/scripts/benchout.schema.json > +++ b/benchtests/scripts/benchout.schema.json > @@ -19,6 +19,7 @@ > "properties": { > "duration": {"type": "number"}, > "iterations": {"type": "number"}, > + "throughput": {"type": "number"}, > "max": {"type": "number"}, > "min": {"type": "number"}, > "mean": {"type": "number"}, > @@ -27,7 +28,7 @@ > "items": {"type": "number"} > } > }, > - "required": ["duration", "iterations", "max", "min", "mean"], > + "required": ["duration", "iterations"], > "additionalProperties": false > } > }, >
diff --git a/ChangeLog b/ChangeLog index 73df200dbb..284bc87963 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2017-11-15 Victor Rodriguez <victor.rodriguez.bahena@intel.com> + + * benchtests/scripts/benchout.schema.json: Add throughput as accepted + result from property and remove "max", min" and "mean" from required + properties based on benchtests/bench-skeleton.c. + 2017-11-22 Victor Rodriguez <victor.rodriguez.bahena@intel.com> * benchtests/scripts/benchout.schema.json: Fix regex to accept a wider diff --git a/benchtests/scripts/benchout.schema.json b/benchtests/scripts/benchout.schema.json index 815ad9735a..0eca21b6bd 100644 --- a/benchtests/scripts/benchout.schema.json +++ b/benchtests/scripts/benchout.schema.json @@ -19,6 +19,7 @@ "properties": { "duration": {"type": "number"}, "iterations": {"type": "number"}, + "throughput": {"type": "number"}, "max": {"type": "number"}, "min": {"type": "number"}, "mean": {"type": "number"}, @@ -27,7 +28,7 @@ "items": {"type": "number"} } }, - "required": ["duration", "iterations", "max", "min", "mean"], + "required": ["duration", "iterations"], "additionalProperties": false } },
Benchmark workload-spec2006.wrf does not produce max, min or mean results but instead produce throughput. This is represented in benchtests/bench-skeleton.c. This patch adjust benchout.schema.json to consider bench.out from bench-math benchmarks as valid ChangeLog: * benchtests/scripts/benchout.schema.json: Add throughput as accepted result from property and remove "max", min" and "mean" from required properties based on benchtests/bench-skeleton.c. Signed-off-by: Victor Rodriguez <victor.rodriguez.bahena@intel.com> --- ChangeLog | 6 ++++++ benchtests/scripts/benchout.schema.json | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-)