From patchwork Wed Jun 7 11:50:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arjun Shankar X-Patchwork-Id: 20824 Received: (qmail 28611 invoked by alias); 7 Jun 2017 11:50:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 26656 invoked by uid 89); 7 Jun 2017 11:50:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS, T_RP_MATCHES_RCVD, URIBL_RED autolearn=ham version=3.3.2 spammy=Discussion X-HELO: aloka.lostca.se Date: Wed, 7 Jun 2017 11:50:39 +0000 From: Arjun Shankar To: libc-alpha@sourceware.org Cc: Joseph Myers , Florian Weimer Subject: [PING][PATCH v2] Remove check for NULL buffer passed to `ptsname_r' Message-ID: <20170607115039.GB65837@aloka.lostca.se> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) ----- Forwarded message from Arjun Shankar ----- Date: Mon, 29 May 2017 15:46:48 +0000 From: Arjun Shankar To: libc-alpha@sourceware.org Cc: Joseph Myers , Florian Weimer Subject: [PATCH v2] Remove check for NULL buffer passed to `ptsname_r' `ptsname_r' is declared in stdlib.h to only accept a `nonnull' second argument and therefore GCC may choose to make optimizations based on the assumption that this argument is NULL. This means that potentially, GCC can optimize away the NULL check at some point in the future. Since this is a programming interface, we might as well remove the NULL check ourselves. This also warrants a change to the `ptsname_r' manual page that must be submitted to the corresponding mailing list. In addition, remove the NULL buffer test in login/tst-ptsname.c. ChangeLog: 2017-05-29 Arjun Shankar * sysdeps/unix/sysv/linux/ptsname.c (__ptsname_internal): Remove check for NULL 'buf'. * login/tst-ptsname.c (do_test): Remove test with NULL 'buf'. --- Discussion on PATCH v1: https://sourceware.org/ml/libc-alpha/2017-05/msg00726.html login/tst-ptsname.c | 1 - sysdeps/unix/sysv/linux/ptsname.c | 6 ------ 2 files changed, 7 deletions(-) diff --git a/login/tst-ptsname.c b/login/tst-ptsname.c index be8744d..96f0449 100644 --- a/login/tst-ptsname.c +++ b/login/tst-ptsname.c @@ -70,7 +70,6 @@ do_test (void) if (fd != -1) { result |= do_single_test (fd, buf, sizeof (buf), 0); - result |= do_single_test (fd, NULL, sizeof (buf), EINVAL); result |= do_single_test (fd, buf, 1, ERANGE); close (fd); } diff --git a/sysdeps/unix/sysv/linux/ptsname.c b/sysdeps/unix/sysv/linux/ptsname.c index e3f2ae8..41bb0bb 100644 --- a/sysdeps/unix/sysv/linux/ptsname.c +++ b/sysdeps/unix/sysv/linux/ptsname.c @@ -72,12 +72,6 @@ __ptsname_internal (int fd, char *buf, size_t buflen, struct stat64 *stp) int save_errno = errno; unsigned int ptyno; - if (buf == NULL) - { - __set_errno (EINVAL); - return EINVAL; - } - if (!__isatty (fd)) { __set_errno (ENOTTY);