diff mbox

powerpc: add tests for __ppc_set_ppr_* functions.

Message ID 20161222121300.28285-1-wainersm@linux.vnet.ibm.com
State Superseded
Headers show

Commit Message

Wainer dos Santos Moschetta Dec. 22, 2016, 12:13 p.m. UTC
sys/platform/ppc.h defines a class of __ppc_set_ppr functions
used to set the Program Priority Register (PPR) in powerpc.
This patch implements test cases for these functions.

Tested on ppc64le.

2016-12-20  Wainer dos Santos Moschetta  <wainersm@linux.vnet.ibm.com>

	* sysdeps/powerpc/tst-set_ppr.c: New file.
	Implement test cases for __ppc_set_ppr_* functions.
	* sysdeps/powerpc/Makefile ($(subdir),misc): Add tst-set_ppr
	in the list of tests.
---
 sysdeps/powerpc/Makefile      |  1 +
 sysdeps/powerpc/tst-set_ppr.c | 76 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 sysdeps/powerpc/tst-set_ppr.c

Comments

Carlos Eduardo Seo Dec. 22, 2016, 3:05 p.m. UTC | #1
On 12/22/16, 10:13 AM, "Wainer dos Santos Moschetta" <libc-alpha-owner@sourceware.org on behalf of wainersm@linux.vnet.ibm.com> wrote:

diff --git a/sysdeps/powerpc/tst-set_ppr.c b/sysdeps/powerpc/tst-set_ppr.c
    new file mode 100644
    index 0000000..4c89fd4
    --- /dev/null
    +++ b/sysdeps/powerpc/tst-set_ppr.c
    @@ -0,0 +1,76 @@
    +/* Test the implementation of __ppc_set_ppr_* functions.

s/Test/Tests/

Other than that, LGTM.


--
Carlos Eduardo Seo
Software Engineer - Linux on Power Toolchain
cseo@linux.vnet.ibm.com
Tulio Magno Quites Machado Filho Dec. 28, 2016, 12:41 p.m. UTC | #2
Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com> writes:

> sys/platform/ppc.h defines a class of __ppc_set_ppr functions
> used to set the Program Priority Register (PPR) in powerpc.
> This patch implements test cases for these functions.
>
> Tested on ppc64le.

LGTM in overall, but....

> +/* Read the value of the Program Priority Register (PPR).  */
> +static __inline__ uint64_t
> +read_ppr (void)
> +{
> +  /* Represents the full 64-bits length register.  */
> +  uint64_t ppr;
> +  asm volatile ("mfppr  %0" : "=r"(ppr));

This won't work on 32 bits.  You have to use mfppr32.

> +  return ppr;
> +}
> +
> +/* Check the thread priority bits of PPR are set as expected. */
> +uint8_t
> +check_thread_priority (uint8_t expected, uint64_t ppr)
> +{
> +  /* The thread priority value is set on bits 11:13.  */
> +  uint64_t p = ((ppr >> 50) & 7);

This also needs to be changed.
diff mbox

Patch

diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile
index 099fbf6..933810f 100644
--- a/sysdeps/powerpc/Makefile
+++ b/sysdeps/powerpc/Makefile
@@ -34,6 +34,7 @@  endif
 ifeq ($(subdir),misc)
 sysdep_headers += sys/platform/ppc.h
 tests += test-gettimebase
+tests += tst-set_ppr
 endif
 
 ifneq (,$(filter %le,$(config-machine)))
diff --git a/sysdeps/powerpc/tst-set_ppr.c b/sysdeps/powerpc/tst-set_ppr.c
new file mode 100644
index 0000000..4c89fd4
--- /dev/null
+++ b/sysdeps/powerpc/tst-set_ppr.c
@@ -0,0 +1,76 @@ 
+/* Test the implementation of __ppc_set_ppr_* functions.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <inttypes.h>
+#include <stdio.h>
+#include <stdint.h>
+
+#include <sys/platform/ppc.h>
+
+/* Read the value of the Program Priority Register (PPR).  */
+static __inline__ uint64_t
+read_ppr (void)
+{
+  /* Represents the full 64-bits length register.  */
+  uint64_t ppr;
+  asm volatile ("mfppr  %0" : "=r"(ppr));
+  return ppr;
+}
+
+/* Check the thread priority bits of PPR are set as expected. */
+uint8_t
+check_thread_priority (uint8_t expected, uint64_t ppr)
+{
+  /* The thread priority value is set on bits 11:13.  */
+  uint64_t p = ((ppr >> 50) & 7);
+  if (p != expected)
+    {
+      printf ("FAIL: Expected %"PRIu8" got %"PRIu64".\n", expected, p);
+      return 1;
+    }
+  printf ("PASS: Thread priority set to %"PRIu64" correctly.\n", p);
+  return 0;
+}
+
+/* The Power ISA 2.07b allows the following thread priorities for any
+   problem state program: 1 (very low), 2 (low), 3 (medium low),
+   and 4 (medium).
+   Check whether the values set by __ppc_set_ppr_* are correct.  */
+static int
+do_test (void)
+{
+  uint8_t rc = 0;
+
+#ifdef _ARCH_PWR8
+  __ppc_set_ppr_very_low ();
+  rc |= check_thread_priority (1, read_ppr());
+#endif /* _ARCH_PWR8 */
+
+  __ppc_set_ppr_low ();
+  rc |= check_thread_priority (2, read_ppr());
+
+  __ppc_set_ppr_med_low ();
+  rc |= check_thread_priority (3, read_ppr());
+
+  __ppc_set_ppr_med ();
+  rc |= check_thread_priority (4, read_ppr());
+
+  return rc;
+}
+
+#include <support/test-driver.c>