From patchwork Thu Oct 8 21:55:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland McGrath X-Patchwork-Id: 9000 Received: (qmail 47771 invoked by alias); 8 Oct 2015 21:56:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 47759 invoked by uid 89); 8 Oct 2015 21:56:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 From: Roland McGrath To: Cc: Subject: Re: make check build failure (tst-printf-bz18872) In-Reply-To: Steve Ellcey's message of Thursday, 8 October 2015 14:42:33 -0700 <1444340553.8687.319.camel@ubuntu-sellcey> References: <1444338226.8687.307.camel@ubuntu-sellcey> <20151008210634.4BA352C3ABF@topped-with-meat.com> <1444339336.8687.311.camel@ubuntu-sellcey> <20151008213221.CFDB32C3AA0@topped-with-meat.com> <1444340553.8687.319.camel@ubuntu-sellcey> Message-Id: <20151008215558.C91542C3AA0@topped-with-meat.com> Date: Thu, 8 Oct 2015 14:55:58 -0700 (PDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=RZ8DVTdv c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=hOe2yjtxAAAA:8 a=kj9zAlcOel0A:10 a=NIIOcfnRHXaePKnKxgIA:9 a=CjuIK1q_8ugA:10 > It seems like that is still a bug in the Makefile though, should I > submit a patch? I just committed this myself: 2015-10-08 Roland McGrath [BZ #18872] * stdio-common/Makefile ($(objpfx)tst-unbputc.out): Move out from under [$(run-built-tests) = yes] conditional. ($(objpfx)tst-printf.out, $(objpfx)tst-printf-bz18872.c): Likewise. ($(objpfx)tst-printf-bz18872-mem.out): Likewise. > I found one other issue while doing 'make check'. I am using GCC 4.6.3 > on MIPS and string/tester.c didn't compile due to a > memset-transposed-args warning. It looks like there is handling for > this in GCC 5.0 and later but not for 4.6. Please address that in a separate thread. Thanks, Roland diff --git a/stdio-common/Makefile b/stdio-common/Makefile index 40f5cdf..df4122d 100644 --- a/stdio-common/Makefile +++ b/stdio-common/Makefile @@ -74,7 +74,6 @@ include ../Rules tst-printf-bz18872-ENV = MALLOC_TRACE=$(objpfx)tst-printf-bz18872.mtrace -ifeq ($(run-built-tests),yes) $(objpfx)tst-unbputc.out: tst-unbputc.sh $(objpfx)tst-unbputc $(SHELL) $< $(common-objpfx) '$(test-program-prefix)'; \ $(evaluate-test) @@ -91,7 +90,6 @@ $(objpfx)tst-printf-bz18872.c: tst-printf-bz18872.sh $(objpfx)tst-printf-bz18872-mem.out: $(objpfx)tst-printf-bz18872.out $(common-objpfx)malloc/mtrace $(objpfx)tst-printf-bz18872.mtrace > $@; \ $(evaluate-test) -endif CFLAGS-vfprintf.c = -Wno-uninitialized CFLAGS-vfwprintf.c = -Wno-uninitialized