From patchwork Tue Apr 14 22:39:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland McGrath X-Patchwork-Id: 6220 Received: (qmail 128578 invoked by alias); 14 Apr 2015 22:39:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 128555 invoked by uid 89); 14 Apr 2015 22:39:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 From: Roland McGrath To: "GNU C. Library" Subject: [PATCH roland/arm] ARM: Define PI_STATIC_AND_HIDDEN. Message-Id: <20150414223916.9B4782C3BDC@topped-with-meat.com> Date: Tue, 14 Apr 2015 15:39:16 -0700 (PDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=SvUDtp+0 c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=dMYVFXXhpogpAS0HPFwA:9 a=CjuIK1q_8ugA:10 I suspect this is now safe. (It caused no apparent mischief in my arm-linux-gnueabihf build using GCC 4.8.2.) But I don't actually know what GCC version is implied by "added by the GCC TLS patches". I'm guessing that 4.6 (our minimum) is new enough that this is always true now. If that's true, it would be nice to know the appropriate GCC version number for sure and mention that in the comment. If it is really still the case that some supported compiler versions or configurations do not reliably do pure PI access to static/hidden, then I'd like to have enough information about that to write a proper configure test. Thanks, Roland 2015-04-14 Roland McGrath * sysdeps/arm/configure.ac (PI_STATIC_AND_HIDDEN): Define it. * sysdeps/arm/configure: Regenerated. --- a/sysdeps/arm/configure +++ b/sysdeps/arm/configure @@ -1,7 +1,8 @@ # This file is generated from configure.ac by Autoconf. DO NOT EDIT! # Local configure fragment for sysdeps/arm. -#AC_DEFINE(PI_STATIC_AND_HIDDEN) +$as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h + # We check to see if the compiler and flags are # selecting the hard-float ABI and if they are then --- a/sysdeps/arm/configure.ac +++ b/sysdeps/arm/configure.ac @@ -3,9 +3,7 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. dnl It is always possible to access static and hidden symbols in an dnl position independent way. -dnl NOTE: This feature was added by the GCC TLS patches. We should test for -dnl it. Until we do, don't define it. -#AC_DEFINE(PI_STATIC_AND_HIDDEN) +AC_DEFINE(PI_STATIC_AND_HIDDEN) # We check to see if the compiler and flags are # selecting the hard-float ABI and if they are then