From patchwork Sun Feb 8 19:35:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 4973 Received: (qmail 17585 invoked by alias); 8 Feb 2015 19:35:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 17569 invoked by uid 89); 8 Feb 2015 19:35:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL, BAYES_00, SCAM_SUBJECT, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: sonata.ens-lyon.org Date: Sun, 8 Feb 2015 20:35:48 +0100 From: Samuel Thibault To: Roland McGrath Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH] hurd: take __USE_EXTERN_INLINES into account Message-ID: <20150208193548.GY3023@type.youpi.perso.aquilenet.fr> Mail-Followup-To: Roland McGrath , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20150207215637.GV3023@type.youpi.perso.aquilenet.fr> <20150208021514.ED7152C3B2F@topped-with-meat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150208021514.ED7152C3B2F@topped-with-meat.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) While working on it, I realized that there were more symbols which were never exposed, and AIUI it's just by luck that glibc libraries never made a reference to them, because gcc was by luck always inlining them. * hurd/Versions (libc: GLIBC_2.22): Add _hurd_fd_error_signal, _hurd_fd_error, __hurd_dfail, __hurd_sockfail, __hurd_threadvar_location_from_sp, __hurd_threadvar_location, _hurd_userlink_link, _hurd_userlink_unlink, _hurd_userlink_clear. diff --git a/hurd/Versions b/hurd/Versions index 77f5b42..91403a6 100644 --- a/hurd/Versions +++ b/hurd/Versions @@ -129,6 +129,14 @@ libc { # functions used in macros & inline functions __errno_location; } + GLIBC_2.22 { + # These always existed as inlines but the real functions were not exported. + _hurd_fd_error_signal; _hurd_fd_error; + __hurd_dfail; __hurd_sockfail; + __hurd_threadvar_location_from_sp; + __hurd_threadvar_location; + _hurd_userlink_link; _hurd_userlink_unlink; _hurd_userlink_clear; + } HURD_CTHREADS_0.3 { # weak refs to libthreads functions that libc calls iff libthreads in use