From patchwork Thu Dec 4 20:32:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland McGrath X-Patchwork-Id: 4070 Received: (qmail 13957 invoked by alias); 4 Dec 2014 20:32:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 13941 invoked by uid 89); 4 Dec 2014 20:32:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 From: Roland McGrath To: "GNU C. Library" Subject: [COMMITTED PATCH] De-warning a few stubs. Message-Id: <20141204203245.A7F062C3A08@topped-with-meat.com> Date: Thu, 4 Dec 2014 12:32:45 -0800 (PST) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=SvUDtp+0 c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=-Zxk9US8LtI8LjufmVgA:9 a=CjuIK1q_8ugA:10 2014-12-04 Roland McGrath * io/openat64.c: #include (__openat64): Prototypify. Use ignore_value on MODE. * io/openat.c: Likewise. * misc/reboot.c: #include (reboot): Prototypify. Use ignore_value on HOWTO. * misc/ptrace.c: #include (ptrace): Prototypify. Use ignore_value for va_arg'd parameters. --- a/io/openat.c +++ b/io/openat.c @@ -22,6 +22,7 @@ #include #include #include +#include /* Some mostly-generic code (e.g. sysdeps/posix/getcwd.c) uses this variable if __ASSUME_ATFCTS is not defined. */ @@ -33,10 +34,7 @@ int __have_atfcts; the directory associated with FD. If OFLAG includes O_CREAT, a third argument is the file protection. */ int -__openat (fd, file, oflag) - int fd; - const char *file; - int oflag; +__openat (int fd, const char *file, int oflag, ...) { int mode; @@ -66,6 +64,8 @@ __openat (fd, file, oflag) va_start (arg, oflag); mode = va_arg (arg, int); va_end (arg); + + ignore_value (mode); } __set_errno (ENOSYS); --- a/io/openat64.c +++ b/io/openat64.c @@ -21,15 +21,13 @@ #include #include #include +#include /* Open FILE with access OFLAG. Interpret relative paths relative to the directory associated with FD. If OFLAG includes O_CREAT, a third argument is the file protection. */ int -__openat64 (fd, file, oflag) - int fd; - const char *file; - int oflag; +__openat64 (int fd, const char *file, int oflag, ...) { int mode; @@ -59,6 +57,8 @@ __openat64 (fd, file, oflag) va_start (arg, oflag); mode = va_arg (arg, int); va_end (arg); + + ignore_value (mode); } __set_errno (ENOSYS); --- a/misc/ptrace.c +++ b/misc/ptrace.c @@ -19,6 +19,7 @@ #include #include #include +#include /* Perform process tracing functions. REQUEST is one of the values in , and determines the action to be taken. @@ -30,8 +31,7 @@ pid_t PID, void *ADDR, int DATA, void *ADDR2 after PID. */ int -ptrace (request) - enum __ptrace_request request; +ptrace (enum __ptrace_request request, ...) { pid_t pid; void *addr; @@ -60,32 +60,41 @@ ptrace (request) case PTRACE_SETFPREGS: case PTRACE_GETFPAREGS: case PTRACE_SETFPAREGS: - va_start(ap, request); - pid = va_arg(ap, pid_t); - addr = va_arg(ap, void *); - va_end(ap); + va_start (ap, request); + pid = va_arg (ap, pid_t); + addr = va_arg (ap, void *); + va_end (ap); + ignore_value (pid); + ignore_value (addr); break; case PTRACE_POKETEXT: case PTRACE_POKEDATA: case PTRACE_POKEUSER: - va_start(ap, request); - pid = va_arg(ap, pid_t); - addr = va_arg(ap, void *); - data = va_arg(ap, int); - va_end(ap); + va_start (ap, request); + pid = va_arg (ap, pid_t); + addr = va_arg (ap, void *); + data = va_arg (ap, int); + va_end (ap); + ignore_value (pid); + ignore_value (addr); + ignore_value (data); break; case PTRACE_READDATA: case PTRACE_WRITEDATA: case PTRACE_READTEXT: case PTRACE_WRITETEXT: - va_start(ap, request); - pid = va_arg(ap, pid_t); - addr = va_arg(ap, void *); - data = va_arg(ap, int); - addr2 = va_arg(ap, void *); - va_end(ap); + va_start (ap, request); + pid = va_arg (ap, pid_t); + addr = va_arg (ap, void *); + data = va_arg (ap, int); + addr2 = va_arg (ap, void *); + va_end (ap); + ignore_value (pid); + ignore_value (addr); + ignore_value (data); + ignore_value (addr2); break; default: @@ -97,5 +106,4 @@ ptrace (request) return -1; } - stub_warning (ptrace) --- a/misc/reboot.c +++ b/misc/reboot.c @@ -18,15 +18,16 @@ #include #include #include +#include /* Reboot the system. */ int -reboot (howto) - int howto; +reboot (int howto) { + ignore_value (howto); + __set_errno (ENOSYS); return -1; } - stub_warning (reboot)