Message ID | 20141009181952.GD4197@redhat.com |
---|---|
State | Not applicable |
Headers |
Received: (qmail 22711 invoked by alias); 9 Oct 2014 18:19:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 22694 invoked by uid 89); 9 Oct 2014 18:19:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Date: Thu, 9 Oct 2014 19:19:52 +0100 From: Jonathan Wakely <jwakely@redhat.com> To: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com> Cc: Michael Kerrisk-manpages <mtk.manpages@gmail.com>, GNU C Library <libc-alpha@sourceware.org>, carlos@redhat.com Subject: Re: Error in documentation of $ORIGIN in the ld.so man page Message-ID: <20141009181952.GD4197@redhat.com> References: <CAAHN_R0=P=ZxXhGcEMgr60zmH+sh29mg57dm8ccfo82+EyZqhg@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="PPxI8paQBs33t8dK" Content-Disposition: inline In-Reply-To: <CAAHN_R0=P=ZxXhGcEMgr60zmH+sh29mg57dm8ccfo82+EyZqhg@mail.gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) |
Commit Message
Jonathan Wakely
Oct. 9, 2014, 6:19 p.m. UTC
On 09/10/14 23:18 +0530, Siddhesh Poyarekar wrote: >Hi Michael, > >The ld.so man page says: > > $ORIGIN (or equivalently ${ORIGIN}) > This expands to the directory containing the application >executable. Thus, an application located in somedir/app could be >compiled with > >which is incorrect since it expands to the directory containing the >DSO and not the application executable. This seems like deliberate >behaviour in dl-object.c, so it needs to be fixed in the man page. >Credit goes to Jon Wakely for finding this[1]. Thanks, Siddhesh, I was just preparing this suggested patch.
Comments
Hello Jonathan and Siddesh, Thanks for the patch and the report. I applied the patch. One question, below. On 10/09/2014 08:19 PM, Jonathan Wakely wrote: > On 09/10/14 23:18 +0530, Siddhesh Poyarekar wrote: >> Hi Michael, >> >> The ld.so man page says: >> >> $ORIGIN (or equivalently ${ORIGIN}) >> This expands to the directory containing the application >> executable. Thus, an application located in somedir/app could be >> compiled with >> >> which is incorrect since it expands to the directory containing the >> DSO and not the application executable. This seems like deliberate >> behaviour in dl-object.c, so it needs to be fixed in the man page. >> Credit goes to Jon Wakely for finding this[1]. > > Thanks, Siddhesh, I was just preparing this suggested patch. > > > > diff --git a/man8/ld.so.8 b/man8/ld.so.8 > index a5a7293..ac02df6 100644 > --- a/man8/ld.so.8 > +++ b/man8/ld.so.8 > @@ -92,7 +92,7 @@ understands certain strings in an rpath specification (DT_RPATH or DT_RUNPATH); > .TP > .IR $ORIGIN " (or equivalently " ${ORIGIN} ) > This expands to > -the directory containing the application executable. > +the directory containing the program or library. I made this "...program or shared library". Okay? Thanks, Michael > Thus, an application located in > .I somedir/app > could be compiled with
On 28/10/14 14:46 +0100, Michael Kerrisk (man-pages) wrote: >Hello Jonathan and Siddesh, > >Thanks for the patch and the report. > >I applied the patch. One question, below. > >On 10/09/2014 08:19 PM, Jonathan Wakely wrote: >> On 09/10/14 23:18 +0530, Siddhesh Poyarekar wrote: >>> Hi Michael, >>> >>> The ld.so man page says: >>> >>> $ORIGIN (or equivalently ${ORIGIN}) >>> This expands to the directory containing the application >>> executable. Thus, an application located in somedir/app could be >>> compiled with >>> >>> which is incorrect since it expands to the directory containing the >>> DSO and not the application executable. This seems like deliberate >>> behaviour in dl-object.c, so it needs to be fixed in the man page. >>> Credit goes to Jon Wakely for finding this[1]. >> >> Thanks, Siddhesh, I was just preparing this suggested patch. >> >> >> > diff --git a/man8/ld.so.8 b/man8/ld.so.8 >> index a5a7293..ac02df6 100644 >> --- a/man8/ld.so.8 >> +++ b/man8/ld.so.8 >> @@ -92,7 +92,7 @@ understands certain strings in an rpath specification (DT_RPATH or DT_RUNPATH); >> .TP >> .IR $ORIGIN " (or equivalently " ${ORIGIN} ) >> This expands to >> -the directory containing the application executable. >> +the directory containing the program or library. > >I made this "...program or shared library". Okay? Yes, I think that's an improvement. I used "program or library" to match the first line of the SYNOPSIS which uses the same wording, but there it says "some dynamically linked program or library" which makes it clear it refers to shared libraries. Your change makes the same thing clear in the description of $ORIGIN. Thanks, Jonathan
On Tue, Oct 28, 2014 at 3:09 PM, Jonathan Wakely <jwakely@redhat.com> wrote: > On 28/10/14 14:46 +0100, Michael Kerrisk (man-pages) wrote: >> >> Hello Jonathan and Siddesh, >> >> Thanks for the patch and the report. >> >> I applied the patch. One question, below. >> >> On 10/09/2014 08:19 PM, Jonathan Wakely wrote: >>> >>> On 09/10/14 23:18 +0530, Siddhesh Poyarekar wrote: >>>> >>>> Hi Michael, >>>> >>>> The ld.so man page says: >>>> >>>> $ORIGIN (or equivalently ${ORIGIN}) >>>> This expands to the directory containing the application >>>> executable. Thus, an application located in somedir/app could be >>>> compiled with >>>> >>>> which is incorrect since it expands to the directory containing the >>>> DSO and not the application executable. This seems like deliberate >>>> behaviour in dl-object.c, so it needs to be fixed in the man page. >>>> Credit goes to Jon Wakely for finding this[1]. >>> >>> >>> Thanks, Siddhesh, I was just preparing this suggested patch. >>> >>> >>> > diff --git a/man8/ld.so.8 b/man8/ld.so.8 >>> index a5a7293..ac02df6 100644 >>> --- a/man8/ld.so.8 >>> +++ b/man8/ld.so.8 >>> @@ -92,7 +92,7 @@ understands certain strings in an rpath specification >>> (DT_RPATH or DT_RUNPATH); >>> .TP >>> .IR $ORIGIN " (or equivalently " ${ORIGIN} ) >>> This expands to >>> -the directory containing the application executable. >>> +the directory containing the program or library. >> >> >> I made this "...program or shared library". Okay? > > > Yes, I think that's an improvement. > > I used "program or library" to match the first line of the SYNOPSIS > which uses the same wording, but there it says "some dynamically > linked program or library" which makes it clear it refers to > shared libraries. Your change makes the same thing clear in the > description of $ORIGIN. > Thanks, Jonathan. Cheers, Michael
diff --git a/man8/ld.so.8 b/man8/ld.so.8 index a5a7293..ac02df6 100644 --- a/man8/ld.so.8 +++ b/man8/ld.so.8 @@ -92,7 +92,7 @@ understands certain strings in an rpath specification (DT_RPATH or DT_RUNPATH); .TP .IR $ORIGIN " (or equivalently " ${ORIGIN} ) This expands to -the directory containing the application executable. +the directory containing the program or library. Thus, an application located in .I somedir/app could be compiled with