diff mbox series

[3/5] resolv: Remove incorrect parts of TSIG handling from ns_sprintrrf (CVE-2026-5435)

Message ID 1bc94ca3ff4a1aafd1b6c4877d894e9bb1960808.1777546194.git.fweimer@redhat.com (mailing list archive)
State Under Review
Delegated to: Carlos O'Donell
Headers
Series Fixes for CVE-2026-5435, CVE-2026-6238 |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Florian Weimer April 30, 2026, 10:52 a.m. UTC 
  TSIG handling was incomplete before.  Given that this is an obsolete
interface, it does not seem worthwhile to complete the implementation.

This fixes bug 34033.
---
 resolv/ns_print.c | 10 ----------
 1 file changed, 10 deletions(-)
diff mbox series

Patch

diff --git a/resolv/ns_print.c b/resolv/ns_print.c
index 5701e3d0c5..9c9e810781 100644
--- a/resolv/ns_print.c
+++ b/resolv/ns_print.c
@@ -513,17 +513,7 @@  ns_sprintrrf(const u_char *msg, size_t msglen,
 
 	case ns_t_tsig: {
 		/* BEW - need to complete this */
-		int n;
-
 		T(len = addname(msg, msglen, &rdata, origin, &buf, &buflen));
-		T(addstr(" ", 1, &buf, &buflen));
-		rdata += 8; /*%< time */
-		n = ns_get16(rdata); rdata += INT16SZ;
-		rdata += n; /*%< sig */
-		n = ns_get16(rdata); rdata += INT16SZ; /*%< original id */
-		sprintf(buf, "%d", ns_get16(rdata));
-		rdata += INT16SZ;
-		addlen(strlen(buf), &buf, &buflen);
 		break;
 	    }