[v2] New language: Lower Sorbian (dsb_DE) [BZ #23208]

  It is likely that I will push this patch tomorrow.

In this version I took the freedom to introduce the changes according
to my previous concerns, please see below:

19.06.2018 01:44 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
>
> And here is my review:
>
> > diff --git a/localedata/locales/dsb_DE b/localedata/locales/dsb_DE
> > [...]
> > +LC_IDENTIFICATION
> > +title "Lower Sorbian locale for Germany"
> > +source "Information from Michael Wolf"
> > +address ""
> > +contact ""
> > +email ""
> > +tel ""
> > +fax ""
>
> It's not obligatory but wouldn't you like to add your personal data here?
> If not, then maybe let's add "bug-glibc-locales@gnu.org" as the email?

Added "bug-glibc-locales@gnu.org".

>
> > [...]
> > +LC_COLLATE
> > +copy "iso14651_t1"
> > +
> > +% CLDR collation rules for Lower Sorbian:
> > +%
> > (see:https://unicode.org/cldr/trac/browser/trunk/common/collation/dsb.xml)
> > +%
> > [...]
>
> We have agreed [1] to accept this chunk as is even if it is not perfect
> (I'm not telling it is not perfect, I'm just considering a possible case)
> so we will have a chance to tweak it in future.

Not changed.

> > + [...]
> > +% The characters ě, ń, ó, ŕ are usually used as lower case characters only,
> > +% only in fully capitalized words they exist as upper case characters
> > +% In contrast to Upper Sorbian, the character ř does not exist in Lower
> > Sorbian
> > +
> > +
> > +
> > +
> > +
> > +
>
> I think we can collapse this vertical space here. One empty line
> should be sufficient.

Done.

> > + [...]
> > +LC_CTYPE
> > +copy "i18n"
> > +END LC_CTYPE
>
> I'm not sure. I have a feeling that something is missing here.
> But if we don't figure out let's leave it as is.

Not changed.

> > +LC_MESSAGES
> > +yesexpr "^[+1hHyY]"
> > +noexpr "^[-0nN]"
> > +yesstr "jo"
> > +nostr "n<U011B>"
> > +END LC_MESSAGES
>
>
> If "yes" is "jo" in DSB then "yesexpr" must contain "jJ". Also as it has
> been copied from HSB I think that HSB should include "jJ" for the
> compatibility with German. Whether DSB should include "hH" for the
> compatibility with HSB... well, it's a question to you if there are DSB
> computer users so used to HSB that they may press 'H' as the answer for "yes"?

"jJ" added, this was necessary.  "hH" left unchanged.  Not needed but
not destructive.

> [...]
> > +LC_TIME
> > +abday "Nj";"P<U00F3>";/
> > + "Wa";"Sr";/
> > + "St";"P<U011B>";/
> > + "So"
> > +day "Nje<U017A>ela";/
> > + "P<U00F3>n<U017A>ela";/
>
> This says: "Pónźela" - CLDR says "pónjeźele".

I have decided to use "Pónjeźele".  This is what CLDR says except that
it is titlecased, same as other day names.  Wikipedia provides another
name but says that "pónjeźele" is also used.

> > + "Wa<U0142>tora";/
> > + "Srjoda";/
> > + "Stw<U00F3>rtk";/
> > + "P<U011B>tk";/
> > + "Sobota"
>
> Do you want to start all weekday names with uppercase? According to CLDR
> it is not necessary but if you think that weekday names usually appear in
> the beginning of the sentence and therefore you want to leave it like this
> then it is OK.

Not changed.

> > +abmon "Jan";"Feb";/
> > + "M<U011B>r";"Apr";/
> > + "Maj";"Jun";/
> > + "Jul";"Awg";/
> > + "Sep";"Okt";/
> > + "Now";"Dec"
> > +alt_mon "Januar";/
>
> I will adjust spaces here.

Adjusted here and in another place.

> [...]
> > +LC_PAPER
> > +copy "de_DE"
> > +END LC_PAPER
>
> Most of the locales use either “copy "i18n"” or “copy "en_US"”.

Changed to “copy "i18n"”.

> > + [...]
> > +LC_NAME
> > +name_fmt "%d%t%g%t%m%t%f"
> > +name_miss "kn<U011B><U017E>na"
> > +name_mr "kn<U011B>z"
> > +name_mrs "kn<U011B>ni"
> > +%name_ms ""
> > +END LC_NAME
>
> What about:
>
> name_ms "kn<U011B>ni"

Added “name_ms "kn<U011B>ni"”

>
> > +LC_ADDRESS
> > +postal_fmt "%f%N%a%N%d%N%b%N%s %h %e %r%N%z %T%N%c%N"
> > +country_name "Nimska"
> > +country_post "D"
> > +country_ab2 "DE"
> > +country_ab3 "DEU"
> > +country_num 276
> > +country_car "D"
> > +country_isbn 3
> > +lang_name "dolnoserb<U0161><U0107>ina"
> > +lang_ab ""
> > +lang_term "dsb"
> > +lang_lib "dsb"
> > +END LC_ADDRESS
>
> I can see this is copied from hsb_DE except few fields which had obligatorily
> to be changed. Therefore I believe this is correct.

Not changed but adjusted spaces.

Regards,

Rafal

[v2] New language: Lower Sorbian (dsb_DE) [BZ #23208]

Commit Message

Comments

Patch