[1/1] Pashto yesstr/nostr locale are missing

Message ID 1499237246-35855-1-git-send-email-akhilesh.k@samsung.com
State Committed
Delegated to: Mike Fabian
Headers

Commit Message

Akhilesh Kumar July 5, 2017, 6:47 a.m. UTC
  [BZ #21711]
During Locale verification i observed that

yesstr and nostr  are missing for Pashto [LC_MESSAGES] Locale

for Afghanistan reference google translater and Pashto travel book
---
 localedata/locales/ps_AF | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Mike FABIAN July 6, 2017, 8:24 a.m. UTC | #1
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21711]
> During Locale verification i observed that
>
> yesstr and nostr  are missing for Pashto [LC_MESSAGES] Locale
>
> for Afghanistan reference google translater and Pashto travel book
> ---
>  localedata/locales/ps_AF | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/localedata/locales/ps_AF b/localedata/locales/ps_AF
> index 702a830..2413b1c 100644
> --- a/localedata/locales/ps_AF
> +++ b/localedata/locales/ps_AF
> @@ -232,6 +232,8 @@ END LC_MONETARY
>  LC_MESSAGES
>  yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U0628><U0066><U005D>"
>  noexpr  "<U005E><U005B><U002D><U0030><U006E><U004E><U062E><U0646><U006F><U005D>"
> +yesstr "<U0647><U0648>"
> +nostr "<U0646><U0647>"
>  END LC_MESSAGES
>  
>  LC_MEASUREMENT

I checked that http://thepashto.com/ gives the same strings for yes and
no.

Committed.
  
Rafal Luzynski July 8, 2017, 12:18 a.m. UTC | #2
6.07.2017 10:24 Mike FABIAN <mfabian@redhat.com> wrote:
>
>
> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
> > [...]
> > diff --git a/localedata/locales/ps_AF b/localedata/locales/ps_AF
> > index 702a830..2413b1c 100644
> > --- a/localedata/locales/ps_AF
> > +++ b/localedata/locales/ps_AF
> > @@ -232,6 +232,8 @@ END LC_MONETARY
> > LC_MESSAGES
> > yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U0628><U0066><U005D>"
> > noexpr
> > "<U005E><U005B><U002D><U0030><U006E><U004E><U062E><U0646><U006F><U005D>"
> > +yesstr "<U0647><U0648>"
> > +nostr "<U0646><U0647>"
> > END LC_MESSAGES
> >
> > LC_MEASUREMENT
>
> I checked that http://thepashto.com/ gives the same strings for yes and
> no.
>
> Committed.

Don't yesexpr and noexpr need an update now?  At least, I can't see
"<U0647>" character in yesexpr.

Regards,

Rafal
  
Mike FABIAN July 11, 2017, 8:02 a.m. UTC | #3
Rafal Luzynski <digitalfreak@lingonborough.com> wrote:

> 6.07.2017 10:24 Mike FABIAN <mfabian@redhat.com> wrote:
>>
>>
>> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>
>> > [...]
>> > diff --git a/localedata/locales/ps_AF b/localedata/locales/ps_AF
>> > index 702a830..2413b1c 100644
>> > --- a/localedata/locales/ps_AF
>> > +++ b/localedata/locales/ps_AF
>> > @@ -232,6 +232,8 @@ END LC_MONETARY
>> > LC_MESSAGES
>> > yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U0628><U0066><U005D>"
>> > noexpr
>> > "<U005E><U005B><U002D><U0030><U006E><U004E><U062E><U0646><U006F><U005D>"
>> > +yesstr "<U0647><U0648>"
>> > +nostr "<U0646><U0647>"
>> > END LC_MESSAGES
>> >
>> > LC_MEASUREMENT
>>
>> I checked that http://thepashto.com/ gives the same strings for yes and
>> no.
>>
>> Committed.
>
> Don't yesexpr and noexpr need an update now?  At least, I can't see
> "<U0647>" character in yesexpr.

Yes, but I am unsure how. There are some Arabic characters in yesexpr
and noexpr, but they seem to have nothing to do with what we have no in
yesstr and nostr. I wonder whether these Arabic characters which we have
now in yesexpr and noexpr are just wrong ...
  
Rafal Luzynski July 11, 2017, 10:22 p.m. UTC | #4
11.07.2017 10:02 Mike FABIAN <mfabian@redhat.com> wrote:
>
> Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
>
> > [...]
> > Don't yesexpr and noexpr need an update now? At least, I can't see
> > "<U0647>" character in yesexpr.
>
> Yes, but I am unsure how.

Fair enough.  I think it's better to leave this unchanged if we don't
know how to change correctly.  Hopefully someone with a better knowledge
will eventually file a bug report and explain this.

> There are some Arabic characters in yesexpr
> and noexpr, but they seem to have nothing to do with what we have no in
> yesstr and nostr. I wonder whether these Arabic characters which we have
> now in yesexpr and noexpr are just wrong ...

They may be formally wrong but sometimes useful.  Similarly to +/-,
1/0, and y/n which we have added to many other locales even although
they don't look like "yes"/"no" in their proper languages.

Regards,

Rafal
  

Patch

diff --git a/localedata/locales/ps_AF b/localedata/locales/ps_AF
index 702a830..2413b1c 100644
--- a/localedata/locales/ps_AF
+++ b/localedata/locales/ps_AF
@@ -232,6 +232,8 @@  END LC_MONETARY
 LC_MESSAGES
 yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U0628><U0066><U005D>"
 noexpr  "<U005E><U005B><U002D><U0030><U006E><U004E><U062E><U0646><U006F><U005D>"
+yesstr "<U0647><U0648>"
+nostr "<U0646><U0647>"
 END LC_MESSAGES
 
 LC_MEASUREMENT