diff mbox

Fix wrong comments in struct ip_mreq_source

Message ID 1493840562.4543.47.camel@pbcl.net
State New, archived
Headers

Commit Message

Phil Blundell May 3, 2017, 7:42 p.m. UTC 
  The member names in this struct are fairly self-explanatory, but were
contradicted by the comments.  This patch swaps the comments around so
that they match.

I verified that the order of the elements does match the corresponding
uapi header from the Linux kernel.

OK to commit?  (I wasn't quite sure whether this was obvious enough to
count as a "trivial fix".)

p.

2017-05-03  Phil Blundell  <pb@pbcl.net>

        * inet/netinet/in.h (struct ip_mreq_source): Correct misplaced
        comments.

Comments

Carlos O'Donell May 3, 2017, 7:53 p.m. UTC | #1 
On 05/03/2017 03:42 PM, Phil Blundell wrote:
> The member names in this struct are fairly self-explanatory, but were
> contradicted by the comments.  This patch swaps the comments around so
> that they match.
> 
> I verified that the order of the elements does match the corresponding
> uapi header from the Linux kernel.
> 
> OK to commit?  (I wasn't quite sure whether this was obvious enough to
> count as a "trivial fix".)
> 
> p.
> 
> 2017-05-03  Phil Blundell  <pb@pbcl.net>
> 
>         * inet/netinet/in.h (struct ip_mreq_source): Correct misplaced
>         comments.

OK. This counts as a trivial fix. Even if you'd gotten it wrong the comment
change could just be another commit away from being right.
diff mbox

Patch

diff --git a/inet/netinet/in.h b/inet/netinet/in.h
index 365bc6878e..e064188721 100644
--- a/inet/netinet/in.h
+++ b/inet/netinet/in.h
@@ -275,10 +275,10 @@  struct ip_mreq_source
     /* IP multicast address of group.  */
     struct in_addr imr_multiaddr;
 
-    /* IP address of source.  */
+    /* IP address of interface.  */
     struct in_addr imr_interface;
 
-    /* IP address of interface.  */
+    /* IP address of source.  */
     struct in_addr imr_sourceaddr;
   };
 #endif