From patchwork Tue Nov 1 22:29:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 17089 Received: (qmail 61282 invoked by alias); 1 Nov 2016 22:29:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 61174 invoked by uid 89); 1 Nov 2016 22:29:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Tested, 3211 X-HELO: NAM03-CO1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1478039344.2891.50.camel@caviumnetworks.com> Subject: Re: [PATCH] Fix warning from latest GCC in tst-printf.c From: Steve Ellcey To: Joseph Myers CC: Date: Tue, 1 Nov 2016 15:29:04 -0700 In-Reply-To: References: <1477003405.8523.21.camel@caviumnetworks.com> <1478020891.2891.45.camel@caviumnetworks.com> MIME-Version: 1.0 X-ClientProxiedBy: BY1PR0201CA0006.namprd02.prod.outlook.com (10.160.191.144) To BLUPR0701MB1060.namprd07.prod.outlook.com (10.160.35.147) X-MS-Office365-Filtering-Correlation-Id: 4c9df736-c7d6-4dcd-d039-08d402a67fb0 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 2:K0NCTd7d0DqTO6S2lult3RgPk4LwfhdSi8XqE7JHzz9uHZg28tZz+yD3HVnD1fmLSPZqUo/16pCPHR+4izUgzYQTIN9gPh3OQEMydMwHWZJrlqx8K2++SXbQnJSUEwvDY+3Bi4WSEIhL5e/EGnVl3xLHdZWR4kd/onCWR82u+pgEzvvXcm/ugpmaDlNwP0DZGJtknHQ+XeGpQHhr3/p7WQ==; 3:h1DX+Z8CfN4X4VWgHNQdzRGZw2mgZFQULgav9ZTabU/rfvbKL7gyx41LXZidsgzw06aowJ6ZqR1nJ5uVREvMYf2ZOPCsE84amsiXPfmtY98xo9/m66xOFkSEflrfNRmNd+i9os7npcOv7sB9VwyBzg==; 25:ASWAp4YOJKhoxzQ9msmMs/caJCeIS2RFv2UTAzInl/AZT7R+pGZ2c56zFoa5NfYUw8j7zFsSJeNShSXaIiLbTDvR8XfkG9V4dqIzVJFheukcITLQaoWoUxeT4MSNgvE8xVm/RWqsAiRomB5tgWUSX4Sb6CP6r42ASMQHFDqveRK7Ze79PCqhb170NurPx/fvBLgM4YPZUr2Z9I462bdMnQUEHfBtvmaZQhc08jWdgVzaooClC+N/yjZRetvmUmrV6YKYp1MfUEM5NaukVSACUOBtaeVTh/ISqgbqZ2upSt2h8s4JkcY0cHt/9UKCXsS1Z8hpFuywz+7KIMMa44papCYXpNC0b7kpb6Vgu0Zyr26iNxF90W9/w9GEEynI8m2ELamk8CmqHdeEs+o7LsvhCHvKwyl2wZ4v56JHTFBfeG7Ib+efOPqZ2qP0qDuRtD85 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1060; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 31:oW4ZcOKeGApgwrKP0OFoUXFl/baCzm3sEv04N9v4/e42KyYFopOFaz/YvmcPZupmRYc8CKpIurVzKmOf3hiiAXzrpUmUTl9DOxMbyf62nOQsLBl4hO8MCafsBSMvf6BQk4JnntxmeSu8Z0HEwWvCJ+CthXfmGhaaZmjqiYjM5X48VuwMx8EpQIbeO0NCM5agTteRT0HnrMjqgGzVERt7VQhBd+rcmDLav0CrIDE57CAtlB3PB/lWD3fPxEBDfglG5fIJkB3m7c7YjfnONou0UA==; 20:h7HIabgoBOPDadtxdHn1Cs16S4VWXYRSopzMbPiYPLKclT2cPV84mceMbyE6l5uR0h+Z7gqWpRJZhc1q3VrwmQgaD0QqTWRQ0SQlhQEjEbFmBz9DdI3p8AuCYSKTk9RypBEmwM3XK5iFjxoVX6cgLtJSlLcokTEyYYcjv9VofgmzLeFHlCMwwmf/B+qGdIIoYbvJvM6emF4iV9XZTMr0mJV0OTcI4rxVR89weGzAiHgRYR9hZNo0txRb0jDpqlHhrpHcDwYfSQyNX1GxOWtwMSIVj8U+hHh36blpICZj6g2o+34tp7fpe/mEGnFijvqMsGQMJ5dJXHZSXb9NmGMFYUJfLXIl4oNO1LkoFaDeQHtQXAx4CPo2livt9Vf6MH7u5qf+GPWIuzmS24yHtzQMbURkG1WSDJnMoXFMRsuM5eANEw9DlGpuAjq5R5vwcm3uyLlG3Q2mLnOjPs0zvONKZvWvlRDOqy54gAU6A1Xol1zYlL20oc9JhTzR7Trb/k9xqZUA5hzSK0TnN9r2PYWnivXB3lT8kwdxqArPHIFYAPq4DmMyra4BjstN9MdOzICS4xkcicO7+WL4I/tdnANrXejzwjVPdg55x3jws4nfqzA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR0701MB1060; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1060; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 4:dloKVX2+dC49+VrlYrOhYG7i9SE2Hdl4h+Io1iOa+whxyBEwCY+Hstgxl1u/N2qEe1j+wFUtK3sD3Ge4qwa+W8ePOVFaDulP5Tn+QxNgGIgWvUmxm4KuDZxES6oNjNuovUcOE4Pmj+pAk7C9YBWrQ+utGyZSbKcGwemJ0rPzbm2qg/S88i7avG3rjtroJUpEqoXxe5FiPKCtu4Xt7Xhg036BL8ifQsn0BWg4iTPoYIFFZ8QMtQuBgAJRCi7wq9dDFFoGSLA3CHZ6jP2IsJFZmUoE9v0xd4AaeXVayetLFrWyAjari1bMaqOA+Sj5IU2YlS3EK2u0pSFykmb3GQiqdfBs7Q2WwrBrPlJA6bsORN8qVyKKBNWNs60EIgLQ314f81TVobbtTp0A/8BJzog0Kw== X-Forefront-PRVS: 01136D2D90 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(24454002)(377424004)(189002)(2950100002)(586003)(6916009)(97736004)(42882006)(7846002)(19580405001)(7736002)(3846002)(103116003)(2906002)(77096005)(5820100001)(50986999)(76176999)(4326007)(50226002)(2870700001)(305945005)(19580395003)(110136003)(92566002)(6116002)(69596002)(189998001)(47776003)(66066001)(106356001)(68736007)(101416001)(81166006)(105586002)(50466002)(5660300001)(33646002)(36756003)(53416004)(81156014)(42186005)(8676002)(6666003)(23676002)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1060; H:sellcey-lt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA3MDFNQjEwNjA7MjM6dWZZcVNsZVdrUGxVejZlREZTL2FXc29v?= =?utf-8?B?VVFGTTllSE1WM2RRZUVnK0tpKzZqMDlKVkt0eHYzbjJ2M1BIZVR5TE9ZNjRC?= =?utf-8?B?UUhyOHRXY2VQb1R0Z3lJc2FORjVsd0xMemp2anh2a1dGNHNTZGxvcnFSWFNl?= =?utf-8?B?N01PVHk4S0VqNndvVEhtV2VyeGI4VVd6NWxTQ2xuK2NKR1BsRllMYVBKZ3VY?= =?utf-8?B?UjliNkY5K0liTFYxL3dlc2R3ems0N0l5V1pXanVzWmdFS29kSDRoSGJlZ1Ix?= =?utf-8?B?amFZOWZIRXJPREhOV3NUb09hRVRRcFhhcnRGL1l0Vi92VWNCcnBCd0dhdVor?= =?utf-8?B?cnFLRDlsSlB3ZXlSMXdjT045WitLZDdGUmMyKzk3UkM0c1NtenJUai8xWmps?= =?utf-8?B?SHpIVUc5SFp3Mklnb1F4WFVtbjcrMUFJM3hqbStiVmYvaVR6ZUNMdU9ocnJi?= =?utf-8?B?Vmxva3B0TG1OenpWWkRVOGFENWt3VXA3SG1LcVRFZDg2UVNPcUVSMi90THFh?= =?utf-8?B?dWFVZXlRVDBoeFp1RzlWR2o3TXJjdm02c29JN1ZPZGlHMWhqNmlwbkp0eUFE?= =?utf-8?B?ZVNxK2g2LzdMSlVVMW1zTDBzUTBHNk1FM2VHM0N0dlhQOXl2QUYyKy9jcW5v?= =?utf-8?B?eVlCNENOSFNpeWhqODhFYmRVVS9oQmhpT0Jia1NXQUYvUXBvUFlPc0pnVlN5?= =?utf-8?B?NlZZWFRhdXh0Mnoyb1RmeVNVNGkyc0FTM0JhbldoYmRxMkUvaXZCejk5cHZh?= =?utf-8?B?dGpnZXVMempFWGxsVTFuM2ZjU0FyNjNFOVhkZXA3UHd5QWtPZFJyeXpVMkw1?= =?utf-8?B?TmVMTGxwNHJBbEFmZU5kNlI3eEl1UWY1V1kyTmhZcE1HUVhNbmxyNDlJb255?= =?utf-8?B?NjViU3diTkExRzRTOU1nelgvVWVqS1JJSTBlbzZ4QytWTnZwYXVvUWh0V21y?= =?utf-8?B?YzlOdHZYV0dmZ2JubkxIT3NiM2FMSVBXVzZUMElCV2l5THkxUloxZ3NOcnBQ?= =?utf-8?B?ek9KRGxjSDNKdFFiMUI3cWMwcHNWdXExeTBmT3l3UVlucXhpSlROeUgrK0tB?= =?utf-8?B?S3NhSEhPMUsrU2FrVEc3Y3NUL0oxMmlSNUltcmF4WDRNcFkydGZJMU5tUjBW?= =?utf-8?B?QUpJTEM5NVluUWNxZmJGRDV4emhsajkyZXNDYVQ2eFk3RmRhaVBib215Rmto?= =?utf-8?B?eHBnMGwzMlJLaEM3RFFSRU5VTElVMmgxZlF4ZEhBYjRHK3IrUlJ3Q2RxMjZh?= =?utf-8?B?T3pSQVk3Qjd0bTc0U2V4alByUjRqSDFkOVU0UHNqQ08xYzBMQkQ3M056TzV6?= =?utf-8?B?c1doK2NSc2QxTzNqa09pNzZaNVlQb0xsMERocWt6eVpVdlVMTTdNT25nZDVK?= =?utf-8?B?QTh3L2hTaEMxd0kzTmszRmgwTmNYTk5VVXZsTGJLZGh5U3NRQ2NTek1Oanh1?= =?utf-8?B?UW5lQnBwcVRYTExaWGg2a2t2V1QxWVNSRGVpc1NXcHhHQW5UYmlCVEVMd1Ns?= =?utf-8?B?VFhBRnAzY09xaUVsb2poeHpSRWk5T0doKzZ2NmlwMnBtRlg2cWo3cjJURWVa?= =?utf-8?B?SEhBVHh5SWZnQ05jd2FBN3ZRSUVqMUV1YjU0WTlDVEVBZncxdnkzWWhGdjBL?= =?utf-8?B?bVFETHZUbHFLN21DTHZUaWp5MHpqN3Mrd2pGY0taNVFPSHNORGRqN1lUUyto?= =?utf-8?Q?++/j7TVwhWjrYjuadMxQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 6:4y0XrNMahkJx8jE6Oq8MBL6XIovnmYosJ+1yKyuThmfeP5i/frssBvMPo9cZjTizUDVnWJ3p+Mq3sWX4VIJewPFiNfVjs9pKIdNPjHx6O2S05E0IjPSbG/SB/cVWm6b4e8NUSbhCMRlYU7nDETVyr/pKZx+gAKTJiR6tM9FL0FSec+H3EsxrElBC1cjhsv/ZUlOMZ64zyf2OLYrPuQta+ANpRgORwKvFQbAvmXx4jQ/E9p4xQld67r7ekdmS+u3T2xKYE/D7SPCAnwaEs2QwPlRSG7/arrsRYva1rmXm1+gTF/EBlizcdI0Md9BHPDhL; 5:GuAj4o8ab7FwrgZYdNQD3LTgxDvMrw9OmRc2B5voaNHy3zdo7mjr0zBInavihcxH8lNAkG6In2LJiZUk7lExdLGqKzSYzO7rLqDCTxA9KqxyHZ2QtmxbXrU+e5lyrBTQZSPuN7ylEANqOJHnKaKVlg==; 24:NYp6d5vtePAEinkbxOFwCm3cdF7XjUUQeGWG4ebjZybljepRhLhNHbOV4IoQ0G1kHXl9ii2hmttKuJ6ezN/S2yNngBeB+8GfsncjX7k3tZ8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 7:TnPvk0Gw9KnCBzqd4ttryYOWysXbxR1d4lsqf4Rzicz+5PQCoJdT0aHEXS+CmuKRDpuDJWYuzmfKPZybMkjEhNalK9Uq+qrSHLYwAIn/S7r1gF0n0dsspv28jk+NJ5O7P5AW9kFRkyV4acU4udY0QcWBii1W59qZ1WD2x6bA+YHbf/beV37S8ivXVb/2WRcsmYGnhMz6HoYymQDhPm3CRg/qFjRM3gPSmT4P0U3EHuyhE3VkXkFwuGKxHYL3aO/2MU/8VOQ1OW2p3kh6IW/ttlFHymI0qZYCt9gyUWxgzjwfQ0OaodSI/golDn9fNfNNAPAE7L6lO4c2kpzmlT5pzLks/85bV6dsp6S7Y0fE/Cc= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2016 22:29:09.3401 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1060 On Tue, 2016-11-01 at 17:37 +0000, Joseph Myers wrote: > On Tue, 1 Nov 2016, Steve Ellcey wrote: > > > > > Ping.  One of the snprintf statements in this test is using a %.999999u > > format so it is obvious that the test wants to test formats that would > > go beyond the limit of the snprintf buffer and so we should ignore the > > warnings in this test. > OK provided you've tested that this change works with older GCC that lack  > the new option (otherwise it would need to be conditional on the GCC  > version). I did forget to check it with an older GCC and it does fail with GCC 5.4.  Here is a new version with a conditional.   Tested with GCC 5.4 and GCC 7.0 (prerelease). Ok to checkin? Steve Ellcey sellcey@caviumnetworks.com 2016-11-01  Steve Ellcey   * stdio-common/tst-printf.c: Ignore -Wformat-length warning. diff --git a/stdio-common/tst-printf.c b/stdio-common/tst-printf.c index 2896b18..ffe7ac7 100644 --- a/stdio-common/tst-printf.c +++ b/stdio-common/tst-printf.c @@ -32,6 +32,11 @@     The compiler warnings are not useful here.  */  DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wformat");   +#if __GNUC_PREREQ (7, 0) +/* Compiler warnings about format lengths should also be ignored.  */ +DIAG_IGNORE_NEEDS_COMMENT (7.0, "-Wformat-length"); +#endif +  static void rfg1 (void);  static void rfg2 (void);  static void rfg3 (void);