diff mbox

conform/linknamespace: whitelist matherrf/matherrl

Message ID 1437621295-25240-1-git-send-email-vapier@gentoo.org
State Committed
Delegated to: Mike Frysinger
Headers show

Commit Message

Mike Frysinger July 23, 2015, 3:14 a.m. UTC
glibc supports the deprecated matherr hook for math error reporting.  The
conform tests take this into consideration and whitelist this symbol when
running linknamespace tests.

The ia64 libm code has long provided two additional hooks in this space:
	matherrf (for floats)
	matherrl (for long doubles)

Which causes the conform tests to fail with chains that all look like:
	[initial] __atan2 ->
	[libm.a(e_atan2.o)] __libm_error_support ->
	[libm.a(libm_error.o)] matherrf

We can't (losslessly) redirect existing usage of these funcs to matherr
because the structure passed in is different -- matherr uses a struct with
doubles while matherrf/matherrl use floats and long doubles respectively.
Plus, this has been part of the exported ABI since glibc-2.2.3, so it
doesn't feel right to change it so late.

Until we get around to obsoleting matherr entirely, whitelist these two
additional ia64 symbols.
---
 ChangeLog                | 4 ++++
 conform/linknamespace.pl | 6 ++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

Comments

Joseph Myers July 23, 2015, 2:22 p.m. UTC | #1
On Wed, 22 Jul 2015, Mike Frysinger wrote:

> +	* conform/linknamespace.pl (@whitelist): Add matherrf and matherrl.

OK.
diff mbox

Patch

diff --git a/ChangeLog b/ChangeLog
index 652d968..df9f670 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@ 
+2015-07-23  Mike Frysinger  <vapier@gentoo.org>
+
+	* conform/linknamespace.pl (@whitelist): Add matherrf and matherrl.
+
 2015-07-22  Mike Frysinger  <vapier@gentoo.org>
 
 	* sysdeps/unix/sysv/linux/ia64/bits/msq.h: Change sys/types.h include
diff --git a/conform/linknamespace.pl b/conform/linknamespace.pl
index 847d2dd..15fa613 100644
--- a/conform/linknamespace.pl
+++ b/conform/linknamespace.pl
@@ -49,9 +49,11 @@  close (STDSYMS) || die ("close $stdsyms_file: $!\n");
 # * Bug 18442: re_syntax_options wrongly brought in by regcomp and
 # used by re_comp.
 #
-# * False positive: matherr only used conditionally.
+# * False positive: matherr only used conditionally.  matherrf/matherrl are used
+# by IA64 too for the same reason.
 #
-@whitelist = qw(signgam stdin stdout stderr re_syntax_options matherr);
+@whitelist = qw(signgam stdin stdout stderr re_syntax_options matherr matherrf
+		matherrl);
 foreach my $sym (@whitelist) {
   $stdsyms{$sym} = 1;
 }