From patchwork Sat Jan 3 22:18:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 4499 Received: (qmail 21623 invoked by alias); 3 Jan 2015 22:18:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 21613 invoked by uid 89); 3 Jan 2015 22:18:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_50, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f43.google.com X-Received: by 10.70.133.98 with SMTP id pb2mr132045286pdb.137.1420323489800; Sat, 03 Jan 2015 14:18:09 -0800 (PST) From: Richard Henderson To: libc-alpha@sourceware.org Subject: [PATCH] Use -Wno-error=trampolines Date: Sat, 3 Jan 2015 14:18:06 -0800 Message-Id: <1420323486-25423-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 On gentoo, at least with gcc 4.9, -Wtrampolines are enabled by default: tst-execstack-mod.c: In function ‘tryme’: tst-execstack-mod.c:16:8: error: trampoline generated for nested function ‘callback’ [-Werror=trampolines] void callback (void) { ok = true; } ^ cc1: all warnings being treated as errors But of course these testcases require the use of trampolines. Ok? r~ --- ChangeLog | 6 ++++++ elf/Makefile | 2 ++ nptl/Makefile | 1 + 3 files changed, 9 insertions(+) diff --git a/ChangeLog b/ChangeLog index 1b08fb4..7939108 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2015-01-03 Richard Henderson + + * elf/Makefile (CFLAGS-tst-execstack-mod.c): Add -Wno-error=trapolines + (CFLAGS-tst-execstack-prog.c): Likewise. + * nptl/Makefile (CFLAGS-tst-execstack-mod.c): Likewise. + 2015-01-02 Joseph Myers [BZ #17748] diff --git a/elf/Makefile b/elf/Makefile index 11d6865..09ab68d 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -861,6 +861,8 @@ $(objpfx)tst-execstack-needed: $(objpfx)tst-execstack-mod.so LDFLAGS-tst-execstack-needed = -Wl,-z,noexecstack LDFLAGS-tst-execstack-prog = -Wl,-z,execstack +CFLAGS-tst-execstack-prog.c += -Wno-error=trampolines +CFLAGS-tst-execstack-mod.c += -Wno-error=trampolines endif LDFLAGS-tst-array2 = $(no-as-needed) diff --git a/nptl/Makefile b/nptl/Makefile index 86c44b2..dbb2d86 100644 --- a/nptl/Makefile +++ b/nptl/Makefile @@ -619,6 +619,7 @@ tst-exec4-ARGS = $(host-test-program-cmd) $(objpfx)tst-execstack: $(libdl) $(objpfx)tst-execstack.out: $(objpfx)tst-execstack-mod.so LDFLAGS-tst-execstack = -Wl,-z,noexecstack +CFLAGS-tst-execstack-mod.c += -Wno-error=trampolines $(objpfx)tst-fini1mod.so: $(shared-thread-library)