From patchwork Mon Dec 22 17:50:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 4396 Received: (qmail 27300 invoked by alias); 22 Dec 2014 17:50:11 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 27285 invoked by uid 89); 22 Dec 2014 17:50:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Message-ID: <1419270604.27606.32.camel@ubuntu-sellcey> Subject: RE: [Patch, MIPS] Modify memset.S for mips32r6/mips64r6 From: Steve Ellcey Reply-To: To: Joseph Myers CC: Matthew Fortune , "libc-alpha@sourceware.org" Date: Mon, 22 Dec 2014 09:50:04 -0800 In-Reply-To: References: <2923c970-026c-4e00-be7a-0650e82421b5@BAMAIL02.ba.imgtec.org> <6D39441BF12EF246A7ABCE6654B0235320F8CECA@LEMAIL01.le.imgtec.org> MIME-Version: 1.0 On Sat, 2014-12-20 at 00:23 +0000, Joseph Myers wrote: > Please put this in a central place (a single header that defines > __mips_isa_rev to 0 if not already defined, for example) rather than > duplicating "defined" tests in different places ("defined" tests are > typo-prone and so discouraged in glibc). Would sysdeps/unix/mips/sysdep.h be an appropriate place to define __mips_isa_rev? That header is already used by memcpy and memset. I thought about using asm.h but that header is visible to users and defining it there would be a visible change that could affect user programs. sysdep.h is internal to glibc and so does not have that problem. If we add it here there would be no changes needed to memcpy.S or memset.S, though Ondrej had some useful performance comments I would like to look at later (once we have the basic functionality checked in). Steve Ellcey sellcey@imgtec.com 2014-12-22 Steve Ellcey * sysdeps/unix/mips/sysdep.h (__mips_isa_rev): Set to zero if not already defined. diff --git a/sysdeps/unix/mips/sysdep.h b/sysdeps/unix/mips/sysdep.h index d59fac0..dc70c0f 100644 --- a/sysdeps/unix/mips/sysdep.h +++ b/sysdeps/unix/mips/sysdep.h @@ -78,4 +78,8 @@ # define L(label) .L ## label #endif +#ifndef __mips_isa_rev +# define __mips_isa_rev 0 +#endif + #endif