From patchwork Fri Aug 29 13:32:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Vladimir A. Nazarenko" X-Patchwork-Id: 2583 Received: (qmail 7705 invoked by alias); 29 Aug 2014 13:32:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 7694 invoked by uid 89); 29 Aug 2014 13:32:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 X-HELO: forward10l.mail.yandex.net X-Yandex-Uniq: 98b3ff37-4ced-41ab-8934-0a0fc779155d Authentication-Results: smtp2o.mail.yandex.net; dkim=pass header.i=@ya.ru From: "Vladimir A. Nazarenko" To: "GNU C. Library" Cc: Ulrich Drepper , naszar Subject: [PATCH] [BZ 17273] fix incorrect mount table entry parsing in __getmntent_r() Date: Sat, 30 Aug 2014 00:32:04 +1100 Message-Id: <1409319124-31716-1-git-send-email-naszar@ya.ru> From: naszar When mount entry contains only four fields and have more then one space or tab at the and, mp.mnt_freq and mp.mnt_passno will be set to some specific values as side effect from parsing of previus mount entry. It is because sscanf(""," %d %d ", &a, &b) returns -1, but this case is unprocessed. Values of mp.mnt_freq and mp.mnt_passno stays unchanged. This patch is attempt to fix described issue by removing trailing tabs and spaces. [BZ 17273] *misc/mntent_r.c: fix incorrect mount table entry parsing --- misc/mntent_r.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/misc/mntent_r.c b/misc/mntent_r.c index e68ec8e..e0a0b9d 100644 --- a/misc/mntent_r.c +++ b/misc/mntent_r.c @@ -135,7 +135,11 @@ __getmntent_r (FILE *stream, struct mntent *mp, char *buffer, int bufsiz) end_ptr = strchr (buffer, '\n'); if (end_ptr != NULL) /* chop newline */ - *end_ptr = '\0'; + { + while (end_ptr[-1] == ' ' || end_ptr[-1] == '\t') + end_ptr--; + *end_ptr = '\0'; + } else { /* Not the whole line was read. Do it now but forget it. */