From patchwork Tue Apr 1 11:32:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Newton X-Patchwork-Id: 369 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 693BE3600D9 for ; Tue, 1 Apr 2014 04:33:10 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14307373) id 28410622268BD; Tue, 1 Apr 2014 04:33:10 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 003E26222A809 for ; Tue, 1 Apr 2014 04:33:09 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=O/UZKug1NYbcHydQHwhRP4fNcbbP4C0 EaN0ukycZ1TucmjsHJIl+lJNuQqxu0DeCBubpq516L2EziRgNOiuvsGG/lonX+jF eGifY7uQnRp0e65e8AkNOTEUyVS0gMdeV8qxiP7hTLPsT22cuJ5rb46ON4IYFSby CJPSZY8YDs7c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=cNb+v5g56XNytK/TXWKJcd3qBwQ=; b=COTVU /FMIyhKECYhH2wHxJq1pMDdKIIpx8QcJPJZfiLIwxth66SvO7lfZvLV8anJCDbU9 DC2qYcznoPBa6uU16IJ8+lvcJhPltl3T9o5zvwAoO9xtW1cPAvXt+6WPX0IFuRSm 9qVqs+Lw3SgbDYJE8TfEtzdS6Pf7sZHE4bCwZ4= Received: (qmail 4888 invoked by alias); 1 Apr 2014 11:32:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 4863 invoked by uid 89); 1 Apr 2014 11:32:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f172.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=X+ZAcWayetkDz0kM+uNP+Z4PPECrMZ0UqdBd9knz+gY=; b=bmOFxxfxo52PUvnWyAdQ5jKrX6QHrZ7e6YtkF4VTqQWKG1OeeNJQSLTjQlc93dsgiN QKp8TVasJiSyigLlLMSsu/pazhqEaMlQU0HYizLHO9OyN33r8nd6OA03Dv/deCc81oSr Ru3y219hNnyd4cAywjKEZpRnH9L75QMCCRPbMlSkkg023PDGGAfHrq/lcWFWaBQlDYDl QBUqRtWEQVgWjXTIFu9R67yHLRiqMGAmf0WYu2nQ7e40hM6V99Oj6nEA8ugf3ulTE/R1 3Mx2V7GGstcDRPqq5Uz1+EJqmgap6mcYCaYyf1s9oWe7fzlq1oH92nl7nHPhdfl4kKS0 4OMA== X-Gm-Message-State: ALoCoQnakNEPlTL2vFrwH1n73Cr8zSZo4A4BzEUfxeB0Z/apSNTe6MGtzBhtYUySGGibi6HCxh/i X-Received: by 10.194.59.43 with SMTP id w11mr13247537wjq.65.1396351973933; Tue, 01 Apr 2014 04:32:53 -0700 (PDT) From: Will Newton To: libc-alpha@sourceware.org Subject: [PATCH v2 2/3] stdlib/tst-setcontext.c: Check for clobbering of signal stack Date: Tue, 1 Apr 2014 12:32:46 +0100 Message-Id: <1396351967-1952-2-git-send-email-will.newton@linaro.org> In-Reply-To: <1396351967-1952-1-git-send-email-will.newton@linaro.org> References: <1396351967-1952-1-git-send-email-will.newton@linaro.org> X-DH-Original-To: glibc@patchwork.siddhesh.in On aarch64 calling swapcontext clobbers the state of the signal stack (BZ #16629). Check that the address and size of the signal stack before and after the call to swapcontext remains the same. ChangeLog: 2014-04-01 Will Newton [BZ #16629] * stdlib/tst-setcontext.c: Include signal.h. (main): Check that the signal stack before and after swapcontext is the same. --- stdlib/tst-setcontext.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) Changes in v2: - Fixed changelog bug reference diff --git a/stdlib/tst-setcontext.c b/stdlib/tst-setcontext.c index ac9deb1..55984a4 100644 --- a/stdlib/tst-setcontext.c +++ b/stdlib/tst-setcontext.c @@ -16,6 +16,7 @@ . */ #include +#include #include #include #include @@ -144,6 +145,9 @@ main (void) atexit (check_called); char st1[32768]; + stack_t stack_before, stack_after; + + sigaltstack(NULL, &stack_before); puts ("making contexts"); if (getcontext (&ctx[1]) != 0) @@ -207,6 +211,8 @@ main (void) puts ("back at main program"); back_in_main = 1; + sigaltstack(NULL, &stack_after); + if (was_in_f1 == 0) { puts ("didn't reach f1"); @@ -218,6 +224,21 @@ main (void) exit (1); } + /* Check sigaltstack state is not clobbered as in BZ #16629. */ + if (stack_before.ss_sp != stack_after.ss_sp) + { + printf ("stack ss_sp mismatch: %p %p\n", + stack_before.ss_sp, stack_after.ss_sp); + exit (1); + } + + if (stack_before.ss_size != stack_after.ss_size) + { + printf ("stack ss_size mismatch: %zd %zd\n", + stack_before.ss_size, stack_after.ss_size); + exit (1); + } + puts ("test succeeded"); return 0; }