From patchwork Thu Mar 13 10:45:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Newton X-Patchwork-Id: 67 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (caibbdcaaahb.dreamhost.com [208.113.200.71]) by wilcox.dreamhost.com (Postfix) with ESMTP id EB0F23600CD for ; Thu, 13 Mar 2014 03:46:15 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14307373) id 9832D1E86C7B; Thu, 13 Mar 2014 03:46:15 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 6BBDD1E86C43 for ; Thu, 13 Mar 2014 03:46:15 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=eU+oePQWT4croIhHu0v4i2h2doH/5tE 9PEARjiNUqjEaf/JOcfmFmAGxaRDKa+HUDOoiwY031HSKIASE+4fKMWjSG3Khz3U EEVt80hcqFTu557AWDsHl5YLdsM6/LHcImDTK5WEhN2XaCHyEdM2IooTiee7GcD+ gX8oLJcOXY5c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=7TgEXN7e8QBPFM/z5W9xf3H6Psk=; b=ZumP+ u6621hNlFg0wvPxrlhhuEbwSv4ywgrk6IqT9QrOLQbjK6WjB1s9QB6o0pSDFZbJL P+66vL/l0akLwcwbGGnXUFzAWsol3p5DnD6qQOtDCRH53lNhhwGGSLo/e/96nTKd zgWE2yiJcBowb4fxB1NyGeTHBi6hnkdDb/3bPA= Received: (qmail 29164 invoked by alias); 13 Mar 2014 10:45:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 29100 invoked by uid 89); 13 Mar 2014 10:45:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f169.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=ORd31wmEcs/C8387wMT1rOj3UlchpQGSuCObFfh/HMI=; b=XpkO3xHcfzUgha8KjG/a8bks/QWY/2OQfPjxtZAAr36cB5643j/Wi+oU2kWdyK7y++ v5ioZopSr6E3TXf1s2k26N9vg2PSe7h325Lc/di6Zw8xy3gSKlyOAO+EQKPEUDRY6L9t FjXb32V5AxMnvKhXgHO1MVtYP6wQuF9pzfBtpybeEufJkONU8JR91TjXvP4wbnW/qNc7 CQi+SICSOD2WX57xQ74/IQdva53JhhCwxTSq2XC/4rQwJrntFwwuh8iXannKJXusPT0r jqa/eqaotrkue6VheUEltI8C3Vhd6eOHmR4B40eALOuQjIq7dp3/810ugHiKzGB0cAVO oE1g== X-Gm-Message-State: ALoCoQkwbrvMABP4QmcVZKaCQFOrTZszr3HRh6PxVPzT+WbXSCalOXBwemi1/hTBzXxMMc9Sl+Oi X-Received: by 10.180.100.103 with SMTP id ex7mr1059587wib.24.1394707551749; Thu, 13 Mar 2014 03:45:51 -0700 (PDT) From: Will Newton To: libc-alpha@sourceware.org Subject: [PATCH 3/4] stdlib/tst-setcontext.c: Check for clobbering of signal stack Date: Thu, 13 Mar 2014 10:45:42 +0000 Message-Id: <1394707543-9690-3-git-send-email-will.newton@linaro.org> In-Reply-To: <1394707543-9690-1-git-send-email-will.newton@linaro.org> References: <1394707543-9690-1-git-send-email-will.newton@linaro.org> X-DH-Original-To: glibc@patchwork.siddhesh.in On aarch64 calling swapcontext clobbers the state of the signal stack (BZ #16629). Check that the address and size of the signal stack before and after the call to swapcontext remains the same. ChangeLog: 2014-03-13 Will Newton * stdlib/tst-setcontext.c: Include signal.h. (main): Check that the signal stack before and after swapcontext is the same (BZ #16629). --- stdlib/tst-setcontext.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/stdlib/tst-setcontext.c b/stdlib/tst-setcontext.c index ac9deb1..55984a4 100644 --- a/stdlib/tst-setcontext.c +++ b/stdlib/tst-setcontext.c @@ -16,6 +16,7 @@ . */ #include +#include #include #include #include @@ -144,6 +145,9 @@ main (void) atexit (check_called); char st1[32768]; + stack_t stack_before, stack_after; + + sigaltstack(NULL, &stack_before); puts ("making contexts"); if (getcontext (&ctx[1]) != 0) @@ -207,6 +211,8 @@ main (void) puts ("back at main program"); back_in_main = 1; + sigaltstack(NULL, &stack_after); + if (was_in_f1 == 0) { puts ("didn't reach f1"); @@ -218,6 +224,21 @@ main (void) exit (1); } + /* Check sigaltstack state is not clobbered as in BZ #16629. */ + if (stack_before.ss_sp != stack_after.ss_sp) + { + printf ("stack ss_sp mismatch: %p %p\n", + stack_before.ss_sp, stack_after.ss_sp); + exit (1); + } + + if (stack_before.ss_size != stack_after.ss_size) + { + printf ("stack ss_size mismatch: %zd %zd\n", + stack_before.ss_size, stack_after.ss_size); + exit (1); + } + puts ("test succeeded"); return 0; }