From patchwork Mon Aug 15 08:07:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 14577 Received: (qmail 89246 invoked by alias); 15 Aug 2016 08:07:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 89237 invoked by uid 89); 15 Aug 2016 08:07:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_SEMBACKSCATTER, URIBL_RED autolearn=no version=3.3.2 spammy=succeeding, H*m:linux, Lesser, UD:fenv_libc.h X-HELO: mx0a-001b2d01.pphosted.com X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: stli@linux.vnet.ibm.com X-IBM-RcptTo: libc-alpha@sourceware.org Subject: Re: [10/12] Add fesetexcept: s390 To: libc-alpha@sourceware.org References: From: Stefan Liebler Date: Mon, 15 Aug 2016 10:07:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081508-0008-0000-0000-000002B1E563 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081508-0009-0000-0000-00001973FE5E Message-Id: <0b8092e6-1be4-8953-dbdd-77922469a5b2@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-15_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=4 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608150098 On 08/11/2016 11:03 PM, Joseph Myers wrote: > This patch adds an S/390 version of fesetexcept. Untested. > > 2016-08-11 Joseph Myers > > * sysdeps/s390/fpu/fesetexcept.c: New file. > > diff --git a/sysdeps/s390/fpu/fesetexcept.c b/sysdeps/s390/fpu/fesetexcept.c > new file mode 100644 > index 0000000..4728f3e > --- /dev/null > +++ b/sysdeps/s390/fpu/fesetexcept.c > @@ -0,0 +1,32 @@ > +/* Set given exception flags. S/390 version. > + Copyright (C) 2016 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > + > +int > +fesetexcept (int excepts) > +{ > + fexcept_t temp, newexcepts; > + > + _FPU_GETCW (temp); > + temp |= (excepts & FE_ALL_EXCEPT) << FPC_FLAGS_SHIFT; > + _FPU_SETCW (temp); > + > + return 0; > +} > Hi Joseph, the macro FPC_FLAGS_SHIFT is defined in fenv_libc.h, which is not included. The variable newexcepts is unused. See diff below. Afterwards the new tests are succeeding on s390x / s390. Thanks. Stefan diff --git a/sysdeps/s390/fpu/fesetexcept.c b/sysdeps/s390/fpu/fesetexcept.c index 4728f3e..e875f13 100644 --- a/sysdeps/s390/fpu/fesetexcept.c +++ b/sysdeps/s390/fpu/fesetexcept.c @@ -18,11 +18,12 @@ #include #include +#include int fesetexcept (int excepts) { - fexcept_t temp, newexcepts; + fexcept_t temp; _FPU_GETCW (temp); temp |= (excepts & FE_ALL_EXCEPT) << FPC_FLAGS_SHIFT;