Message ID | 093b5b96-00cb-cc87-e3b1-56f3fa6b3f0d@redhat.com |
---|---|
State | Committed |
Headers |
Received: (qmail 72856 invoked by alias); 15 Aug 2017 12:27:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 123564 invoked by uid 89); 15 Aug 2017 12:25:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5EB5F2C96DE Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer@redhat.com Subject: Re: [PATCH] i386: Replace internal_function attribute for __mcount_internal To: "H.J. Lu" <hjl.tools@gmail.com> Cc: GNU C Library <libc-alpha@sourceware.org> References: <54445c79-cdb6-27a0-5704-d13e8f888f91@redhat.com> <d2fcbeb3-2f6e-5e1c-f07f-04f850bceb40@redhat.com> <CAMe9rOrrkYikoDP7E8GProFScALiDpLgv57DPyxQqnZ9XLWvOQ@mail.gmail.com> From: Florian Weimer <fweimer@redhat.com> Message-ID: <093b5b96-00cb-cc87-e3b1-56f3fa6b3f0d@redhat.com> Date: Tue, 15 Aug 2017 14:25:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <CAMe9rOrrkYikoDP7E8GProFScALiDpLgv57DPyxQqnZ9XLWvOQ@mail.gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit |
Commit Message
Florian Weimer
Aug. 15, 2017, 12:25 p.m. UTC
On 08/15/2017 02:19 PM, H.J. Lu wrote: > On Tue, Aug 15, 2017 at 5:08 AM, Florian Weimer <fweimer@redhat.com> wrote: >> With the separate test patch I posted ([PATCH] Test for profiling >> support (_mcount/gprof)), is this now okay to commit? >> > > Does the new test fail without the __mcount_internal patch? Yes, it does. The executable does not generate any profiling data: $ cat gmon/tst-gmon-gprof.out FAIL Florian
Comments
On Tue, Aug 15, 2017 at 5:25 AM, Florian Weimer <fweimer@redhat.com> wrote: > On 08/15/2017 02:19 PM, H.J. Lu wrote: >> On Tue, Aug 15, 2017 at 5:08 AM, Florian Weimer <fweimer@redhat.com> wrote: >>> With the separate test patch I posted ([PATCH] Test for profiling >>> support (_mcount/gprof)), is this now okay to commit? >>> >> >> Does the new test fail without the __mcount_internal patch? > > Yes, it does. The executable does not generate any profiling data: > Great. The patch is OK. Thanks.
--- expected +++ actual @@ -1,2 +0,0 @@ -f1 2000 -f2 1000