Aarch64 : Remove ISB after FPCR write

Message ID 000d01cf769a$04fd6430$0ef82c90$@com
State Committed
Headers

Commit Message

Wilco Dijkstra May 23, 2014, 3:16 p.m. UTC
  Hi,

This patch removes ISB after FPCR writes as it is no longer required by the architecture.

OK?

Wilco

ChangeLog:
2014-05-23  Wilco  <wdijkstr@arm.com>

	* sysdeps/aarch64/fpu/fpu_control.h: Remove ISB after FPCR write.
---
 sysdeps/aarch64/fpu/fpu_control.h | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
  

Comments

Marcus Shawcroft June 2, 2014, 11:45 a.m. UTC | #1
On 23 May 2014 16:16, Wilco <wdijkstr@arm.com> wrote:
> Hi,
>
> This patch removes ISB after FPCR writes as it is no longer required by the architecture.
>
> OK?
>
> Wilco
>
> ChangeLog:
> 2014-05-23  Wilco  <wdijkstr@arm.com>
>
>         * sysdeps/aarch64/fpu/fpu_control.h: Remove ISB after FPCR write.

OK and committed with ChangeLog updated to say:

+ * sysdeps/aarch64/fpu/fpu_control.h (_FPU_SETCW): Remove ISB after
+ FPCR write.

/Marcus
  

Patch

diff --git a/sysdeps/aarch64/fpu/fpu_control.h b/sysdeps/aarch64/fpu/fpu_control.h
index 6a265e8..d5a890d 100644
--- a/sysdeps/aarch64/fpu/fpu_control.h
+++ b/sysdeps/aarch64/fpu/fpu_control.h
@@ -24,11 +24,8 @@ 
 #define _FPU_GETCW(fpcr) \
   __asm__ __volatile__ ("mrs	%0, fpcr" : "=r" (fpcr))
 
-#define _FPU_SETCW(fpcr)				   \
-  {							   \
-    __asm__ __volatile__ ("msr	fpcr, %0" : : "r" (fpcr)); \
-    __asm__ __volatile__ ("isb");			   \
-  }
+#define _FPU_SETCW(fpcr) \
+  __asm__ __volatile__ ("msr	fpcr, %0" : : "r" (fpcr))
 
 #define _FPU_GETFPSR(fpsr) \
   __asm__ __volatile__ ("mrs	%0, fpsr" : "=r" (fpsr))