From patchwork Mon Jun 21 09:14:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 43927 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 537AC3896C12 for ; Mon, 21 Jun 2021 09:14:39 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from fossa.birch.relay.mailchannels.net (fossa.birch.relay.mailchannels.net [23.83.209.62]) by sourceware.org (Postfix) with ESMTPS id B5584383F422 for ; Mon, 21 Jun 2021 09:14:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5584383F422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DFC97341F19 for ; Mon, 21 Jun 2021 09:14:24 +0000 (UTC) Received: from pdx1-sub0-mail-a91.g.dreamhost.com (100-96-133-115.trex.outbound.svc.cluster.local [100.96.133.115]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7054E34205A for ; Mon, 21 Jun 2021 09:14:24 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a91.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.133.115 (trex/6.3.3); Mon, 21 Jun 2021 09:14:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Hook-Suffer: 44219ac6211f529b_1624266864697_2769153265 X-MC-Loop-Signature: 1624266864697:2155803176 X-MC-Ingress-Time: 1624266864696 Received: from pdx1-sub0-mail-a91.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a91.g.dreamhost.com (Postfix) with ESMTP id 234FD7E6CF for ; Mon, 21 Jun 2021 02:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=8LZiAo jyrAj9ZavoB58CIrmTy1M=; b=J06CGk1HOadcJfTM/6ZtgWtDlUEOEM5E0rvg1q kOye+ULEjECMtgqYdF4KDjLYNWokMlBqX8tmU5VGTVk/rnti+WexocBFULfbIK0A 2N51TaUCDc/UD6maNVNjfR5jwESNc1GcBb6MrQ/7MX3kt0jeeyrbJ1LO5XGELeNg MJASE= Received: from [192.168.1.128] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a91.g.dreamhost.com (Postfix) with ESMTPSA id 42A5D7E67B for ; Mon, 21 Jun 2021 02:14:22 -0700 (PDT) Subject: [Ping 2][PATCH 0/6] gconv configuration parsing cleanups To: libc-alpha@sourceware.org References: <20210610111853.2286873-1-siddhesh@sourceware.org> X-DH-BACKEND: pdx1-sub0-mail-a91 From: Siddhesh Poyarekar Message-ID: Date: Mon, 21 Jun 2021 14:44:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210610111853.2286873-1-siddhesh@sourceware.org> Content-Language: en-US X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Ping2! Andreas has reviewed 2/6 but I still need review for 1/6 and {3,4,5}/6. Thanks, Siddhesh On 6/10/21 4:48 PM, Siddhesh Poyarekar via Libc-alpha wrote: > This patchset consolidates the file parsing in gconv_conf and > iconvconfig into a single file gconv_parseconfdir. Also, add a NEWS > item to mention gconv-modules.d since it is a user visible change. > > Siddhesh Poyarekar (6): > iconv: Remove alloca use in gconv-modules configuration parsing > gconv_conf: Remove unused variables > gconv_conf: Split out configuration file processing > iconvconfig: Use common gconv module parsing function > Handle DT_UNKNOWN in gconv-modules.d > Add NEWS item for gconv-modules.d change > > NEWS | 6 ++ > iconv/gconv_conf.c | 137 ++---------------------------- > iconv/gconv_parseconfdir.h | 170 +++++++++++++++++++++++++++++++++++++ > iconv/iconvconfig.c | 119 +++----------------------- > 4 files changed, 195 insertions(+), 237 deletions(-) > create mode 100644 iconv/gconv_parseconfdir.h >