Message ID | ee49b35a-0bd1-233b-3fb7-c0b55d44fe8c@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <libc-alpha-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9EFA33858C39 for <patchwork@sourceware.org>; Tue, 14 Jan 2025 02:04:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EFA33858C39 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=e1QwO/cu X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 27CC33857B8C for <libc-alpha@sourceware.org>; Tue, 14 Jan 2025 02:01:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27CC33857B8C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 27CC33857B8C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736820108; cv=none; b=K2TDc62rYqRpQnibXlse8cH3CrQym7aqP88JqeawGCmHeBO0hXFEUoCeHC6GOhskVrWfVhy7HiBfsP2JUy2eFkYGwwuBPhCP/CFKk5CovvtD7jAEp31ZFGZwkRvMzQFq8cFIbx4TKiOwVPkxUskViNyySEP/n0B0XMdc8DEeq04= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736820108; c=relaxed/simple; bh=vh/ulCqP3KEXM+albfvJbjP5cITXahGmbOTJhYcRBPM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=QxdZAlhFhYeaOGw76JdzmxW6F8w5lQ1JMcxa/V7TdD0pvuAeLAFvBWSfXl39ktwqfO8QuKGpb/5w7SFzvyEX20S4KDJm5XtDloBpzOAgSA7l0vWgv2QpZfzQ1nFtCMxUQ1dGw0UtiP3mMvZ1bIV7ypVlFbhzKb2vFqswlj97vjw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 27CC33857B8C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736820107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=td4XZrQYloaBFAUWb0Z/jubX1Znx8FMXlTxRL8UOzHs=; b=e1QwO/cuO7UgSpR8Smj9YLNTu3lX4gvuUbjoV2ytJVHymFAtDuz/2639CW1na8loFgmJCO ye3ejBn5sDU/9cRoK8659Ig/MmMRhYEhVGQpJQt04RJ16I1HD2kzORgx8k1A+I27v6dodJ YT0kQcF0yXlTPZfSOzGB54E0Lgpx9ZM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-XRHrWSUWNCCPxDpSijiP9g-1; Mon, 13 Jan 2025 21:01:45 -0500 X-MC-Unique: XRHrWSUWNCCPxDpSijiP9g-1 X-Mimecast-MFC-AGG-ID: XRHrWSUWNCCPxDpSijiP9g Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361ac607b6so38367735e9.0 for <libc-alpha@sourceware.org>; Mon, 13 Jan 2025 18:01:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736820104; x=1737424904; h=mime-version:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=td4XZrQYloaBFAUWb0Z/jubX1Znx8FMXlTxRL8UOzHs=; b=EnTWkmyS0wuP0UkS5vieQJ6or0s8/ZrsUmzm9R8m8wTX4CvTK+tl8Goi+wlYWZZg8a XTXHpWFY8LWsoGX2r4uA24pgPDe0Min25SRYx0+/5CQsOFRfmd2t4jVrZkcRFyaa2DoF xOHVuP67mm3aTD5isPYUoWHH/bSTKtMqNdkva2UGkAo3FWw3M2Bdj6zhUKBN8az9CWTI ED1sZEpxg4Z/ZYxTaPTcjxAGSO8s/kdcs5i7i1u0+1RV4GBX3xszmPTmZvN0kAvrkB0R lGnbiuh5M1q83v9pj96GmrNbJBKj3Hlpe/J1+4NEk0pX8iWCNb5vnCpTaMQS263DWpfK aB9w== X-Gm-Message-State: AOJu0YzP9qU37wpvri09O6N31HLRqiQsILbpijdn9W1l8un58grBVCn9 kt1a+KKqN6s559PypsisByrszSoVTmLDyNc/oXv11dzrp3rvhZST2SpQCSNFJhux0Q79IPvq/uD 7XgRhQyihXd2jEvrZchm12kq0FgPdGAH1bNEfwR/lPUY40vRI+lWXr9vw/Jx1aSznlBjYHH9idV 0nxE7xh6jqbXDttuxoqYcgXmRo4+p89bYd3F/M5PZeVw== X-Gm-Gg: ASbGncuZAMaxRSTJ7WjA8H5Sjqlgtf5rJDAG6xnmNEOGWTSog667AfQXsKBspCj9Lup eZLJzLyEaXX/3Si8RqYTB3EanPwc4rcVZLb8yPaMvXsO06XESmumDkRrdc6tWjAquhN5C0XYQZo u6+SFyMKV4HfrTMNEyYxy1Fowf8ZzdXd8uMakFu6XVCCbIQT/3Cl3v2suQAAYNtPrb/jPGy4EBX KPzNbKNE8a1sRsqvT1Xn+MkvGOZTcvPtIkP0AqYL0AOjM4EIfSq986iSm09Zmczc6kzQVoUlY1m mMMGffZhMw1A X-Received: by 2002:a05:600c:4f06:b0:431:12a8:7f1a with SMTP id 5b1f17b1804b1-436e26d018emr248611485e9.16.1736820104001; Mon, 13 Jan 2025 18:01:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqU8FaThwAAzV3BDEyW+dcH+CVFEIYj85bUqXrAu5L9w4yEQyvW5ktVPMF5VR42EOBHeHveg== X-Received: by 2002:a05:600c:4f06:b0:431:12a8:7f1a with SMTP id 5b1f17b1804b1-436e26d018emr248611225e9.16.1736820103533; Mon, 13 Jan 2025 18:01:43 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2df2faesm195199095e9.26.2025.01.13.18.01.42 for <libc-alpha@sourceware.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 18:01:43 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.97) (envelope-from <josmyers@redhat.com>) id 1tXWEi-0000000CveG-2sng for libc-alpha@sourceware.org; Tue, 14 Jan 2025 02:00:56 +0000 Date: Tue, 14 Jan 2025 02:00:56 +0000 (UTC) From: Joseph Myers <josmyers@redhat.com> To: libc-alpha@sourceware.org Subject: [PATCH 0/6] Fix issues around flushing and file offsets for input files Message-ID: <ee49b35a-0bd1-233b-3fb7-c0b55d44fe8c@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hz9znSyLch-7DpjJNJTa8EwXUwjlIU_3Jl76loKHysk_1736820104 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org |
Series |
Fix issues around flushing and file offsets for input files
|
|
Message
Joseph Myers
Jan. 14, 2025, 2 a.m. UTC
There are several open bugs relating to flushing of FILE* streams (with fflush and other operations) and their offsets (both the file position indicator in the FILE*, and the offset in the underlying open file description), especially after ungetc but not limited to that case. Fix five such bugs. Each has its own fix with associated test specific to that bug; at the end of the patch series, add a test that more systematically covers different combinations of cases for such issues, with 25664 separate scenarios tested (which include examples of all the five separate fixed bugs), all of which pass given the five previous bug fixes. (None of the patches do anything about the case of the "old" FILE structure, where that uses separate function implementations.) It's likely most of the patches would work on their own or with only a subset of the previous patches rather than having strict dependencies, though they haven't been tested that way (but can be retested like that if approved out of order). In any case, these patches should wait until after the 2.41 release to go in. (Note in particular that the fix for bug 12724 may be high risk; a previous attempt was made to fix that bug and subsequently reverted because it caused problems.)