mbox series

[0/2] Fix incorrect stub warnings after generic refactor

Message ID cover.1671451274.git.fweimer@redhat.com
Headers
Series Fix incorrect stub warnings after generic refactor |

Message

Florian Weimer Dec. 19, 2022, 12:03 p.m. UTC 
  They cause link failures with -Wl,--fatal-warnings on aarch64.

Tested on aarch64-linux-gnu, i686-linux-gnu, x86_64-linux-gnu.  Manually
verified that the warnings are gone on aarch64-linux-gnu.

Florian Weimer (2):
  Linux: Reflow and sort some Makefile variables
  Linux: Remove epoll_create, inotify_init from syscalls.list

 sysdeps/unix/sysv/linux/Makefile      | 220 ++++++++++++++++++--------
 sysdeps/unix/sysv/linux/syscalls.list |   2 -
 2 files changed, 157 insertions(+), 65 deletions(-)


base-commit: 0fb10e49ad169374650534509767ec1d4232e230

Comments

Adhemerval Zanella Netto Dec. 19, 2022, 12:16 p.m. UTC | #1 
On 19/12/22 09:03, Florian Weimer wrote:
> They cause link failures with -Wl,--fatal-warnings on aarch64.
> 

Would be possible to use this option as default to catch such errors?

> Tested on aarch64-linux-gnu, i686-linux-gnu, x86_64-linux-gnu.  Manually
> verified that the warnings are gone on aarch64-linux-gnu.
> 
> Florian Weimer (2):
>   Linux: Reflow and sort some Makefile variables
>   Linux: Remove epoll_create, inotify_init from syscalls.list
> 
>  sysdeps/unix/sysv/linux/Makefile      | 220 ++++++++++++++++++--------
>  sysdeps/unix/sysv/linux/syscalls.list |   2 -
>  2 files changed, 157 insertions(+), 65 deletions(-)
> 
> 
> base-commit: 0fb10e49ad169374650534509767ec1d4232e230
Florian Weimer Dec. 19, 2022, 12:27 p.m. UTC | #2 
* Adhemerval Zanella Netto:

> On 19/12/22 09:03, Florian Weimer wrote:
>> They cause link failures with -Wl,--fatal-warnings on aarch64.
>> 
>
> Would be possible to use this option as default to catch such errors?

We'd have to make it conditional because tests for mktemp and the like
do result in warnings.  We also do not have an inotify test, but in this
particular case, maybe the nscd build would have caught it.

Thanks,
Florian