From patchwork Thu Aug 18 08:53:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 55096 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F7703858C2D for ; Thu, 18 Aug 2022 08:53:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F7703858C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1660812830; bh=nxJY5aHDu9qa4NzF/6pph5tLw/o4cv8INdvqDWpRbbc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vXfZI0V7QxZCDHwr92P9PNn5esp1BMqrKgU5i33jvTx2iqo7+EEA3O2gKsjOXHTt9 myp0L+3pK8nsH5EHz6LPtxrlJrs/gpkV8ZPkP3gpSg5IootMiYQOUP/iYH0ZAclTMc +rrMgJhYuvsuvrQgdEHP2s2n0VkNq6dRGs2zi5uE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D99BC3858D39 for ; Thu, 18 Aug 2022 08:53:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D99BC3858D39 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-a1vjHxzWM7ekGIQw32GYMg-1; Thu, 18 Aug 2022 04:53:22 -0400 X-MC-Unique: a1vjHxzWM7ekGIQw32GYMg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0C26A18A0171 for ; Thu, 18 Aug 2022 08:53:21 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 35A34C15BBA for ; Thu, 18 Aug 2022 08:53:20 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH v4 00/11] vfprintf refactor X-From-Line: 80c378d478114bc981857d948c2c784f1184702c Mon Sep 17 00:00:00 2001 Message-Id: Date: Thu, 18 Aug 2022 10:53:18 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Mostly unchanged. I removed a VLA from printf callback invocation, and stopped using mempcpy. Tested on i686-linux-gnu and x86_64-linux-gnu. Thanks, Florian Florian Weimer (11): locale: Implement struct grouping_iterator stdio-common: Introduce buffers for implementing printf stdio-common: Add __printf_function_invoke stdio-common: Add __translated_number_width stdio-common: Convert vfprintf and related functions to buffers stdio-common: Add lock optimization to vfprintf and vfwprintf libio: Convert __vsprintf_internal to buffers libio: Convert __vasprintf_internal to buffers libio: Convert __vdprintf_internal to buffers libio: Convert __obstack_vprintf_internal to buffers (bug 27124) libio: Convert __vswprintf_internal to buffers (bug 27857) elf/Makefile | 1 - include/printf.h | 52 +- include/printf_buffer.h | 332 ++++++++ libio/iovdprintf.c | 69 +- libio/iovsprintf.c | 70 +- libio/obprintf.c | 170 ++-- libio/tst-vtables-common.c | 9 +- libio/tst_swprintf.c | 31 +- libio/vasprintf.c | 141 ++-- libio/vsnprintf.c | 131 ++-- libio/vswprintf.c | 100 +-- manual/stdio.texi | 7 +- stdio-common/Makefile | 28 +- stdio-common/Xprintf_buffer_done.c | 40 + stdio-common/Xprintf_buffer_flush.c | 72 ++ stdio-common/Xprintf_buffer_pad_1.c | 44 ++ stdio-common/Xprintf_buffer_putc_1.c | 29 + stdio-common/Xprintf_buffer_puts_1.c | 38 + stdio-common/Xprintf_buffer_write.c | 44 ++ stdio-common/Xprintf_function_invoke.c | 58 ++ stdio-common/grouping_iterator.c | 126 +++ stdio-common/grouping_iterator.h | 65 ++ stdio-common/printf_buffer-char.h | 24 + stdio-common/printf_buffer-wchar_t.h | 24 + stdio-common/printf_buffer_as_file.c | 148 ++++ stdio-common/printf_buffer_as_file.h | 87 +++ stdio-common/printf_buffer_done.c | 21 + stdio-common/printf_buffer_flush.c | 81 ++ stdio-common/printf_buffer_pad_1.c | 21 + stdio-common/printf_buffer_putc_1.c | 21 + stdio-common/printf_buffer_puts_1.c | 21 + stdio-common/printf_buffer_to_file.c | 122 +++ stdio-common/printf_buffer_to_file.h | 57 ++ stdio-common/printf_buffer_write.c | 21 + stdio-common/printf_fp.c | 736 ++++++++---------- stdio-common/printf_fphex.c | 260 +++---- stdio-common/printf_function_invoke.c | 22 + stdio-common/translated_number_width.c | 42 + stdio-common/tst-grouping_iterator.c | 262 +++++++ stdio-common/vfprintf-internal.c | 672 +++++----------- stdio-common/vfprintf-process-arg.c | 172 ++-- stdio-common/wprintf_buffer_as_file.c | 153 ++++ stdio-common/wprintf_buffer_done.c | 21 + stdio-common/wprintf_buffer_flush.c | 42 + stdio-common/wprintf_buffer_pad_1.c | 21 + stdio-common/wprintf_buffer_putc_1.c | 21 + stdio-common/wprintf_buffer_puts_1.c | 21 + stdio-common/wprintf_buffer_to_file.c | 55 ++ stdio-common/wprintf_buffer_write.c | 21 + stdio-common/wprintf_function_invoke.c | 22 + stdlib/strfmon_l.c | 196 ++--- stdlib/strfrom-skeleton.c | 38 +- sysdeps/ia64/fpu/printf_fphex.c | 8 +- .../ieee754/ldbl-128/printf_fphex_macros.h | 36 +- sysdeps/ieee754/ldbl-128ibm/printf_fphex.c | 36 +- sysdeps/ieee754/ldbl-96/printf_fphex.c | 22 +- sysdeps/x86_64/fpu/printf_fphex.c | 21 +- 57 files changed, 3395 insertions(+), 1810 deletions(-) create mode 100644 include/printf_buffer.h create mode 100644 stdio-common/Xprintf_buffer_done.c create mode 100644 stdio-common/Xprintf_buffer_flush.c create mode 100644 stdio-common/Xprintf_buffer_pad_1.c create mode 100644 stdio-common/Xprintf_buffer_putc_1.c create mode 100644 stdio-common/Xprintf_buffer_puts_1.c create mode 100644 stdio-common/Xprintf_buffer_write.c create mode 100644 stdio-common/Xprintf_function_invoke.c create mode 100644 stdio-common/grouping_iterator.c create mode 100644 stdio-common/grouping_iterator.h create mode 100644 stdio-common/printf_buffer-char.h create mode 100644 stdio-common/printf_buffer-wchar_t.h create mode 100644 stdio-common/printf_buffer_as_file.c create mode 100644 stdio-common/printf_buffer_as_file.h create mode 100644 stdio-common/printf_buffer_done.c create mode 100644 stdio-common/printf_buffer_flush.c create mode 100644 stdio-common/printf_buffer_pad_1.c create mode 100644 stdio-common/printf_buffer_putc_1.c create mode 100644 stdio-common/printf_buffer_puts_1.c create mode 100644 stdio-common/printf_buffer_to_file.c create mode 100644 stdio-common/printf_buffer_to_file.h create mode 100644 stdio-common/printf_buffer_write.c create mode 100644 stdio-common/printf_function_invoke.c create mode 100644 stdio-common/translated_number_width.c create mode 100644 stdio-common/tst-grouping_iterator.c create mode 100644 stdio-common/wprintf_buffer_as_file.c create mode 100644 stdio-common/wprintf_buffer_done.c create mode 100644 stdio-common/wprintf_buffer_flush.c create mode 100644 stdio-common/wprintf_buffer_pad_1.c create mode 100644 stdio-common/wprintf_buffer_putc_1.c create mode 100644 stdio-common/wprintf_buffer_puts_1.c create mode 100644 stdio-common/wprintf_buffer_to_file.c create mode 100644 stdio-common/wprintf_buffer_write.c create mode 100644 stdio-common/wprintf_function_invoke.c base-commit: 1d7829991112ac32c28bc6e3c4f1695125c1aa44