mbox series

[v2,0/6] Reliable CPU compatibility diagnostics in ld.so

Message ID cover.1642179009.git.fweimer@redhat.com
Headers
Series Reliable CPU compatibility diagnostics in ld.so |

Message

Florian Weimer Jan. 14, 2022, 4:51 p.m. UTC 
  v2: Rebased after the first two patches went.  New first patch to reflow
elf/Makefile.  configure option has been renamed.

Florian Weimer (6):
  elf/Makefile: Reflow and sort most variable assignments
  elf: Split dl-printf.c from dl-misc.c
  Add --with-rtld-early-cflags configure option
  powerpc64le: Use <gcc-macros.h> in early HWCAP check
  x86: Add x86-64-vN check to early startup
  s390x: Use <gcc-macros.h> in early HWCAP check

 INSTALL                                       |   8 +
 config.make.in                                |   1 +
 configure                                     |  13 +
 configure.ac                                  |   6 +
 elf/Makefile                                  | 429 +++++++++++++-----
 elf/dl-misc.c                                 | 281 +-----------
 elf/dl-printf.c                               | 292 ++++++++++++
 manual/install.texi                           |   7 +
 sysdeps/powerpc/powerpc64/le/dl-hwcap-check.h |   9 +-
 sysdeps/s390/s390-64/dl-hwcap-check.h         |   5 +-
 sysdeps/x86/Makefile                          |   1 +
 sysdeps/x86/dl-get-cpu-features.c             |  31 +-
 12 files changed, 697 insertions(+), 386 deletions(-)
 create mode 100644 elf/dl-printf.c


base-commit: ef7c6d42fe163a5e49a478c43e655ce4633fa5ba

Comments

Joseph Myers Jan. 14, 2022, 5:42 p.m. UTC | #1 
I think there should be a NEWS entry for the new feature and configure 
option.
Florian Weimer Jan. 14, 2022, 5:59 p.m. UTC | #2 
* Joseph Myers:

> I think there should be a NEWS entry for the new feature and configure 
> option.

Fair enough.  I'm going to add:

* A new configure option, --with-rtld-early-cflags, can be used to
  specify additional compiler flags for building the early startup code
  of the dynamic linker.  On targets which have CPU compatibility
  checks, this can help to ensure that proper diagnostics are printed if
  the dynamic loader runs on an incompatible CPU.

Thanks,
Florian
Carlos O'Donell Jan. 14, 2022, 6:51 p.m. UTC | #3 
On 1/14/22 12:59, Florian Weimer via Libc-alpha wrote:
> * Joseph Myers:
> 
>> I think there should be a NEWS entry for the new feature and configure 
>> option.
> 
> Fair enough.  I'm going to add:
> 
> * A new configure option, --with-rtld-early-cflags, can be used to
>   specify additional compiler flags for building the early startup code
>   of the dynamic linker.  On targets which have CPU compatibility
>   checks, this can help to ensure that proper diagnostics are printed if
>   the dynamic loader runs on an incompatible CPU.

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>