From patchwork Thu Jul 15 09:08:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 44346 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E5F633858D29 for ; Thu, 15 Jul 2021 09:09:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E5F633858D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626340160; bh=H6wFLE4VALfppSEZdvgNZEbGMcS6EiNpkwTJjKxzSgE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=VHXfHbJ6RBlVQPU0X+iRdkT1yiB9C9UWY6lJ3q0HkMs6agKot/Zxcki7bHcIkOYe+ fYgFVIWJtiCKejsgm2Zxm5NqQx52aMxWzuCk65y0C/h1ZCBKk2tyuntgQZZ4nJs4mj MzI0NX5zr7/4u34OzGtY1PAw+3Kn5NvfdkUHdJPA= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 2C4963858D29 for ; Thu, 15 Jul 2021 09:08:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C4963858D29 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-561-6Id2hu4dOS22mJ8bP5wZ2g-1; Thu, 15 Jul 2021 05:08:56 -0400 X-MC-Unique: 6Id2hu4dOS22mJ8bP5wZ2g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B17CE362FC for ; Thu, 15 Jul 2021 09:08:55 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-73.phx2.redhat.com [10.3.112.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D89DC60854 for ; Thu, 15 Jul 2021 09:08:54 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH v3 00/24] Move nss_dns and parts of libresolv into libc X-From-Line: 1039263f503f5767e03c705c83a780176f1ca06f Mon Sep 17 00:00:00 2001 Message-Id: Date: Thu, 15 Jul 2021 11:08:52 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" I've pushed six already-approved patches, but I didn't want to resequence the rest. ns_skip_name has been fixed. I fuzz-tested it against the old implementation and found what is arguably a bug in the old implementation. I updated the NEWS file with a list of deprecated functions, and a few more based on a review of the remaining libresolv contents. I hope I addressed all review comments. Thanks, Florian Florian Weimer (24): resolv: Deprecate legacy interfaces in libresolv resolv: Move ns_name_skip to its own file and into libc (bug 28091) resolv: Move ns_name_uncompress into its own file and into libc resolv: Move ns_name_pton into its own file and into libc resolv: Move ns_name_pack into its own file and into libc resolv: Move ns_name_compress into its own file and into libc resolv: Move dn_expand to its own file and into libc resolv: Move _getlong, _getshort, __putlong, __putshort to res-putget resolv: Move dn_comp to its own file and into libc resolv: Move dn_skipname to its own file and into libc resolv: Rename res_comp.c to res-name-checking.c and move into libc resolv: Move __res_get_nsaddr to its own file and into libc resolv: Move res_isourserver to its own file and reformat to GNU style resolv: Move ns_makecanon into its own file, and into libc resolv: Move ns_samename into its own file, and into libc resolv: Move res_nameinquery to its own file and into libc resolv: Move res_queriesmatch to its own file and into libc resolv: Move __res_context_hostalias into its own file and into libc resolv: Move res_hostalias into its own file, along with hostalias resolv: Move res_send, res_nsend into libc resolv: Move res_mkquery, res_nmkquery into libc resolv: Move res_query functions into libc resolv: Move nss_dns into libc nss: Directly load nss_dns, without going through dlsym/dlopen NEWS | 14 + include/arpa/nameser.h | 21 +- include/nss_dns.h | 39 ++ include/resolv.h | 22 +- inet/arpa/inet.h | 3 +- nss/nss_files_functions.c | 6 - nss/nss_module.c | 58 ++- nss/nss_module.h | 10 +- resolv/Makefile | 44 +- resolv/Versions | 121 ++++-- resolv/arpa/nameser.h | 33 +- resolv/compat-gethnamaddr.c | 13 +- resolv/dn_comp.c | 103 +++++ resolv/dn_expand.c | 112 +++++ resolv/dn_skipname.c | 103 +++++ resolv/ns_makecanon.c | 50 +++ resolv/ns_name.c | 407 ------------------ resolv/ns_name_compress.c | 50 +++ resolv/ns_name_pack.c | 202 +++++++++ resolv/ns_name_pton.c | 157 +++++++ resolv/ns_name_skip.c | 70 +++ resolv/ns_name_uncompress.c | 45 ++ resolv/ns_parse.c | 4 +- resolv/ns_print.c | 8 +- resolv/ns_samedomain.c | 62 +-- resolv/ns_samename.c | 38 ++ resolv/nss_dns/dns-canon.c | 12 +- resolv/nss_dns/dns-host.c | 50 +-- resolv/nss_dns/dns-network.c | 15 +- resolv/nss_dns_functions.c | 40 ++ resolv/{res_comp.c => res-name-checking.c} | 116 ++--- resolv/res-putget.c | 112 +++++ resolv/res_context_hostalias.c | 132 ++++++ resolv/res_debug.c | 4 +- resolv/res_enable_icmp.c | 4 +- resolv/res_get_nsaddr.c | 39 ++ resolv/res_hostalias.c | 51 +++ resolv/res_isourserver.c | 134 ++++++ resolv/res_mkquery.c | 48 ++- resolv/res_nameinquery.c | 115 +++++ resolv/res_queriesmatch.c | 129 ++++++ resolv/res_query.c | 158 +++---- resolv/res_send.c | 232 ++-------- resolv/resolv-deprecated.c | 56 +++ resolv/resolv-internal.h | 21 +- resolv/resolv.h | 103 ++--- sysdeps/mach/hurd/i386/libc.abilist | 44 ++ sysdeps/mach/hurd/i386/libresolv.abilist | 22 - sysdeps/unix/sysv/linux/aarch64/libc.abilist | 44 ++ .../unix/sysv/linux/aarch64/libresolv.abilist | 22 - sysdeps/unix/sysv/linux/alpha/libc.abilist | 49 +++ .../unix/sysv/linux/alpha/libresolv.abilist | 27 -- sysdeps/unix/sysv/linux/arc/libc.abilist | 44 ++ sysdeps/unix/sysv/linux/arc/libresolv.abilist | 22 - sysdeps/unix/sysv/linux/arm/be/libc.abilist | 44 ++ .../unix/sysv/linux/arm/be/libresolv.abilist | 22 - sysdeps/unix/sysv/linux/arm/le/libc.abilist | 44 ++ .../unix/sysv/linux/arm/le/libresolv.abilist | 22 - sysdeps/unix/sysv/linux/csky/libc.abilist | 44 ++ .../unix/sysv/linux/csky/libresolv.abilist | 22 - sysdeps/unix/sysv/linux/hppa/libc.abilist | 49 +++ .../unix/sysv/linux/hppa/libresolv.abilist | 27 -- sysdeps/unix/sysv/linux/i386/libc.abilist | 49 +++ .../unix/sysv/linux/i386/libresolv.abilist | 27 -- sysdeps/unix/sysv/linux/ia64/libc.abilist | 49 +++ .../unix/sysv/linux/ia64/libresolv.abilist | 27 -- .../sysv/linux/m68k/coldfire/libc.abilist | 44 ++ .../linux/m68k/coldfire/libresolv.abilist | 22 - .../unix/sysv/linux/m68k/m680x0/libc.abilist | 49 +++ .../sysv/linux/m68k/m680x0/libresolv.abilist | 27 -- .../sysv/linux/microblaze/be/libc.abilist | 44 ++ .../linux/microblaze/be/libresolv.abilist | 22 - .../sysv/linux/microblaze/le/libc.abilist | 44 ++ .../linux/microblaze/le/libresolv.abilist | 22 - .../sysv/linux/mips/mips32/fpu/libc.abilist | 49 +++ .../sysv/linux/mips/mips32/libresolv.abilist | 27 -- .../sysv/linux/mips/mips32/nofpu/libc.abilist | 49 +++ .../sysv/linux/mips/mips64/n32/libc.abilist | 49 +++ .../linux/mips/mips64/n32/libresolv.abilist | 27 -- .../sysv/linux/mips/mips64/n64/libc.abilist | 49 +++ .../linux/mips/mips64/n64/libresolv.abilist | 27 -- sysdeps/unix/sysv/linux/nios2/libc.abilist | 44 ++ .../unix/sysv/linux/nios2/libresolv.abilist | 22 - .../linux/powerpc/powerpc32/fpu/libc.abilist | 49 +++ .../linux/powerpc/powerpc32/libresolv.abilist | 27 -- .../powerpc/powerpc32/nofpu/libc.abilist | 49 +++ .../linux/powerpc/powerpc64/be/libc.abilist | 44 ++ .../powerpc/powerpc64/be/libresolv.abilist | 22 - .../linux/powerpc/powerpc64/le/libc.abilist | 44 ++ .../powerpc/powerpc64/le/libresolv.abilist | 22 - .../unix/sysv/linux/riscv/rv32/libc.abilist | 44 ++ .../sysv/linux/riscv/rv32/libresolv.abilist | 22 - .../unix/sysv/linux/riscv/rv64/libc.abilist | 44 ++ .../sysv/linux/riscv/rv64/libresolv.abilist | 22 - .../unix/sysv/linux/s390/s390-32/libc.abilist | 49 +++ .../sysv/linux/s390/s390-32/libresolv.abilist | 27 -- .../unix/sysv/linux/s390/s390-64/libc.abilist | 44 ++ .../sysv/linux/s390/s390-64/libresolv.abilist | 22 - sysdeps/unix/sysv/linux/sh/be/libc.abilist | 49 +++ .../unix/sysv/linux/sh/be/libresolv.abilist | 27 -- sysdeps/unix/sysv/linux/sh/le/libc.abilist | 49 +++ .../unix/sysv/linux/sh/le/libresolv.abilist | 27 -- .../sysv/linux/sparc/sparc32/libc.abilist | 49 +++ .../linux/sparc/sparc32/libresolv.abilist | 27 -- .../sysv/linux/sparc/sparc64/libc.abilist | 49 +++ .../linux/sparc/sparc64/libresolv.abilist | 27 -- .../unix/sysv/linux/x86_64/64/libc.abilist | 44 ++ .../sysv/linux/x86_64/64/libresolv.abilist | 22 - .../unix/sysv/linux/x86_64/x32/libc.abilist | 44 ++ .../sysv/linux/x86_64/x32/libresolv.abilist | 22 - 110 files changed, 3818 insertions(+), 1832 deletions(-) create mode 100644 include/nss_dns.h create mode 100644 resolv/dn_comp.c create mode 100644 resolv/dn_expand.c create mode 100644 resolv/dn_skipname.c create mode 100644 resolv/ns_makecanon.c create mode 100644 resolv/ns_name_compress.c create mode 100644 resolv/ns_name_pack.c create mode 100644 resolv/ns_name_pton.c create mode 100644 resolv/ns_name_skip.c create mode 100644 resolv/ns_name_uncompress.c create mode 100644 resolv/ns_samename.c create mode 100644 resolv/nss_dns_functions.c rename resolv/{res_comp.c => res-name-checking.c} (73%) create mode 100644 resolv/res-putget.c create mode 100644 resolv/res_context_hostalias.c create mode 100644 resolv/res_get_nsaddr.c create mode 100644 resolv/res_hostalias.c create mode 100644 resolv/res_isourserver.c create mode 100644 resolv/res_nameinquery.c create mode 100644 resolv/res_queriesmatch.c create mode 100644 resolv/resolv-deprecated.c