mbox series

[00/14] nptl: Move remaining rwlock functions into libc

Message ID cover.1619199278.git.fweimer@redhat.com
Headers
Series nptl: Move remaining rwlock functions into libc |

Message

Florian Weimer April 23, 2021, 5:36 p.m. UTC 
  The clock*lock are a bit more complex, and I followed what I did in the
mutex and condition variable cases.  I also removed some unsued
<libc-lock.h> functionality.

Tested on i686-linux-gnu and x86_64-linux-gnu.  Built with
build-many-glibcs.py.

Thanks,
Florian

Florian Weimer (14):
  nptl: Move pthread_rwlock_clockrdlock into libc
  nptl: Move pthread_rwlock_clockwrlock into libc
  nptl: Move pthread_rwlock_destroy into libc
  nptl: Move pthread_rwlock_init into libc
  nptl: Move pthread_rwlock_timedrdlock into libc
  nptl: Move pthread_rwlock_timedwrlock into libc
  nptl: Move pthread_rwlock_tryrdlock into libc
  nptl: Move pthread_rwlock_trywrlock into libc
  nptl: Move pthread_rwlockattr_destroy into libc
  nptl: Move pthread_rwlockattr_getkind_np into libc
  nptl: Move pthread_rwlockattr_getpshared into libc
  nptl: Move pthread_rwlockattr_init into libc
  nptl: Move pthread_rwlockattr_setkind_np into libc
  nptl: Move pthread_rwlockattr_setpshared into libc

 nptl/Makefile                                 | 28 +++++------
 nptl/Versions                                 | 49 ++++++++++++-------
 nptl/pthreadP.h                               |  8 +--
 nptl/pthread_rwlock_clockrdlock.c             | 23 ++++++---
 nptl/pthread_rwlock_clockwrlock.c             | 23 ++++++---
 nptl/pthread_rwlock_destroy.c                 | 16 ++++--
 nptl/pthread_rwlock_init.c                    | 20 ++++++--
 nptl/pthread_rwlock_timedrdlock.c             | 23 ++++++---
 nptl/pthread_rwlock_timedwrlock.c             | 23 ++++++---
 nptl/pthread_rwlock_tryrdlock.c               | 15 +++++-
 nptl/pthread_rwlock_trywrlock.c               | 15 +++++-
 nptl/pthread_rwlockattr_destroy.c             | 11 ++++-
 nptl/pthread_rwlockattr_getkind_np.c          | 11 ++++-
 nptl/pthread_rwlockattr_getpshared.c          | 12 ++++-
 nptl/pthread_rwlockattr_init.c                | 11 ++++-
 nptl/pthread_rwlockattr_setkind_np.c          | 11 ++++-
 nptl/pthread_rwlockattr_setpshared.c          | 11 ++++-
 sysdeps/nptl/libc-lockP.h                     | 30 ++----------
 sysdeps/unix/sysv/linux/aarch64/libc.abilist  | 32 ++++++++++++
 .../sysv/linux/aarch64/libpthread.abilist     | 18 -------
 sysdeps/unix/sysv/linux/alpha/libc.abilist    | 32 ++++++++++++
 .../unix/sysv/linux/alpha/libpthread.abilist  | 18 -------
 sysdeps/unix/sysv/linux/arc/libc.abilist      | 32 ++++++++++++
 .../unix/sysv/linux/arc/libpthread.abilist    | 18 -------
 sysdeps/unix/sysv/linux/arm/be/libc.abilist   | 32 ++++++++++++
 .../unix/sysv/linux/arm/be/libpthread.abilist | 18 -------
 sysdeps/unix/sysv/linux/arm/le/libc.abilist   | 32 ++++++++++++
 .../unix/sysv/linux/arm/le/libpthread.abilist | 18 -------
 sysdeps/unix/sysv/linux/csky/libc.abilist     | 32 ++++++++++++
 .../unix/sysv/linux/csky/libpthread.abilist   | 18 -------
 sysdeps/unix/sysv/linux/hppa/libc.abilist     | 32 ++++++++++++
 .../unix/sysv/linux/hppa/libpthread.abilist   | 18 -------
 sysdeps/unix/sysv/linux/i386/libc.abilist     | 32 ++++++++++++
 .../unix/sysv/linux/i386/libpthread.abilist   | 18 -------
 sysdeps/unix/sysv/linux/ia64/libc.abilist     | 32 ++++++++++++
 .../unix/sysv/linux/ia64/libpthread.abilist   | 18 -------
 .../sysv/linux/m68k/coldfire/libc.abilist     | 32 ++++++++++++
 .../linux/m68k/coldfire/libpthread.abilist    | 18 -------
 .../unix/sysv/linux/m68k/m680x0/libc.abilist  | 32 ++++++++++++
 .../sysv/linux/m68k/m680x0/libpthread.abilist | 18 -------
 .../sysv/linux/microblaze/be/libc.abilist     | 32 ++++++++++++
 .../linux/microblaze/be/libpthread.abilist    | 18 -------
 .../sysv/linux/microblaze/le/libc.abilist     | 32 ++++++++++++
 .../linux/microblaze/le/libpthread.abilist    | 18 -------
 .../sysv/linux/mips/mips32/fpu/libc.abilist   | 32 ++++++++++++
 .../sysv/linux/mips/mips32/libpthread.abilist | 18 -------
 .../sysv/linux/mips/mips32/nofpu/libc.abilist | 32 ++++++++++++
 .../sysv/linux/mips/mips64/libpthread.abilist | 18 -------
 .../sysv/linux/mips/mips64/n32/libc.abilist   | 32 ++++++++++++
 .../sysv/linux/mips/mips64/n64/libc.abilist   | 32 ++++++++++++
 sysdeps/unix/sysv/linux/nios2/libc.abilist    | 32 ++++++++++++
 .../unix/sysv/linux/nios2/libpthread.abilist  | 18 -------
 .../linux/powerpc/powerpc32/fpu/libc.abilist  | 32 ++++++++++++
 .../powerpc/powerpc32/libpthread.abilist      | 18 -------
 .../powerpc/powerpc32/nofpu/libc.abilist      | 32 ++++++++++++
 .../linux/powerpc/powerpc64/be/libc.abilist   | 32 ++++++++++++
 .../powerpc/powerpc64/be/libpthread.abilist   | 18 -------
 .../linux/powerpc/powerpc64/le/libc.abilist   | 32 ++++++++++++
 .../powerpc/powerpc64/le/libpthread.abilist   | 18 -------
 .../unix/sysv/linux/riscv/rv32/libc.abilist   | 32 ++++++++++++
 .../sysv/linux/riscv/rv32/libpthread.abilist  | 18 -------
 .../unix/sysv/linux/riscv/rv64/libc.abilist   | 32 ++++++++++++
 .../sysv/linux/riscv/rv64/libpthread.abilist  | 18 -------
 .../unix/sysv/linux/s390/s390-32/libc.abilist | 32 ++++++++++++
 .../linux/s390/s390-32/libpthread.abilist     | 18 -------
 .../unix/sysv/linux/s390/s390-64/libc.abilist | 32 ++++++++++++
 .../linux/s390/s390-64/libpthread.abilist     | 18 -------
 sysdeps/unix/sysv/linux/sh/be/libc.abilist    | 32 ++++++++++++
 .../unix/sysv/linux/sh/be/libpthread.abilist  | 18 -------
 sysdeps/unix/sysv/linux/sh/le/libc.abilist    | 32 ++++++++++++
 .../unix/sysv/linux/sh/le/libpthread.abilist  | 18 -------
 .../sysv/linux/sparc/sparc32/libc.abilist     | 32 ++++++++++++
 .../linux/sparc/sparc32/libpthread.abilist    | 18 -------
 .../sysv/linux/sparc/sparc64/libc.abilist     | 32 ++++++++++++
 .../linux/sparc/sparc64/libpthread.abilist    | 18 -------
 .../unix/sysv/linux/x86_64/64/libc.abilist    | 32 ++++++++++++
 .../sysv/linux/x86_64/64/libpthread.abilist   | 18 -------
 .../unix/sysv/linux/x86_64/x32/libc.abilist   | 32 ++++++++++++
 .../sysv/linux/x86_64/x32/libpthread.abilist  | 18 -------
 79 files changed, 1251 insertions(+), 635 deletions(-)

Comments

Carlos O'Donell May 2, 2021, 7:30 p.m. UTC | #1 
On 4/23/21 1:36 PM, Florian Weimer via Libc-alpha wrote:
> The clock*lock are a bit more complex, and I followed what I did in the
> mutex and condition variable cases.  I also removed some unsued
> <libc-lock.h> functionality.
> 
> Tested on i686-linux-gnu and x86_64-linux-gnu.  Built with
> build-many-glibcs.py.

Overall tested and reviewed on x86_64 and i686.

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>

 
> Thanks,
> Florian
> 
> Florian Weimer (14):
>   nptl: Move pthread_rwlock_clockrdlock into libc
>   nptl: Move pthread_rwlock_clockwrlock into libc
>   nptl: Move pthread_rwlock_destroy into libc
>   nptl: Move pthread_rwlock_init into libc
>   nptl: Move pthread_rwlock_timedrdlock into libc
>   nptl: Move pthread_rwlock_timedwrlock into libc
>   nptl: Move pthread_rwlock_tryrdlock into libc
>   nptl: Move pthread_rwlock_trywrlock into libc
>   nptl: Move pthread_rwlockattr_destroy into libc
>   nptl: Move pthread_rwlockattr_getkind_np into libc
>   nptl: Move pthread_rwlockattr_getpshared into libc
>   nptl: Move pthread_rwlockattr_init into libc
>   nptl: Move pthread_rwlockattr_setkind_np into libc
>   nptl: Move pthread_rwlockattr_setpshared into libc
> 
>  nptl/Makefile                                 | 28 +++++------
>  nptl/Versions                                 | 49 ++++++++++++-------
>  nptl/pthreadP.h                               |  8 +--
>  nptl/pthread_rwlock_clockrdlock.c             | 23 ++++++---
>  nptl/pthread_rwlock_clockwrlock.c             | 23 ++++++---
>  nptl/pthread_rwlock_destroy.c                 | 16 ++++--
>  nptl/pthread_rwlock_init.c                    | 20 ++++++--
>  nptl/pthread_rwlock_timedrdlock.c             | 23 ++++++---
>  nptl/pthread_rwlock_timedwrlock.c             | 23 ++++++---
>  nptl/pthread_rwlock_tryrdlock.c               | 15 +++++-
>  nptl/pthread_rwlock_trywrlock.c               | 15 +++++-
>  nptl/pthread_rwlockattr_destroy.c             | 11 ++++-
>  nptl/pthread_rwlockattr_getkind_np.c          | 11 ++++-
>  nptl/pthread_rwlockattr_getpshared.c          | 12 ++++-
>  nptl/pthread_rwlockattr_init.c                | 11 ++++-
>  nptl/pthread_rwlockattr_setkind_np.c          | 11 ++++-
>  nptl/pthread_rwlockattr_setpshared.c          | 11 ++++-
>  sysdeps/nptl/libc-lockP.h                     | 30 ++----------
>  sysdeps/unix/sysv/linux/aarch64/libc.abilist  | 32 ++++++++++++
>  .../sysv/linux/aarch64/libpthread.abilist     | 18 -------
>  sysdeps/unix/sysv/linux/alpha/libc.abilist    | 32 ++++++++++++
>  .../unix/sysv/linux/alpha/libpthread.abilist  | 18 -------
>  sysdeps/unix/sysv/linux/arc/libc.abilist      | 32 ++++++++++++
>  .../unix/sysv/linux/arc/libpthread.abilist    | 18 -------
>  sysdeps/unix/sysv/linux/arm/be/libc.abilist   | 32 ++++++++++++
>  .../unix/sysv/linux/arm/be/libpthread.abilist | 18 -------
>  sysdeps/unix/sysv/linux/arm/le/libc.abilist   | 32 ++++++++++++
>  .../unix/sysv/linux/arm/le/libpthread.abilist | 18 -------
>  sysdeps/unix/sysv/linux/csky/libc.abilist     | 32 ++++++++++++
>  .../unix/sysv/linux/csky/libpthread.abilist   | 18 -------
>  sysdeps/unix/sysv/linux/hppa/libc.abilist     | 32 ++++++++++++
>  .../unix/sysv/linux/hppa/libpthread.abilist   | 18 -------
>  sysdeps/unix/sysv/linux/i386/libc.abilist     | 32 ++++++++++++
>  .../unix/sysv/linux/i386/libpthread.abilist   | 18 -------
>  sysdeps/unix/sysv/linux/ia64/libc.abilist     | 32 ++++++++++++
>  .../unix/sysv/linux/ia64/libpthread.abilist   | 18 -------
>  .../sysv/linux/m68k/coldfire/libc.abilist     | 32 ++++++++++++
>  .../linux/m68k/coldfire/libpthread.abilist    | 18 -------
>  .../unix/sysv/linux/m68k/m680x0/libc.abilist  | 32 ++++++++++++
>  .../sysv/linux/m68k/m680x0/libpthread.abilist | 18 -------
>  .../sysv/linux/microblaze/be/libc.abilist     | 32 ++++++++++++
>  .../linux/microblaze/be/libpthread.abilist    | 18 -------
>  .../sysv/linux/microblaze/le/libc.abilist     | 32 ++++++++++++
>  .../linux/microblaze/le/libpthread.abilist    | 18 -------
>  .../sysv/linux/mips/mips32/fpu/libc.abilist   | 32 ++++++++++++
>  .../sysv/linux/mips/mips32/libpthread.abilist | 18 -------
>  .../sysv/linux/mips/mips32/nofpu/libc.abilist | 32 ++++++++++++
>  .../sysv/linux/mips/mips64/libpthread.abilist | 18 -------
>  .../sysv/linux/mips/mips64/n32/libc.abilist   | 32 ++++++++++++
>  .../sysv/linux/mips/mips64/n64/libc.abilist   | 32 ++++++++++++
>  sysdeps/unix/sysv/linux/nios2/libc.abilist    | 32 ++++++++++++
>  .../unix/sysv/linux/nios2/libpthread.abilist  | 18 -------
>  .../linux/powerpc/powerpc32/fpu/libc.abilist  | 32 ++++++++++++
>  .../powerpc/powerpc32/libpthread.abilist      | 18 -------
>  .../powerpc/powerpc32/nofpu/libc.abilist      | 32 ++++++++++++
>  .../linux/powerpc/powerpc64/be/libc.abilist   | 32 ++++++++++++
>  .../powerpc/powerpc64/be/libpthread.abilist   | 18 -------
>  .../linux/powerpc/powerpc64/le/libc.abilist   | 32 ++++++++++++
>  .../powerpc/powerpc64/le/libpthread.abilist   | 18 -------
>  .../unix/sysv/linux/riscv/rv32/libc.abilist   | 32 ++++++++++++
>  .../sysv/linux/riscv/rv32/libpthread.abilist  | 18 -------
>  .../unix/sysv/linux/riscv/rv64/libc.abilist   | 32 ++++++++++++
>  .../sysv/linux/riscv/rv64/libpthread.abilist  | 18 -------
>  .../unix/sysv/linux/s390/s390-32/libc.abilist | 32 ++++++++++++
>  .../linux/s390/s390-32/libpthread.abilist     | 18 -------
>  .../unix/sysv/linux/s390/s390-64/libc.abilist | 32 ++++++++++++
>  .../linux/s390/s390-64/libpthread.abilist     | 18 -------
>  sysdeps/unix/sysv/linux/sh/be/libc.abilist    | 32 ++++++++++++
>  .../unix/sysv/linux/sh/be/libpthread.abilist  | 18 -------
>  sysdeps/unix/sysv/linux/sh/le/libc.abilist    | 32 ++++++++++++
>  .../unix/sysv/linux/sh/le/libpthread.abilist  | 18 -------
>  .../sysv/linux/sparc/sparc32/libc.abilist     | 32 ++++++++++++
>  .../linux/sparc/sparc32/libpthread.abilist    | 18 -------
>  .../sysv/linux/sparc/sparc64/libc.abilist     | 32 ++++++++++++
>  .../linux/sparc/sparc64/libpthread.abilist    | 18 -------
>  .../unix/sysv/linux/x86_64/64/libc.abilist    | 32 ++++++++++++
>  .../sysv/linux/x86_64/64/libpthread.abilist   | 18 -------
>  .../unix/sysv/linux/x86_64/x32/libc.abilist   | 32 ++++++++++++
>  .../sysv/linux/x86_64/x32/libpthread.abilist  | 18 -------
>  79 files changed, 1251 insertions(+), 635 deletions(-)
>