From patchwork Fri Apr 23 12:01:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 43109 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0DB5F3ADB46F; Fri, 23 Apr 2021 12:01:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DB5F3ADB46F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619179275; bh=NL3WfAswJRCPg81miJxJUU9e1FcUNCiY+vMIYmEWTYA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=a2U0ZbS3IGHjWLb/J5cbWl8let7W3IWpMfKDyhv5ATK4sZMurXdlTvZuffZxIJLyo Ode3vCmueatXAKX0deTfCZY22buf1mXT76VW6/esOsz7QWOOywCi3BC4spNEtcyD/g aOiOSFZhR099EYFY/bDJLioCCHJZ95nAevI0DPFc= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8D8D63ADB46B for ; Fri, 23 Apr 2021 12:01:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8D8D63ADB46B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340--0Y9cCGfOQqGk_r4O3rZzw-1; Fri, 23 Apr 2021 08:01:08 -0400 X-MC-Unique: -0Y9cCGfOQqGk_r4O3rZzw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5C8C100A606 for ; Fri, 23 Apr 2021 12:01:07 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-20.ams2.redhat.com [10.36.113.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 197CB60939 for ; Fri, 23 Apr 2021 12:01:06 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH 0/4] nptl: Move spinlock symbols into libc Message-Id: Date: Fri, 23 Apr 2021 14:01:26 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" This is slightly more complicated than usual because there are many C and assembler implementations of the spinlock functions. Full consolidation in a single C implementation is not possible because the algorithm is subtly different, and PTHREAD_SPINLOCK_INITIALIZER varies. I did not try to simplify this, but instead patched all the different implementations. Tested on i686-linux-gnu, powerpc64le-linux-gnu, x86_64-linux-gnu. Built with build-many-glibcs.py, both with defaults and with binutils 2.33 and GCC 9. Florian Weimer (4): nptl: Move pthread_spin_destroy into libc nptl: Move pthread_spin_init, Move pthread_spin_unlock into libc nptl: Move pthread_spin_lock into libc nptl: Move pthread_spin_trylock into libc nptl/Makefile | 10 ++++----- nptl/Versions | 15 ++++++++----- nptl/pthread_spin_destroy.c | 11 ++++++++-- nptl/pthread_spin_init.c | 8 ++++++- nptl/pthread_spin_lock.c | 8 ++++++- nptl/pthread_spin_trylock.c | 10 ++++++++- nptl/pthread_spin_unlock.c | 10 ++++++++- sysdeps/alpha/nptl/pthread_spin_lock.S | 14 +++++++++---- sysdeps/alpha/nptl/pthread_spin_trylock.S | 16 ++++++++++---- sysdeps/hppa/nptl/pthread_spin_init.c | 10 ++++++++- sysdeps/hppa/nptl/pthread_spin_unlock.c | 10 ++++++++- sysdeps/i386/nptl/pthread_spin_lock.S | 10 +++++++-- sysdeps/i386/nptl/pthread_spin_unlock.S | 16 +++++++++----- sysdeps/i386/pthread_spin_trylock.S | 13 +++++++++--- sysdeps/ia64/nptl/pthread_spin_lock.c | 10 ++++++++- sysdeps/ia64/nptl/pthread_spin_trylock.c | 10 ++++++++- sysdeps/ia64/nptl/pthread_spin_unlock.c | 11 ++++++++-- sysdeps/powerpc/nptl/pthread_spin_lock.c | 8 ++++++- sysdeps/powerpc/nptl/pthread_spin_trylock.c | 10 ++++++++- sysdeps/powerpc/nptl/pthread_spin_unlock.c | 10 ++++++++- sysdeps/sh/nptl/pthread_spin_lock.c | 8 ++++++- sysdeps/sh/nptl/pthread_spin_trylock.S | 16 ++++++++++---- sysdeps/sh/nptl/pthread_spin_unlock.S | 21 ++++++++++++------- sysdeps/sparc/sparc32/pthread_spin_lock.S | 10 +++++++-- sysdeps/sparc/sparc32/pthread_spin_trylock.S | 12 +++++++++-- sysdeps/sparc/sparc64/pthread_spin_lock.S | 10 +++++++-- sysdeps/sparc/sparc64/pthread_spin_trylock.S | 12 +++++++++-- sysdeps/sparc/sparc64/pthread_spin_unlock.S | 14 ++++++++++--- sysdeps/unix/sysv/linux/aarch64/libc.abilist | 10 +++++++++ .../sysv/linux/aarch64/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/alpha/libc.abilist | 10 +++++++++ .../unix/sysv/linux/alpha/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/arc/libc.abilist | 10 +++++++++ .../unix/sysv/linux/arc/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/arm/be/libc.abilist | 10 +++++++++ .../unix/sysv/linux/arm/be/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/arm/le/libc.abilist | 10 +++++++++ .../unix/sysv/linux/arm/le/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/csky/libc.abilist | 10 +++++++++ .../unix/sysv/linux/csky/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/hppa/libc.abilist | 10 +++++++++ .../unix/sysv/linux/hppa/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/i386/libc.abilist | 10 +++++++++ .../unix/sysv/linux/i386/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/ia64/libc.abilist | 10 +++++++++ .../unix/sysv/linux/ia64/libpthread.abilist | 5 ----- .../sysv/linux/m68k/coldfire/libc.abilist | 10 +++++++++ .../linux/m68k/coldfire/libpthread.abilist | 5 ----- .../unix/sysv/linux/m68k/m680x0/libc.abilist | 10 +++++++++ .../sysv/linux/m68k/m680x0/libpthread.abilist | 5 ----- .../sysv/linux/microblaze/be/libc.abilist | 10 +++++++++ .../linux/microblaze/be/libpthread.abilist | 5 ----- .../sysv/linux/microblaze/le/libc.abilist | 10 +++++++++ .../linux/microblaze/le/libpthread.abilist | 5 ----- .../sysv/linux/mips/mips32/fpu/libc.abilist | 10 +++++++++ .../sysv/linux/mips/mips32/libpthread.abilist | 5 ----- .../sysv/linux/mips/mips32/nofpu/libc.abilist | 10 +++++++++ .../sysv/linux/mips/mips64/libpthread.abilist | 5 ----- .../sysv/linux/mips/mips64/n32/libc.abilist | 10 +++++++++ .../sysv/linux/mips/mips64/n64/libc.abilist | 10 +++++++++ sysdeps/unix/sysv/linux/nios2/libc.abilist | 10 +++++++++ .../unix/sysv/linux/nios2/libpthread.abilist | 5 ----- .../linux/powerpc/powerpc32/fpu/libc.abilist | 10 +++++++++ .../powerpc/powerpc32/libpthread.abilist | 5 ----- .../powerpc/powerpc32/nofpu/libc.abilist | 10 +++++++++ .../linux/powerpc/powerpc64/be/libc.abilist | 10 +++++++++ .../powerpc/powerpc64/be/libpthread.abilist | 5 ----- .../linux/powerpc/powerpc64/le/libc.abilist | 10 +++++++++ .../powerpc/powerpc64/le/libpthread.abilist | 5 ----- .../unix/sysv/linux/riscv/rv32/libc.abilist | 10 +++++++++ .../sysv/linux/riscv/rv32/libpthread.abilist | 5 ----- .../unix/sysv/linux/riscv/rv64/libc.abilist | 10 +++++++++ .../sysv/linux/riscv/rv64/libpthread.abilist | 5 ----- .../unix/sysv/linux/s390/s390-32/libc.abilist | 10 +++++++++ .../linux/s390/s390-32/libpthread.abilist | 5 ----- .../unix/sysv/linux/s390/s390-64/libc.abilist | 10 +++++++++ .../linux/s390/s390-64/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/sh/be/libc.abilist | 10 +++++++++ .../unix/sysv/linux/sh/be/libpthread.abilist | 5 ----- sysdeps/unix/sysv/linux/sh/le/libc.abilist | 10 +++++++++ .../unix/sysv/linux/sh/le/libpthread.abilist | 5 ----- .../sysv/linux/sparc/sparc32/libc.abilist | 10 +++++++++ .../linux/sparc/sparc32/libpthread.abilist | 5 ----- .../sysv/linux/sparc/sparc64/libc.abilist | 10 +++++++++ .../linux/sparc/sparc64/libpthread.abilist | 5 ----- .../unix/sysv/linux/x86_64/64/libc.abilist | 10 +++++++++ .../sysv/linux/x86_64/64/libpthread.abilist | 5 ----- .../unix/sysv/linux/x86_64/x32/libc.abilist | 10 +++++++++ .../sysv/linux/x86_64/x32/libpthread.abilist | 5 ----- sysdeps/x86_64/nptl/pthread_spin_lock.S | 10 +++++++-- sysdeps/x86_64/nptl/pthread_spin_trylock.S | 13 +++++++++--- sysdeps/x86_64/nptl/pthread_spin_unlock.S | 16 +++++++++----- 92 files changed, 606 insertions(+), 221 deletions(-)